* [dpdk-stable] [PATCH v2 1/2] bus/fslmc: fix undefined reference of memsegs
@ 2018-09-10 12:26 Cian Ferriter
2018-09-10 12:37 ` Ferriter, Cian
0 siblings, 1 reply; 2+ messages in thread
From: Cian Ferriter @ 2018-09-10 12:26 UTC (permalink / raw)
To: cferrite, sugeshch; +Cc: Hemant Agrawal, stable, Cian Ferriter
From: Hemant Agrawal <hemant.agrawal@nxp.com>
This patch fix the undefined reference issue with rte_dpaa2_memsegs
when compiled in shared lib mode with EXTRA_CFLAGS="-g -O0"
Bugzilla ID: 61
Fixes: 365fb925d3b3 ("bus/fslmc: optimize physical to virtual address search")
Cc: stable@dpdk.org
Reported-by: Keith Wiles <keith.wiles@intel.com>
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>
Signed-off-by: Cian Ferriter <cian.ferriter@intel.com>
---
drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c | 7 +++++++
drivers/bus/fslmc/rte_bus_fslmc_version.map | 1 +
drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 7 -------
drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map | 1 -
4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c b/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c
index 39c5adf..db49d63 100644
--- a/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c
+++ b/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c
@@ -28,6 +28,13 @@
#include "portal/dpaa2_hw_pvt.h"
#include "portal/dpaa2_hw_dpio.h"
+/* List of all the memseg information locally maintained in dpaa2 driver. This
+ * is to optimize the PA_to_VA searches until a better mechanism (algo) is
+ * available.
+ */
+struct dpaa2_memseg_list rte_dpaa2_memsegs
+ = TAILQ_HEAD_INITIALIZER(rte_dpaa2_memsegs);
+
TAILQ_HEAD(dpbp_dev_list, dpaa2_dpbp_dev);
static struct dpbp_dev_list dpbp_dev_list
= TAILQ_HEAD_INITIALIZER(dpbp_dev_list); /*!< DPBP device list */
diff --git a/drivers/bus/fslmc/rte_bus_fslmc_version.map b/drivers/bus/fslmc/rte_bus_fslmc_version.map
index fe45a11..b4a8817 100644
--- a/drivers/bus/fslmc/rte_bus_fslmc_version.map
+++ b/drivers/bus/fslmc/rte_bus_fslmc_version.map
@@ -114,5 +114,6 @@ DPDK_18.05 {
dpdmai_open;
dpdmai_set_rx_queue;
rte_dpaa2_free_dpci_dev;
+ rte_dpaa2_memsegs;
} DPDK_18.02;
diff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
index 7d0435f..84ff128 100644
--- a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
+++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
@@ -33,13 +33,6 @@
struct dpaa2_bp_info rte_dpaa2_bpid_info[MAX_BPID];
static struct dpaa2_bp_list *h_bp_list;
-/* List of all the memseg information locally maintained in dpaa2 driver. This
- * is to optimize the PA_to_VA searches until a better mechanism (algo) is
- * available.
- */
-struct dpaa2_memseg_list rte_dpaa2_memsegs
- = TAILQ_HEAD_INITIALIZER(rte_dpaa2_memsegs);
-
/* Dynamic logging identified for mempool */
int dpaa2_logtype_mempool;
diff --git a/drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map b/drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map
index b9d996a..b45e7a9 100644
--- a/drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map
+++ b/drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map
@@ -3,7 +3,6 @@ DPDK_17.05 {
rte_dpaa2_bpid_info;
rte_dpaa2_mbuf_alloc_bulk;
- rte_dpaa2_memsegs;
local: *;
};
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [PATCH v2 1/2] bus/fslmc: fix undefined reference of memsegs
2018-09-10 12:26 [dpdk-stable] [PATCH v2 1/2] bus/fslmc: fix undefined reference of memsegs Cian Ferriter
@ 2018-09-10 12:37 ` Ferriter, Cian
0 siblings, 0 replies; 2+ messages in thread
From: Ferriter, Cian @ 2018-09-10 12:37 UTC (permalink / raw)
To: Ferriter, Cian, Chandran, Sugesh; +Cc: Hemant Agrawal, stable
Please ignore this mail. An error on my part when using the "git send-email" CMD.
> -----Original Message-----
> From: Ferriter, Cian
> Sent: 10 September 2018 13:27
> To: cferrite; sugeshch
> Cc: Hemant Agrawal <hemant.agrawal@nxp.com>; stable@dpdk.org;
> Ferriter, Cian <cian.ferriter@intel.com>
> Subject: [PATCH v2 1/2] bus/fslmc: fix undefined reference of memsegs
>
> From: Hemant Agrawal <hemant.agrawal@nxp.com>
>
> This patch fix the undefined reference issue with rte_dpaa2_memsegs when
> compiled in shared lib mode with EXTRA_CFLAGS="-g -O0"
>
> Bugzilla ID: 61
> Fixes: 365fb925d3b3 ("bus/fslmc: optimize physical to virtual address search")
> Cc: stable@dpdk.org
>
> Reported-by: Keith Wiles <keith.wiles@intel.com>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> Signed-off-by: Cian Ferriter <cian.ferriter@intel.com>
> ---
> drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c | 7 +++++++
> drivers/bus/fslmc/rte_bus_fslmc_version.map | 1 +
> drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 7 -------
> drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map | 1 -
> 4 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c
> b/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c
> index 39c5adf..db49d63 100644
> --- a/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c
> +++ b/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c
> @@ -28,6 +28,13 @@
> #include "portal/dpaa2_hw_pvt.h"
> #include "portal/dpaa2_hw_dpio.h"
>
> +/* List of all the memseg information locally maintained in dpaa2
> +driver. This
> + * is to optimize the PA_to_VA searches until a better mechanism (algo)
> +is
> + * available.
> + */
> +struct dpaa2_memseg_list rte_dpaa2_memsegs
> + = TAILQ_HEAD_INITIALIZER(rte_dpaa2_memsegs);
> +
> TAILQ_HEAD(dpbp_dev_list, dpaa2_dpbp_dev); static struct dpbp_dev_list
> dpbp_dev_list
> = TAILQ_HEAD_INITIALIZER(dpbp_dev_list); /*!< DPBP device list */
> diff --git a/drivers/bus/fslmc/rte_bus_fslmc_version.map
> b/drivers/bus/fslmc/rte_bus_fslmc_version.map
> index fe45a11..b4a8817 100644
> --- a/drivers/bus/fslmc/rte_bus_fslmc_version.map
> +++ b/drivers/bus/fslmc/rte_bus_fslmc_version.map
> @@ -114,5 +114,6 @@ DPDK_18.05 {
> dpdmai_open;
> dpdmai_set_rx_queue;
> rte_dpaa2_free_dpci_dev;
> + rte_dpaa2_memsegs;
>
> } DPDK_18.02;
> diff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
> b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
> index 7d0435f..84ff128 100644
> --- a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
> +++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
> @@ -33,13 +33,6 @@
> struct dpaa2_bp_info rte_dpaa2_bpid_info[MAX_BPID]; static struct
> dpaa2_bp_list *h_bp_list;
>
> -/* List of all the memseg information locally maintained in dpaa2 driver. This
> - * is to optimize the PA_to_VA searches until a better mechanism (algo) is
> - * available.
> - */
> -struct dpaa2_memseg_list rte_dpaa2_memsegs
> - = TAILQ_HEAD_INITIALIZER(rte_dpaa2_memsegs);
> -
> /* Dynamic logging identified for mempool */ int dpaa2_logtype_mempool;
>
> diff --git a/drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map
> b/drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map
> index b9d996a..b45e7a9 100644
> --- a/drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map
> +++ b/drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map
> @@ -3,7 +3,6 @@ DPDK_17.05 {
>
> rte_dpaa2_bpid_info;
> rte_dpaa2_mbuf_alloc_bulk;
> - rte_dpaa2_memsegs;
>
> local: *;
> };
> --
> 2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-10 12:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-10 12:26 [dpdk-stable] [PATCH v2 1/2] bus/fslmc: fix undefined reference of memsegs Cian Ferriter
2018-09-10 12:37 ` Ferriter, Cian
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).