From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id B1CA06CD1 for ; Wed, 12 Oct 2016 08:43:50 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 11 Oct 2016 23:43:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,332,1473145200"; d="scan'208";a="1043572416" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by orsmga001.jf.intel.com with ESMTP; 11 Oct 2016 23:43:49 -0700 Date: Wed, 12 Oct 2016 14:44:24 +0800 From: Yuanhan Liu To: Olivier Matz Cc: dpdk stable Message-ID: <57fddbc8.5vw9kAEtJve+DKZt%yuanhan.liu@linux.intel.com> User-Agent: Heirloom mailx 12.5 7/5/10 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'mem: fix build with -O1' has been queued to stable release 16.07.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Oct 2016 06:43:51 -0000 Hi, FYI, your patch has been queued to stable release 16.07.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before this Friday. So please shutout if anyone has objections. Thanks. --yliu --- >>From d90ba37e63ece020c6e9274be54350f0887eeb03 Mon Sep 17 00:00:00 2001 From: Olivier Matz Date: Mon, 19 Sep 2016 14:26:51 +0200 Subject: [PATCH] mem: fix build with -O1 [ upstream commit 11fd19f7646743c973b9de52d75120045e62f116 ] MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When compiled with EXTRA_CFLAGS="-O1", the compiler is not able to detect that size is always initialized when used, and issues a wrong warning: eal_memory.c: In function ‘rte_eal_hugepage_attach’: eal_memory.c:1684:3: error: ‘size’ may be used uninitialized in this function [-Werror=maybe-uninitialized] munmap(hp, size); ^ Workaround this issue by initializing size to 0. Seen on gcc (Debian 5.4.1-1) 5.4.1 20160803. Signed-off-by: Olivier Matz --- lib/librte_eal/linuxapp/eal/eal_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c index 575de63..c04cff0 100644 --- a/lib/librte_eal/linuxapp/eal/eal_memory.c +++ b/lib/librte_eal/linuxapp/eal/eal_memory.c @@ -1553,7 +1553,7 @@ rte_eal_hugepage_attach(void) unsigned num_hp = 0; unsigned i, s = 0; /* s used to track the segment number */ unsigned max_seg = RTE_MAX_MEMSEG; - off_t size; + off_t size = 0; int fd, fd_zero = -1, fd_hugepage = -1; if (aslr_enabled() > 0) { -- 1.9.0