From: Thomas Monjalon <thomas@monjalon.net>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
dev@dpdk.org, Harry van Haaren <harry.van.haaren@intel.com>,
Remy Horton <remy.horton@intel.com>,
Reshma Pattan <reshma.pattan@intel.com>,
stable@dpdk.org
Subject: Re: [PATCH] latencystats: fix missing f suffix on literal float
Date: Wed, 29 May 2024 16:38:55 +0200 [thread overview]
Message-ID: <5842625.1B3tZ46Xf9@thomas> (raw)
In-Reply-To: <20240415231405.GA31632@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
16/04/2024 01:14, Tyler Retzlaff:
> On Mon, Apr 15, 2024 at 03:17:38PM -0700, Stephen Hemminger wrote:
> > On Mon, 15 Apr 2024 14:32:26 -0700
> > Tyler Retzlaff <roretzla@linux.microsoft.com> wrote:
> >
> > > Add missing f suffix to floating point literal to avoid warning about
> > > truncation from double to float.
> > >
> > > Fixes: 5cd3cac9ed22 ("latency: added new library for latency stats")
> > > Cc: reshma.pattan@intel.com
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > > ---
> > > - const float alpha = 0.2;
> > > + const float alpha = 0.2f;
> >
> > The use of floating point in fast path here is unnecessary.
> > Even without doing the full per-core values, this could just change
> > to an alpha of .25 and use fast fixed point math.
>
> agree, though my thoughts are make this code correct optimization is for
> the maintainer. if they submit an alternate series i can withdraw this
> patch. otherwise i think we should take it as-is.
OK to fix build warning now.
Applied, thanks.
prev parent reply other threads:[~2024-05-29 14:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 21:32 Tyler Retzlaff
2024-04-15 22:17 ` Stephen Hemminger
2024-04-15 23:14 ` Tyler Retzlaff
2024-05-29 14:38 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5842625.1B3tZ46Xf9@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=remy.horton@intel.com \
--cc=reshma.pattan@intel.com \
--cc=roretzla@linux.microsoft.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).