From: "Xueming(Steven) Li" <xuemingl@nvidia.com>
To: "tudor.cornea@gmail.com" <tudor.cornea@gmail.com>,
"stable@dpdk.org" <stable@dpdk.org>
Cc: "pogonarumihai@gmail.com" <pogonarumihai@gmail.com>
Subject: Re: [PATCH 20.11] net/af_packet: fix ignoring full ring on Tx
Date: Sat, 27 Nov 2021 14:31:28 +0000 [thread overview]
Message-ID: <585c46e00fb063a352659012f83a61c114abe0ad.camel@nvidia.com> (raw)
In-Reply-To: <1636623649-57152-1-git-send-email-tudor.cornea@gmail.com>
On Thu, 2021-11-11 at 11:40 +0200, Tudor Cornea wrote:
> [ upstream commit f86d553cc180f9a65e115edb5641a49bbf2cf2f0 ]
>
> The poll call can return POLLERR which is ignored, or it can return
> POLLOUT, even if there are no free frames in the mmap-ed area.
>
> We can account for both of these cases by re-checking if the next
> frame is empty before writing into it.
>
> We have attempted to reproduce this issue with pktgen-dpdk, using
> the following configuration.
>
> pktgen -l 1-4 -n 4 --proc-type=primary --no-pci --no-telemetry \
> --no-huge -m 512 \
> --vdev=net_af_packet0,iface=eth1,blocksz=16384,framesz=8192, \
> framecnt=2048,qpairs=1,qdisc_bypass=0 \
> -- \
> -P \
> -T \
> -m "3.0" \
> -f themes/black-yellow.theme
>
> We configure a low tx rate (~ 335 packets / second) and a small
> packet size, of about 300 Bytes from the pktgen CLI.
>
> set 0 size 300
> set 0 rate 0.008
> set 0 burst 1
> start 0
>
> After bringing the interface down, and up again, we seem to arrive
> in a state in which the tx rate is inconsistent, and does not recover.
>
> ifconfig eth1 down; sleep 7; ifconfig eth1 up
>
> [1] http://code.dpdk.org/pktgen-dpdk/pktgen-20.11.2/source/INSTALL.md
>
> Fixes: 364e08f2bbc0 ("af_packet: add PMD for AF_PACKET-based virtual devices")
>
> Signed-off-by: Mihai Pogonaru <pogonarumihai@gmail.com>
> Signed-off-by: Tudor Cornea <tudor.cornea@gmail.com>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
Applied to 20.11.4 list, thanks!
prev parent reply other threads:[~2021-11-27 14:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 9:40 Tudor Cornea
2021-11-27 14:31 ` Xueming(Steven) Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=585c46e00fb063a352659012f83a61c114abe0ad.camel@nvidia.com \
--to=xuemingl@nvidia.com \
--cc=pogonarumihai@gmail.com \
--cc=stable@dpdk.org \
--cc=tudor.cornea@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).