From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 172D4A0C45 for ; Fri, 8 Oct 2021 19:01:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C8BD4068F; Fri, 8 Oct 2021 19:01:39 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 6378A4067A; Fri, 8 Oct 2021 19:01:36 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10131"; a="225324398" X-IronPort-AV: E=Sophos;i="5.85,358,1624345200"; d="scan'208";a="225324398" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2021 10:01:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,358,1624345200"; d="scan'208";a="561376794" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by FMSMGA003.fm.intel.com with ESMTP; 08 Oct 2021 10:01:24 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 8 Oct 2021 10:01:24 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 8 Oct 2021 10:01:24 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.171) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 8 Oct 2021 10:01:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ne2+1jMXMECaJt8S3u1qvvOKSSAZLrIbo4VDWTC6S+kYr6q6Mcy7Y73M5fW4io0U0mFqJodsYrJgdhdwGZnmRVJoJFbVcUmL8I3x388o7WTmN+qZm8dwPV46wp9Gh59Cv+cVr+/uNJ7R/S7XcjQNjD72upX0PUKcNoMtIQQG98B5EShZILBvOs7r7dagWYvwZw2cvDPvP8TJnA0fVgRHdOBFPeC99CPoQeXbHWNyVMxWoum8Laplj5EsJKn4TKVZ5clLObEC9TDBDI+UX3yj68sAYaXpveQlSSWSrCrPqf/w/wnwJi/Ymhho1R/+g4x8QFocHgWE+785QTr4dPtwag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fs68KueMq9xQEhNFfl8iN3uFGvC2pTXjusEO3dqxvaU=; b=kFFcPPRvKksbVJtS5RHgOB9Ep+uF6hbMAmVw63509n9gcLtfGuNRLn7bcuzQmPYBE8uMlrdIDkjUXkgPqXL6JhZ3s0zAoHK9fTEiRj7b7eHSquGhBd4M9o8+xqXRmX38lhB0aBcDCEt0NpeXBPQzYQnkqlqZagPkL+WeFPRy98VBTZPVQRTWrpPJVAAAu5iH0cwFUAJZwd+lUqM0II+f00hkshOkP+UfNfFvWgTOdA/Gd2eIh5M1nHLHRk2S1syCNEbvwNpQ9q3RuUNTaVl/4ipcj4pRtQPIEkmOlsAZ6sQgsb5uoBU6TlYIFvj/zcE8iUV3bae0hRIqIU0bWb1lXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fs68KueMq9xQEhNFfl8iN3uFGvC2pTXjusEO3dqxvaU=; b=BFGfUjKaq7wAKe3zMVq/Z/SOvW6O0DdNezMjhfVpJrShJZKUS9Tm8/u4hSfP16linTemKmWkG4bOeB0EZOC+aK1Idsy1WPf9pQlWyjsD9wMclvOc3v/rZesH2JkMv49yYyRwS0n07guiRER+y2mT7kuzedEyLxhnmVf3ggaW7rU= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5110.namprd11.prod.outlook.com (2603:10b6:510:3f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Fri, 8 Oct 2021 17:01:23 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4587.022; Fri, 8 Oct 2021 17:01:23 +0000 Message-ID: <58871e2c-1caf-9d8e-ba5d-6818d28e0f5b@intel.com> Date: Fri, 8 Oct 2021 18:01:16 +0100 Content-Language: en-US To: Alvin Zhang , , CC: , References: <20210923014951.12696-1-alvinx.zhang@intel.com> <20210923080129.5068-1-alvinx.zhang@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20210923080129.5068-1-alvinx.zhang@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR07CA0197.eurprd07.prod.outlook.com (2603:10a6:6:42::27) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR07CA0197.eurprd07.prod.outlook.com (2603:10a6:6:42::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.4 via Frontend Transport; Fri, 8 Oct 2021 17:01:21 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 747ad0b2-a694-4f57-8c59-08d98a7d41b7 X-MS-TrafficTypeDiagnostic: PH0PR11MB5110: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 50hPBGk3S1XsB77JeqJe+YVjGQZ/u/Wqr09m033qyF+Wmaksdaa+98kMjN7cwLxvkGHTM8K8f88o2nlQbsTPfv4O01jByL+jpfpdNfgWxUPmOsC+LRTrOuNSSgpiXGTmYFYk9SmWlyVFdWCrEENAdqtfu5HHu26lZDSx5TYiBPm1wMgT94Mcn7YktXuqm8GaHtAQxZrxXd0likcah1aAhxy9tPW5jLA1HfjnSBvrx8mkqNDYnfn1bG1jE1x7uIV2ReOLm39/C6d14ZzzkS0BCTGlNEB4nu+D/QIEQ/yr0HtFQtBw7AKu+kaKYeAqr7wDz9DUxwc0d0rXQmZqFuTZoek7oFXIpwBQxSdtle4JG+V22zBrt4ib3h0nAS8LaqSU6y4+pbEtZEZUEHkzC9umkgVFe+7/MenkpRoGKU6JUjTgYzSaRk28xkvt0WDjc7lzZeyVO1f0+TTiF25c0NngrhlN9joYDcMjg/rnakgwqAcDPsY515iXaXKEoDWOuJctKJW0b15m7XoXaaCqous67pysVSi9NUayPBXRL/cLvaAKI9x8uX9D/+joPJTa6y4lzK8nYaWeb6SpViEuPOd/y8sVmATH8kr1lmvi39NJPbN7kuxFrfqzgnNbuXGmOBCbOz0HFIFJqbLoMa6pC+3OAIqQnlTZJ9CAtTSg87oMjVqv0XaIh4bW/TjOS85hMp3dmwwTbGwjfO5Yk6dQmobxXw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(53546011)(186003)(36756003)(83380400001)(26005)(38100700002)(15650500001)(31686004)(2616005)(450100002)(44832011)(956004)(4326008)(6666004)(31696002)(8676002)(8936002)(508600001)(66556008)(6486002)(5660300002)(66946007)(6636002)(66476007)(316002)(86362001)(16576012)(2906002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUNqb3dqTmlIVGtXWGJKR3A3RnNCWG5DZ2htVW9wSVZ5bE5ZcDQ5NkdoemFK?= =?utf-8?B?M3h5bCtuUGNxTS9UTS9CVDFySkVIaEN3N3VvY1ZxSzRMVys2UWF6NzYzSjlJ?= =?utf-8?B?NDkzNXhtOFloK1VtSnJPMWF2Vk1XOGVBWU1nWmtWcUZtWExodFVhbGwweTdz?= =?utf-8?B?RDdIRGZpdkhnakU1WXRBRVdVZHNBa0NoaWRIK2UzdFE4cEpORTM2QmQxSTJw?= =?utf-8?B?STZnbk5aMGpTNHBsajFReEluZTlEVnk2c3NlY01WVFVsR0xjTm5WWk9VRFRB?= =?utf-8?B?aklkbjZxNVgxc013WUpkVGVqZStpakZhbi9hcUFWYjQ5VnFoTEdBQzRnSGQ4?= =?utf-8?B?d3F3UTR4K0hSRFV4K0xYcE1mQi9jOXFWZ1oxYWpKK0lVZTlMY2NSeitubHY0?= =?utf-8?B?bWRvbjhNTFA3cUFWZ3h3RXBGckNxRHV1L1FCdm1vU0RadTJUcjFwUDdsankr?= =?utf-8?B?ZUpkZkgxeDRJZXhOSjhQVkE2cUV2WEJOVThHVjBFZWNrZG0yM09GakpaQmFE?= =?utf-8?B?RW9iTlhZM1BUeEtxdE9kM2hMVVRMWmwzdUNSZTlDUWZpT1BJbno4eFVCYkJz?= =?utf-8?B?Z0QxTGgvc0d4YXRzZlU0U1NuZWtPQ3FsTHp0REJUMXpjYkdNbnltcUw4TGJV?= =?utf-8?B?NXQza01FT0VoUElQRVlSbCtpcWUxRkVoUHFzbisvcmVaT0pqdTdsaGNLZDQv?= =?utf-8?B?ZDU1RFV1NVhIQlNPWG5ReUJWVEtHUVVlcnA3VW1LSis1eEdIdGl2RkhjTFRl?= =?utf-8?B?aXJPZkNUVXNLUlltTUU2K00xYm1FdkNjT1lzdE5aK2swOERpTHdYZ2NQaGJp?= =?utf-8?B?a20wakVSM2tGZkVKcS9XUWttUUQrUzZoeWwvYkZlR0lzbCtLMGZsbXRLbXJk?= =?utf-8?B?WE91M2IyQjZEcjFXVU5BM1lpNVZjbERXc242b1JwU2ZBaE9WQVI5aWlzQVhU?= =?utf-8?B?RzBUL1IzeG0vNGRxUjc0SE1DSWN1bSs3RnlQc0l4akkwME9OYVJERU00WEpX?= =?utf-8?B?c2JicWRxQVNXT1FZWnZrclV2MzJUbW1VS2JoRzB4dUlXTDNtaWN6cUpYVDFS?= =?utf-8?B?VmUzMWJSczBWNjIvblUwUzVlZzU1d0Jnb3F2NjZ2QzFrYitnTGlFUXUyVFpI?= =?utf-8?B?bWFFUVEvcXNMdDBXWmg5QTJXS3V6YTFsaXBDeWFyWFBhOU42SlI2SUFub3d3?= =?utf-8?B?bWVwYkcxMCticnZINjVmRFFFRGZkaWpZZkVHQkt5T0c4RyszWHZLVElQQUU3?= =?utf-8?B?TU16UmtFTDdwWDA2QnY1VTRIdGRJK3FCdG5mQlNzdFhxSkRkVVhzUk4yRmcw?= =?utf-8?B?Y2dDRFhkVkdnWEpsMkxQeis5bXdBWE5rSXU4aXJjU2gzb3dJRDcxZXBOZFlQ?= =?utf-8?B?M0N2ZlVBZUhoT2ZZaUc3bUo5Q29rYzNiZXhocElzVkFOd2x6a3BBZ2hCd01s?= =?utf-8?B?blZXaUdLOXI5ODR2SndUNWVscGJoc0NMSWhGS0h3OUovV3cvbmxNT2ZtU3JG?= =?utf-8?B?LzRibHNlbHVLUjRrSGNQSDlaNG9sSWsyWU55ZUJxSDludzR3ZlRQdmxWTDhr?= =?utf-8?B?VGJUUFhRanlHdk1aSXVidkVJNWx0WXFvazlBMzRUQWF2L2VGWThUK3Y0b2RH?= =?utf-8?B?M1FJdmttZUx3L3h1RVdZME5YL0VORWlqUG5oV1RtMm9udXRiRWVKY2hJUmRw?= =?utf-8?B?cFNoNXFhQy9zZEVlaUh5Z3RNaXZLSzUwVFVLNTRYNjU2VS9JWHRUYVRjdlBB?= =?utf-8?Q?/CCM8gbZ+CL31ygLXug7MPKuX++SDBnJhUVOQ7m?= X-MS-Exchange-CrossTenant-Network-Message-Id: 747ad0b2-a694-4f57-8c59-08d98a7d41b7 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 17:01:23.1313 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BhoHrQZbBf6C9szfQrGldnIN2AA+0gw2VOCEtnoWYBA8XJ/YaQAAoHy/6RJhHs5/ObTEyw8GF90lcK16LLulgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5110 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH v6 1/2] app/testpmd: update forward engine beginning X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 9/23/2021 9:01 AM, Alvin Zhang wrote: > For each forward engine, there may be some special conditions > must be met before the forwarding runs. > > Adding checks for these conditions in configuring is not suitable, > because one condition may rely on multiple configurations, and the > conditions required by each forward engine is not general. > > The best solution is each forward engine has a callback to check > whether these conditions are met, and then testpmd can call the > callback to determine whether the forwarding can be started. > > There was a void callback 'port_fwd_begin' in forward engine, > it did some initialization for forwarding, this patch updates its > return value then we can add some checks in it to confirm whether > the forwarding can be started. In addition, this patch calls the > callback before the forwarding stats is reset and then launches the > forwarding engine. > > Bugzilla ID: 797 > Cc: stable@dpdk.org > > Signed-off-by: Alvin Zhang > Acked-by: Xiaoyun Li Series applied to dpdk-next-net/main, thanks. Updated log messages slightly while merging.