From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4594468C4 for ; Tue, 10 Jun 2025 11:23:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC10C42E76; Tue, 10 Jun 2025 11:23:02 +0200 (CEST) Received: from smtpbgsg2.qq.com (smtpbgsg2.qq.com [54.254.200.128]) by mails.dpdk.org (Postfix) with ESMTP id E797342E69 for ; Tue, 10 Jun 2025 11:23:00 +0200 (CEST) X-QQ-mid: esmtpgz12t1749547379td20c298c X-QQ-Originating-IP: lapQDHlZTrS7C6aRVg0CYj2/Hg7rAemo5la5ulZV59k= Received: from w-MS-7E16.trustnetic.com ( [36.20.60.58]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 10 Jun 2025 17:22:58 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 12535594512890313716 EX-QQ-RecipientCnt: 3 From: Jiawen Wu To: mengyuanlou@net-swift.com Cc: Jiawen Wu , stable@dpdk.org Subject: [PATCH 08/12] net/txgbe: fix incorrect device statistics Date: Tue, 10 Jun 2025 17:22:33 +0800 Message-ID: <58C96AB8D96FAF27+20250610092237.232224-9-jiawenwu@trustnetic.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250610092237.232224-1-jiawenwu@trustnetic.com> References: <20250610092237.232224-1-jiawenwu@trustnetic.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: esmtpgz:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz8a-1 X-QQ-XMAILINFO: OaUS/vBL36PcYqkjQNn7cyjA7Wr5aWFL3g8AR9Xu5CCwLAG5UWq+gGG2 TKlmqb/bKPpzQajYbjNIsso6CrfgBrZwW7TgsSzf17eqQud14j2UPtpdECSUlU9kTjGccgB sG/B8xW9XcH/sYQ2UNQ1GWC8bvNryPPpGdhNk9w09/aoZ9dHzMybfe/gVEwVUtljZOoAMLl ksmiYum55ytvS5MHUC5z9M4ObTcANeJATAWYnE85HJNzEHxZ6CwtScWkE3hAemlvflJXs/i njbE7V1EHC2/dXQMNJVd+HmuBE79bvhCK1KSSlW9KdfJOd61LbGC6Hpu+ixdC80iHiApBZT bbrgY/fWhRFzvu1PBHB+8Uun/Oo8QOLKzsQAf50VlIBaSvyHQvcuqihJiVduckEM0F2d3zk jIGeEYgUxs3EfaIMYLl3gtgHlw41Hp8Nt9Rf+2WReHJCVuPRyOI6FElQte6+0WM8tvwZiVj e3kikpClueUxmLzK0wNeRI1RK9Jgwy57E4cIP5nkk/Sdz+ULR4X2RIvVpr5IWWzcghziQH8 nX/MnUYcVNuqicziIeVShzy/Ux2HPYoEUopj8VWzdMnv9MJHjx99cgVPMXDsxzF4RXdfmKM Wocnc8kb57ic0jG4GNNhAJXrVsp5/A1tNn7KHiD/jlQbUUohRGYRMwEcY0yrZgwQj2rOljX XZaZkqzTmy/cVlk0/cuuvpLt+3Xxs2n1HYtXqjMzSz5BDMJ8Wr8UzAymclpKmkh2GCvmb1i smUCFjC9IphmLF66LKCaO+uGEL5JXnoWOyz8K8lkx364FPse/7eXEqM9NjTvAgS+Kao56GR EC2cMRWHhXTTxH6fCQOVwokTqainlGSmKbHnr/p0tJONAmsUVsBuCzhtPV8Qv3m7JR84X4s joSxOMpRokgwInreY5d4veOi43WcTU8MLkAV276j/wFNGxONirLzwRQ4bTCWi0pxqxcMSku rOjnlORdiPsrGQf5jQKmTtvUiiE7BQIwGlq61emQyJzil0hzVHECucA3RekE1cd7LDO1z84 b9d+V6S6adrvjR3gVS6CSECRjC+xmIEBUoOr3KAnO1klLpkNmvhm7Dk8+yWw2g4iKKUbDe3 qSjgO7XrYUc3vvgpCe0mgoAmcdT8p4X+g== X-QQ-XMRINFO: OD9hHCdaPRBwq3WW+NvGbIU= X-QQ-RECHKSPAM: 0 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org The extend statistic "rx_undersize_errors" is incorrectly read as the counter of frames received with a length error, which names "rx_length_error". And "rx_undersize_errors" is the counter of shorter-than-64B frames received without any errors. In addition, "tx_broadcast_packets" should use rd64() to get the full count on the low and high registers. Fixes: c9bb590d4295 ("net/txgbe: support device statistics") Cc: stable@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index b68a0557be..580579094b 100644 --- a/drivers/net/txgbe/txgbe_ethdev.c +++ b/drivers/net/txgbe/txgbe_ethdev.c @@ -2250,7 +2250,7 @@ txgbe_read_stats_registers(struct txgbe_hw *hw, hw_stats->rx_total_bytes += rd64(hw, TXGBE_MACRXGBOCTL); hw_stats->rx_broadcast_packets += rd64(hw, TXGBE_MACRXOCTL); - hw_stats->tx_broadcast_packets += rd32(hw, TXGBE_MACTXOCTL); + hw_stats->tx_broadcast_packets += rd64(hw, TXGBE_MACTXOCTL); hw_stats->rx_size_64_packets += rd64(hw, TXGBE_MACRX1TO64L); hw_stats->rx_size_65_to_127_packets += rd64(hw, TXGBE_MACRX65TO127L); @@ -2269,7 +2269,8 @@ txgbe_read_stats_registers(struct txgbe_hw *hw, hw_stats->tx_size_1024_to_max_packets += rd64(hw, TXGBE_MACTX1024TOMAXL); - hw_stats->rx_undersize_errors += rd64(hw, TXGBE_MACRXERRLENL); + hw_stats->rx_length_errors += rd64(hw, TXGBE_MACRXERRLENL); + hw_stats->rx_undersize_errors += rd32(hw, TXGBE_MACRXUNDERSIZE); hw_stats->rx_oversize_cnt += rd32(hw, TXGBE_MACRXOVERSIZE); hw_stats->rx_jabber_errors += rd32(hw, TXGBE_MACRXJABBER); -- 2.48.1