Re: [PATCH 21.11] net/nfp: fix MTU configuration order

[Kevin Traynor <ktraynor@redhat.com>]

On 22/03/2023 15:48, Niklas Söderlund wrote:
> From: Peng Zhang <peng.zhang@corigine.com>
> 
> [ upstream commit 4352a3bcee3a4cc20c8accb71d683d5add3c6f80 ]
> 
> If rte_eth_dev_set_mtu() is called before rte_eth_rx_queue_setup() the
> NFP driver setup fails. This is because the default values evaluated
> when setting the MTU are initialized in the rte_eth_rx_queue_setup()
> code path. Fix this by instead initializing the MTU default values in
> the device initialization, in nfp_net_init() and the check also is
> conducted in nfp_net_start(), so it doesn't influence the result.
> 
> This was found by using DPDK with OVS.
> 
> Fixes: dbad6f64f921 ("net/nfp: fix internal buffer size and MTU check")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Peng Zhang <peng.zhang@corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
> ---
>   drivers/net/nfp/nfp_common.c    | 4 ++--
>   drivers/net/nfp/nfp_common.h    | 1 +
>   drivers/net/nfp/nfp_ethdev.c    | 1 +
>   drivers/net/nfp/nfp_ethdev_vf.c | 1 +
>   4 files changed, 5 insertions(+), 2 deletions(-)
> 

Thanks Niklas. I have added to the queue and will push to the branch 
with the next batch tomorrow.

Kevin.