patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: "Niklas Söderlund" <niklas.soderlund@corigine.com>, stable@dpdk.org
Cc: oss-drivers@corigine.com, Peng Zhang <peng.zhang@corigine.com>,
	Chaoyong He <chaoyong.he@corigine.com>
Subject: Re: [PATCH 21.11] net/nfp: fix MTU configuration order
Date: Thu, 23 Mar 2023 15:18:23 +0000	[thread overview]
Message-ID: <58f0482e-b02e-e726-6599-6d217cc8dc1d@redhat.com> (raw)
In-Reply-To: <20230322154824.948054-1-niklas.soderlund@corigine.com>

On 22/03/2023 15:48, Niklas Söderlund wrote:
> From: Peng Zhang <peng.zhang@corigine.com>
> 
> [ upstream commit 4352a3bcee3a4cc20c8accb71d683d5add3c6f80 ]
> 
> If rte_eth_dev_set_mtu() is called before rte_eth_rx_queue_setup() the
> NFP driver setup fails. This is because the default values evaluated
> when setting the MTU are initialized in the rte_eth_rx_queue_setup()
> code path. Fix this by instead initializing the MTU default values in
> the device initialization, in nfp_net_init() and the check also is
> conducted in nfp_net_start(), so it doesn't influence the result.
> 
> This was found by using DPDK with OVS.
> 
> Fixes: dbad6f64f921 ("net/nfp: fix internal buffer size and MTU check")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Peng Zhang <peng.zhang@corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
> ---
>   drivers/net/nfp/nfp_common.c    | 4 ++--
>   drivers/net/nfp/nfp_common.h    | 1 +
>   drivers/net/nfp/nfp_ethdev.c    | 1 +
>   drivers/net/nfp/nfp_ethdev_vf.c | 1 +
>   4 files changed, 5 insertions(+), 2 deletions(-)
> 

Thanks Niklas. I have added to the queue and will push to the branch 
with the next batch tomorrow.

Kevin.


  reply	other threads:[~2023-03-23 15:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-22 15:48 Niklas Söderlund
2023-03-23 15:18 ` Kevin Traynor [this message]
2023-03-30  8:54 ` Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58f0482e-b02e-e726-6599-6d217cc8dc1d@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=chaoyong.he@corigine.com \
    --cc=niklas.soderlund@corigine.com \
    --cc=oss-drivers@corigine.com \
    --cc=peng.zhang@corigine.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).