From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 884D542826 for ; Thu, 23 Mar 2023 16:21:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 836E940689; Thu, 23 Mar 2023 16:21:11 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 669E44021E for ; Thu, 23 Mar 2023 16:21:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679584869; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q2P68r12Jp8rR7b6RK7Axmdn9fnk5d0O563Ce+E0gX0=; b=R64vbcVP2kwUdw5qcr7ZbS+YhJNMCBXT/lcyoBJhPprPJQ1xrUKPDLTQBSjTewJpmGQ5gp IHdHfYgifM7KaY22kP3LZUMLGZQaecY7m6SfRsD5Rcv3RTh88aQ0jOSpjPcKMVHPNh1Ju9 Soy65ZNH58LBWmxwVFGYOV0G5Y1cSVs= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-674-nPuWuMivMUm7WLuvxc825A-1; Thu, 23 Mar 2023 11:21:08 -0400 X-MC-Unique: nPuWuMivMUm7WLuvxc825A-1 Received: by mail-wm1-f70.google.com with SMTP id o7-20020a05600c4fc700b003edf85f6bb1so1181211wmq.3 for ; Thu, 23 Mar 2023 08:21:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679584865; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=q2P68r12Jp8rR7b6RK7Axmdn9fnk5d0O563Ce+E0gX0=; b=tZAd6v3YNuhkrguUwwDslasXX3grjEeCGc4qVNP+/tVc06NT7ii+XRT08T668St3zN jRT2fhmx1pFFvtP51IdPvr36O01k7dpltNnGcZuc19sApXM5vfuHn7h3Tad+cz6U2Lge E2JIwJvObgAzO02+VuyG5f0hddEUGVwLhX5OA5Y79iDalGFRwbbz2/W/mW5srMLJ0M2D wnl6y22oW1j6o1+ETsFqMLJ9CkY9BTmSLdchIwXa31CCi38Sd39OpGZ3l4JmX/AANF6x SLhpydJ70hBk9PNlchD04g+MorX46o8JVetDgWkqmHz1WS21DdQ1XVGkUj70voX2p6gJ izzg== X-Gm-Message-State: AAQBX9d5qQrg8Tl1lhcpwdwGFIVpfDAo44mxLDeW6DGz2jCdcg+juDuG ABfR0USDldrR4tCqkSp5aaGyBqveuXza0JhGTWCrijEfm04to0NNgnq+sxx58Iupy3VAFqvltb/ qsd7gkQIaI+sZUfP4Fg== X-Received: by 2002:a05:6000:120c:b0:2d8:5df8:4566 with SMTP id e12-20020a056000120c00b002d85df84566mr3023949wrx.8.1679584865108; Thu, 23 Mar 2023 08:21:05 -0700 (PDT) X-Google-Smtp-Source: AKy350YHk5MG4ZWieoX/FDbj64ca9UVVU6qyFzpeThfoMrvRzi/NbuqELCc08RwKo8wK3gxYOsbXXQ== X-Received: by 2002:a05:6000:120c:b0:2d8:5df8:4566 with SMTP id e12-20020a056000120c00b002d85df84566mr3023935wrx.8.1679584864819; Thu, 23 Mar 2023 08:21:04 -0700 (PDT) Received: from [192.168.0.36] ([78.19.103.115]) by smtp.gmail.com with ESMTPSA id a8-20020a056000100800b002d8566128e5sm7950682wrx.25.2023.03.23.08.18.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Mar 2023 08:19:49 -0700 (PDT) Message-ID: <58f0482e-b02e-e726-6599-6d217cc8dc1d@redhat.com> Date: Thu, 23 Mar 2023 15:18:23 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 To: =?UTF-8?Q?Niklas_S=c3=b6derlund?= , stable@dpdk.org Cc: oss-drivers@corigine.com, Peng Zhang , Chaoyong He References: <20230322154824.948054-1-niklas.soderlund@corigine.com> From: Kevin Traynor Subject: Re: [PATCH 21.11] net/nfp: fix MTU configuration order In-Reply-To: <20230322154824.948054-1-niklas.soderlund@corigine.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 22/03/2023 15:48, Niklas Söderlund wrote: > From: Peng Zhang > > [ upstream commit 4352a3bcee3a4cc20c8accb71d683d5add3c6f80 ] > > If rte_eth_dev_set_mtu() is called before rte_eth_rx_queue_setup() the > NFP driver setup fails. This is because the default values evaluated > when setting the MTU are initialized in the rte_eth_rx_queue_setup() > code path. Fix this by instead initializing the MTU default values in > the device initialization, in nfp_net_init() and the check also is > conducted in nfp_net_start(), so it doesn't influence the result. > > This was found by using DPDK with OVS. > > Fixes: dbad6f64f921 ("net/nfp: fix internal buffer size and MTU check") > Cc: stable@dpdk.org > > Signed-off-by: Peng Zhang > Reviewed-by: Chaoyong He > Reviewed-by: Niklas Söderlund > --- > drivers/net/nfp/nfp_common.c | 4 ++-- > drivers/net/nfp/nfp_common.h | 1 + > drivers/net/nfp/nfp_ethdev.c | 1 + > drivers/net/nfp/nfp_ethdev_vf.c | 1 + > 4 files changed, 5 insertions(+), 2 deletions(-) > Thanks Niklas. I have added to the queue and will push to the branch with the next batch tomorrow. Kevin.