From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2026A43E52 for ; Fri, 12 Apr 2024 13:27:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B0504068E; Fri, 12 Apr 2024 13:27:30 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2043.outbound.protection.outlook.com [40.107.220.43]) by mails.dpdk.org (Postfix) with ESMTP id 441EC402A2; Fri, 12 Apr 2024 13:27:27 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a8QtJZe1a+Ytphso9SJlQ+SoN/fjL2k8iskXFeGwtXYu9BpJDD7R0AG5LZ+5BqdvbKzyw3hxVHzFNsmj/CG2ZOyxvx9EmX9Sxx0YQl9ixhb3xfqsnrVD+OJKUtr9U8mGY5AEVxtIuGe2DMH9ABAkKAeuoa38gq7XnvAYKhf5ecnQEsAZOUGUluFYbRW9nGCdmCcgavUhAQN790vi8A/BmfcMdeXTPGy+Q2BpzoYF3pT+M0F98aLcTEqbEm+paK5SuFN74IWPKZECbcgwazDbsV3+mp6zbiiZbif8xvaWvvphvyozEEOWYKQtFoZrA2VG05+bBSNq16VY/1UdCjBokg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UxFqM7/QcytTsHtupN6WXGKm6EOUdfzIjZTz3+6sBrc=; b=RjXy5VNYm8CKITlbQR5jCf//caAuycMSiTKJ3msORlEjlk7/zXav9+u2Bi2YMG8MlAoym8s+VZzsIvfSqvowj88lFoRYKuHHhWRykaA+/MV1PcZjpmgI8eOllbCdcItM3YwGg/UbXBhKYk9WzqiYwcyOLEZ8HpplqGGzXPs0VlFBylXXV5hvgsDDAAW6RTJSafJMeVX24vp8HcckwUejJCnFtIirNyG7vKZJrA82NKR6S1AGLdldqAQRHl8+WHAY8U5L6SlgUD5d17ATLIfR2zo/1m8BjaVsotKvuo+b3rMtQ7iGaexwKu4dq3Dy8+aVp05CgW5AgLknSLE/vfAfaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UxFqM7/QcytTsHtupN6WXGKm6EOUdfzIjZTz3+6sBrc=; b=SJ3QBv+rvdwWWsn0dmdGFLJ32xiC3ScGxly5SYdf4bv4sJBEDs6wMseUFmq+MUyQ0sJt0cGqtGnmkMeuUTbvRcnZolAYBkf83cjxnjAolxeeKO1+ejTefProK+/+74iz8qTXst9xTDtn01X1hrMkCe+e5JqJBTisehr+r4UUv6c= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM3PR12MB9328.namprd12.prod.outlook.com (2603:10b6:0:44::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Fri, 12 Apr 2024 11:27:24 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3%7]) with mapi id 15.20.7409.053; Fri, 12 Apr 2024 11:27:24 +0000 Message-ID: <58f959c0-746d-4fe0-809d-a75efdd93edb@amd.com> Date: Fri, 12 Apr 2024 12:27:20 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] net/failsafe: link_update request crashing at boot To: Stephen Hemminger , Vipul Ashri Cc: dev@dpdk.org, stable@dpdk.org, =?UTF-8?Q?Ga=C3=ABtan_Rivet?= , Thomas Monjalon , "techboard@dpdk.org" References: <20211021115139.2634-1-vipul.ashri@oracle.com> <20211021214215.1633-1-vipul.ashri@oracle.com> <87c84612-4116-4fe7-a711-f5f364513c3d@www.fastmail.com> <952c9880-9ad9-bfa6-e39a-271a06226640@oracle.com> <20231017094345.3f50eda5@hermes.local> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20231017094345.3f50eda5@hermes.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0231.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:b::27) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM3PR12MB9328:EE_ X-MS-Office365-Filtering-Correlation-Id: c6244960-5185-4eb4-959e-08dc5ae386b5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mNgtojLFOe4ckOU11212MU65HdW8iqQ7SMXbPWsuT0sMy7a2Ed1Xu/aWATJGyIRHtbl6Zw958jHFzLWZDqU6maG7MbIS3x4EQ6kEkKJLzLfU0sgSvN2XzxvAQe48TuIGLMDUKrH8rwrtjeQXihH1TEYOsfatEN7MBApPgPqGMxP26WyErAC33fjQnDR/ZjGO8mLfL9FN1yMcVAWje2OqthpXNVx/0QCpa3q1H7B+rTMKeruq8H+d/OpWZWwX13ZRWTZeYeyZ7dyWvmUVbBoSOBNz/jKi4/Id8lwn8jmTste8BEdqhVnbnkc+dZD6UFjCez0dQbCvne14CV9BqA7Xpe8lqCiKCV02MxPeBa8iQeFaKeXylcoM5QSj58fGBR6Y1KutlPLLUfYrBSI2fihzTM7aILAr0LavdSITpPlQX+4Z0HDjiRD3riu/igvp2kQ9A8VdogUFJ7Q4xN6LbcbTE4Xci9PfKvq7XT36GCSqewbreqHFijhW9MeYhGVn9ZglQ9EI9Dq2Endrg5NAN3IaTQq/29ItD/sUMFt15IGOp3YCYXet/8dUngaHLbSiFl70UbU38cAkOb10xyTTSh1XL+6kJKOo4UTKpZqyff8yFQex9uy4QdcwzWGbfSkX7yHA60Q8rYJDw5e1vDvlrk4kYS2cVPaLSEpp+HT6lmKOJDQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015)(366007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WVA2Y3NmakNFVCtzbHVIbDBMUTlIT1FZZVRiQUxDQ0dta1RZS0lJUlAzQXlW?= =?utf-8?B?YVFRNGxqUHFETEdpenRQQkRqMEhReFJvdk9zVStXenZPUGExbytSWTd6YnRM?= =?utf-8?B?TlJKdDdUemFVTlhRemdhajQ0ZFk5UmRwZVNrZzZRNFNjVksrMlNkM01pa1pv?= =?utf-8?B?WmRTc2pINUovSkhHMXJhWEhrc3U5TitibEl2MmN6c3JqcHIrSkdFRUlRNkFn?= =?utf-8?B?Z2hjTGdrZmhDOVVzekxFQXN1NVFiSkxZRmt2aGRpd254ZTMvUkFrdnhsYUpC?= =?utf-8?B?anFSK3VheXNCUlNZM1pTRlhiZ3owY2lFS1VlUFAvbjA2emRybzBlalgrYkVh?= =?utf-8?B?cDBrRXluZXhRMXVsSDlkVE0yYjRTejFCQ0V3c3RZSFFKMVl2QlFLc2h6TWtt?= =?utf-8?B?ODVmQ2RZaXhRMnVabzVnZGtDNUpqWTZhK1hvSWpFSkxCb1BVM2VtWDBPa0RJ?= =?utf-8?B?OVlpOW51TkY5YlhlVHBIeW9rakVJbTNGdnpDQnJXZXk0anVlVlgvUzNuanEw?= =?utf-8?B?K0R3WC8vTUM5R3lFclhINFQ2UC9pZjJYZCtaTmovL2NsOCtwVWNWOWNwOG9U?= =?utf-8?B?MmRNSDhlU2M1U2U1LzkrNURKOTFBUXZRVTNnNC9rdUZuSGJwdWtGOWsyUjdw?= =?utf-8?B?RG1TYTEyc1RRbmYzUFhSMUwzM3N3NkxKalJwSkdRbGplTkhTQlJKUUdHNncy?= =?utf-8?B?VG5xc3d5MExhTnNmM08xa01jckU1UFBBQ1RobFZoR0toOWpRcERobkV4Zytr?= =?utf-8?B?NjNHakUrbHpMd2QvSUdQdHpUVlR5REJIaTlmcGpoUmJKT2UvUmU5ZXR2c3Zk?= =?utf-8?B?a2VDa3R6aFVRbkZESFEzNU5kU3NFQTB4RGtOeS85ZXAvL2M3YjNMVlhBYXV5?= =?utf-8?B?ejhkN01qeXZJMmdIcDRHL3JOK3pGUHZQaXl3M3I3bFQzRnNxTFovZjJFREUr?= =?utf-8?B?ZGJvcGxPVGFtamg5OWZ0VFg1UFllcVhUTEEwNk9TdXk5TEVueTJZeU5oZnhH?= =?utf-8?B?SWhRTStxOUJoTHhIZEZXUlc0d05GcHdCVjdxbVkzbEdZMUUraGMwcllQa2Nk?= =?utf-8?B?Q3dPNFVhVkVHTlhxTjdjajlBQUNRZzJqOFViRzhQRVZQRFJualRFQmdyeVYy?= =?utf-8?B?eVM1Q3F1QVV4emVkRitwMU9iQXh3ajlCWW8yTW9mdGttaWlxNFVXMDB0WU1D?= =?utf-8?B?VWNOcEphNGtyN2QrdUJhRXlrbTYxaWFWU2w2ejRWdzNtR1lwR1B5VituQlMr?= =?utf-8?B?RGI1Ti9sbCs4WTZMekJoaGtqQWRWelFOU0JYR0QvR3dwR0ZEZWxVTyttLzNI?= =?utf-8?B?dFNWNUY1NmRRZWdFTnpGZmowN24xcnEwL3pUQTI5TFh1enpEeXBqY3MrN21F?= =?utf-8?B?OGxCOVRuVDRXNUN4bG1ZNyt3UFNHL2JXK2lzNjJiMHZhWVBvU1M4clV3dStt?= =?utf-8?B?ek5BclJhWHVET1VZTTdoRng2Tk9OWTJFdDVEY0U1MjA5NmpYQjd5ZHBtZDRJ?= =?utf-8?B?Z2dKSnh4ZUVRV0QrdlE4cWE0RXdmR1I3U2t5VDFRUGtDdlhXVXVGVXNUN3Bp?= =?utf-8?B?YnQxUzVNYjNXNzhpVUJsdDRPb1BiRFovR3FBUG5wUjY5OXUvaHFhdmk4c1gv?= =?utf-8?B?d3U1NDY1UHRJQ1B3UWpkaW5SN3VJQ2hwOEsrYWUreUluaVNLWXJWdG9YbDNa?= =?utf-8?B?bkRJZHAvQ3BEUkRsa3B5c1pvYTlwRm9aTHAxUnM5UmtmUitLcjE2dmMxRmp6?= =?utf-8?B?R0c3S0NmemVpTnpMMVgwZHVLUkxwQkhQRW5Ebnl4UzEyVjhsbVRQSkRmTVpN?= =?utf-8?B?MmQ2WGpZSjBEQTVjMkNZbWNMKzZRRUtOVnlObFZJS1o1YktuSjJ6T2xXbkYw?= =?utf-8?B?aXRxMTFqK2pzcHY3RnVRTFgyY1A1dmdURlRSK1ExU3NsWFY2eHNUMlhsUU14?= =?utf-8?B?L1N3UlAxdnJSTTN6WEhmTmY3VlRwa3MvU0FzTFFuelVGYmNiRDZqZHFtWlVa?= =?utf-8?B?WTZCVTcwRVJ1bFRaSGRPZG5wazYyNm1IT3QzUGR5MUZvNUh0b01kNFg5TTFG?= =?utf-8?B?ZkEyb1o1UHQ3NzdiMjFHd3cvM0xiZzcyS0llMUUvYUptL1BCVjhZMU9JT1ZW?= =?utf-8?Q?dvesuzd64I266uWc//3VUBgxd?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6244960-5185-4eb4-959e-08dc5ae386b5 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 11:27:24.6205 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +8XnEB6zWq4nYn+Kw+sqpca5JltB2PYnb0idFlut6mtl8QtQKVwNujRDMeQyVV5X X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR12MB9328 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 10/17/2023 5:43 PM, Stephen Hemminger wrote: > On Tue, 15 Feb 2022 22:16:28 +0530 > Vipul Ashri wrote: > >> On 2/14/2022 10:24 PM, Stephen Hemminger wrote: >>> On Mon, 14 Feb 2022 13:09:19 +0000 >>> Vipul Ashri wrote: >>> >>>> PORT 0 supports 16 rx queues and 16 tx queues (driver_name = net_failsafe, driver_type = 16) >>>> >>>> PORT 0 is polling for link-change, interrupts disabled >>>> >>>> [DPDK] tap_flow_create(): Kernel refused TC filter rule creation (17): File exists >>> Looks like secondary process support doesn't work with the flow rules logic. >>> Maybe after that you are into error paths that may not recover correctly?? >> Thanks! Stephen for looking at my analysis, >> >> yes some hotplug synchronization issue between eal_intr_thread and primary >> thread, but we are able to recover with this patch. >> >> Reason is this fail-safe flow is inside our custom added boot-time >> polling to >> update DPDK stats and calling ifindex ioctl to get interface data. >> Ideally we >> should not start polling so early. but moreover calling ifindex ioctl is >> generic >> functionality and should not break failsafe. We added this patch and >> gracefully >> prevented the so many multiple crashes. >> >> Setup details : >> Azure testbed with Accelerated Networking(SRIOV) enabled, failsafe using >> tap + >> mellanox driver. > > I don't work for Azure anymore, so can't really test this. > A short explanation why this patch is stalled. > > It seems like this patch is trying to avoid a crash when an earlier problem > occurred, it is ok to do that but the original problem is still there > and the testing it is impossible without having modified application. > For the normal user, this just adds more always true checks in the > configuration path. Ok, but it does add clutter. > > Since failsafe should be deprecated fixing this seems less relevant > as well. > As we are at the beginning of a new release, it is cleanup time. This patch is originally from 2021, firstly sorry for not able to conclude it timely. @Vipul, is this patch still valid? Are you still using failsafe actively? @Gaetan, what is the status of the failsafe driver? I am aware it was kind of temporary solution, is it still required or actively used? We are not getting much failsafe patches, but when we do it is sometimes taking time to have the review, should we seek for more help there, what do you think? @Vipul, @Geatan, instead of dragging this old patch, would you be OK if I update it as change requested, and you send a fresh version on top of latest code if it is still valid? Thanks, ferruh