From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75FABA0C4B for ; Sat, 14 Aug 2021 09:20:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6D2F040DDE; Sat, 14 Aug 2021 09:20:08 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2041.outbound.protection.outlook.com [40.107.94.41]) by mails.dpdk.org (Postfix) with ESMTP id 95A274013F for ; Sat, 14 Aug 2021 09:20:07 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T8eBrq0LaMe5fw+x7AO1LrtPiA8c2N68iYCNqRQvBq7+92q5qmuKIF2Iz71dGi6blIhKWdywvNmTyby0F+yjHXILzgADA/GSnGcnSnRs+PxZ/TuxdOMYc464BwIu3UvVVwqeqxKFibk81YMBY5FqLp5QpvfwMjfGYttMXcGO3zDpliv+Kmlt5HXE3YyXXmtmC8B7SgXjobOX2ZpO81FLFOXBIXrPm9e3bQ1M8KXIrthhucjxE0gVo+lDRkXxEMbxJlau1oGiAcdaYnu5MkUEiOrssaqJSq6FIxaQ8kmio8fVXoGJZi/0A8dgT9WnwXXfct1M0KYVxdOhXagWWydJYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=92q9a1fvSuISjp2MihL95kOogeYitVaHt/UeysG17II=; b=IsoS5BaZX/q0OkbY2aNjBXBq2rSYzBLcfDg+V3bOBTfOPFuAgc10qYr2GRsZpIm4JBG2g9w9fPowsSxRE5RGLN1CvujicK8vhYOcWeevjqmmL2cbow6ew4Edu9aTZ4PKKJHMjEmH3Py2sdEVp4K7MFJuB+yJvRPaEfWg3ZP75oSWR4Ml/OOlI6hpAjvHAFzBUWh7YxO9ylzbHn8aYZY/u9FqXsNipG863rKJGrNIHrBC8KNf4JLSaGEsnE0xm0eWU+T3N9fC951HFrCdVHKW7L22UkNnVDeIvoy+5IEGZSmwMpQeBxCOY75aAUawsZd7peM0jHwZfUwwj5wAHIGBcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=canonical.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=92q9a1fvSuISjp2MihL95kOogeYitVaHt/UeysG17II=; b=Lroa6Sbnzt30qZafTCtEVKh+LYVsH46ZQMSXy3zfu9XYpN41yJJlstd74KI/+yRtELL4aQw6L8fylmNcb2wU00+MXiLN8wrlfKXt8bK/1F25zcOo4Crq2nLyJS6ge5yZDIh3pzCchLwTRBJsLbZlVP8/z+ApOwzAlRUkOY3jOKr/nuIMTiGKl4AtspjG1ZK/JczU0PMkPAnW3MrNR11mpHYu93UsU3dBoYFAOKA9KIks+yYzsaJJ10m+LOa8Y5kKvEVj7H9p+h1X0rPBD6WG3T59BHURkOI01AOLXL9oS5mUdBMnwDse3TPMRLDRIY3lNNbvPRUDe7p++jAkhKg6PA== Received: from DM3PR12CA0098.namprd12.prod.outlook.com (2603:10b6:0:55::18) by BN8PR12MB3619.namprd12.prod.outlook.com (2603:10b6:408:46::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.17; Sat, 14 Aug 2021 07:20:04 +0000 Received: from DM6NAM11FT021.eop-nam11.prod.protection.outlook.com (2603:10b6:0:55:cafe::f5) by DM3PR12CA0098.outlook.office365.com (2603:10b6:0:55::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.13 via Frontend Transport; Sat, 14 Aug 2021 07:20:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; canonical.com; dkim=none (message not signed) header.d=none;canonical.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT021.mail.protection.outlook.com (10.13.173.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4415.16 via Frontend Transport; Sat, 14 Aug 2021 07:20:03 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 14 Aug 2021 07:20:01 +0000 From: Xiaoyu Min To: CC: , Matan Azrad Date: Sat, 14 Aug 2021 15:19:35 +0800 Message-ID: <591a1c75ff9a57e90f884abb13839b2bd62ad2b2.1628923046.git.jackmin@nvidia.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 13a68e69-1e27-4301-ac47-08d95ef3efaa X-MS-TrafficTypeDiagnostic: BN8PR12MB3619: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1051; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Dcutb3CS+cJ6DBmeYR/LUvHghVo2jNuHOIPw9tRQLGop2QPuEnTsSw+Ms+onWjYKL0EmcKmbbO9WkWkb2HlHjUFdplzJEcEdJh59u6i4GOkhyZduBbEPgqdwXO8WeSlEOl+4igtshm4FGw1SKK1+PpuOYurPIWXfQ26COmx+KDwa4Gh49r/x4AJ2d04Gff/GfJIcwvwgeWGb20I8RQ1ZrkqDusUXYRzSEBGZh7iMY0kZ376hVTh8bit2mXZMqQW85phZw9ZZYNzl2XMtVuMnV+/q7seT9jTLcXdgB5vYq71fvpkFR0SoHwLgOIpR+ohf2J64jy9CGr6aSfPd6cUgOdTPGnEa1BndAAN83lfKEH1hkNNbiml+Mw9J8PjwkM2n9b8gY6LG/1YaBhH9oTmh7odwmHcsGiPVWmlZhMaZ3ormw49u6+QSXnJsknKSIRfhQq50uBiJGMxZjsARbshsy4I0xFUpoJEI79di3Mp4DT7R6SyCT/Afgq7XqHI+/GJI1GYYLCXbAKnZ+UXhs9VmUywPoc1XgazXFzyUqjpLezsorV6N5rm8vQE39ba/SK8LOKDnWddYEJ35DZya01yYdP3Lnp5uzZOzgyAHDthZmOt7tu0cuqnjjaRMJ4ULiFfqZM26eW+UfuAIvel+tsrc5ln8La946qaJNBibwFNhOap03jcErmosTg0JekKJKqk9q+iyH9bgRsYEfk3fW2xYAcKjY925KpiRorIQ80P7phE= X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(396003)(136003)(346002)(376002)(39860400002)(46966006)(36840700001)(54906003)(336012)(82310400003)(26005)(6916009)(6286002)(83380400001)(5660300002)(316002)(426003)(2906002)(356005)(7696005)(7636003)(36756003)(107886003)(47076005)(2616005)(8676002)(4326008)(36860700001)(70206006)(86362001)(55016002)(16526019)(8936002)(70586007)(82740400003)(186003)(478600001)(6666004)(143363002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2021 07:20:03.8880 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 13a68e69-1e27-4301-ac47-08d95ef3efaa X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT021.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3619 Subject: [dpdk-stable] [PATCH 19.11 3/4] net/mlx5: limit inner RSS expansion for MPLS X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" [ upstream commit a26cc30fa0463fb6707b0caea1a288dc54c09b0f ] If user wants to do MPLS inner RSS and only provides pattern till MPLS without inner items [1], RSS expansion will expand flows into 13 sub-flows[2] which is too many and it impacts flow insert rate, stack usage becomes large as well. This expansion into 13 sub-flows seems not worthy of and it can be significantly reduced (i.e, 7 sub-flows [3]) by user providing at least one inner L2/L3 item [4]. [1]: pattern eth / ipv4 / udp / mpls / end actions rss type tcp udp ip end level 2 / end [2]: eth / ipv4 / udp / mpls eth / ipv4 / udp / mpls / ipv4 eth / ipv4 / udp / mpls / ipv4 / udp eth / ipv4 / udp / mpls / ipv4 / tcp eth / ipv4 / udp / mpls / ipv6 eth / ipv4 / udp / mpls / ipv6 / udp eth / ipv4 / udp / mpls / ipv6 / tcp eth / ipv4 / udp / mpls / eth / ipv4 eth / ipv4 / udp / mpls / eth / ipv4 / udp eth / ipv4 / udp / mpls / eth / ipv4 / tcp eth / ipv4 / udp / mpls / eth / ipv6 eth / ipv4 / udp / mpls / eth / ipv6 / udp eth / ipv4 / udp / mpls / eth / ipv6 / tcp [3]: eth / ipv4 / udp / mpls / eth eth / ipv4 / udp / mpls / eth / ipv4 / udp eth / ipv4 / udp / mpls / eth / ipv4 / tcp eth / ipv4 / udp / mpls / eth / ipv6 eth / ipv4 / udp / mpls / eth / ipv6 / udp eth / ipv4 / udp / mpls / eth / ipv6 / tcp [4]: pattern eth / ipv4 / udp / mpls / eth / end actions rss type tcp udp ip level 2 / end Signed-off-by: Xiaoyu Min Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_flow.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 0f0c779ca..494555b16 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -1229,6 +1229,13 @@ mlx5_flow_validate_action_rss(const struct rte_flow_action *action, RTE_FLOW_ERROR_TYPE_ACTION_CONF, NULL, "inner RSS is not supported for " "non-tunnel flows"); + if ((item_flags & MLX5_FLOW_LAYER_MPLS) && + !(item_flags & + (MLX5_FLOW_LAYER_INNER_L2 | MLX5_FLOW_LAYER_INNER_L3)) && + rss->level > 1) + return rte_flow_error_set(error, EINVAL, + RTE_FLOW_ERROR_TYPE_ITEM, NULL, + "MPLS inner RSS needs to specify inner L2/L3 items after MPLS in pattern"); return 0; } -- 2.32.0