From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4BF21A0613 for ; Thu, 26 Sep 2019 10:19:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 269C91BEF6; Thu, 26 Sep 2019 10:19:41 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id C42DF1BEF6 for ; Thu, 26 Sep 2019 10:19:39 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Sep 2019 01:19:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,551,1559545200"; d="scan'208";a="180096010" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga007.jf.intel.com with ESMTP; 26 Sep 2019 01:19:37 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.36]) by IRSMSX153.ger.corp.intel.com ([169.254.9.123]) with mapi id 14.03.0439.000; Thu, 26 Sep 2019 09:19:36 +0100 From: "Richardson, Bruce" To: Kevin Traynor , "stable@dpdk.org" , "Smoczynski, MarcinX" , "Ananyev, Konstantin" , "Yigit, Ferruh" , "salehals@mellanox.com" CC: "bluca@debian.org" Thread-Topic: [PATCH 18.11 0/1] Enable __BSD_VISIBLE Thread-Index: AQHVc8SbKFcmXfzjn0qKvoVUfVIO6qc9np9w Date: Thu, 26 Sep 2019 08:19:35 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B07EE15D6E@IRSMSX103.ger.corp.intel.com> References: <20190925171242.8005-1-ktraynor@redhat.com> In-Reply-To: <20190925171242.8005-1-ktraynor@redhat.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODczOTQ3ODItNmFjZi00NGExLTkyNWYtMDg5ZGY0ZWExMTIzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibjBYN3dCRXUzYngrRWZaajBqcnZFV09qRWRSR3V0TXZ0NkxGXC82UndYcTI0RGdpWVM1RWY5aE4za0tUN001OUoifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH 18.11 0/1] Enable __BSD_VISIBLE X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" +1 for the backport for the visibility change for BSD. > -----Original Message----- > From: Kevin Traynor [mailto:ktraynor@redhat.com] > Sent: Wednesday, September 25, 2019 6:13 PM > To: stable@dpdk.org; Smoczynski, MarcinX ; > Ananyev, Konstantin ; Yigit, Ferruh > ; salehals@mellanox.com > Cc: bluca@debian.org; Richardson, Bruce ; > Kevin Traynor > Subject: [PATCH 18.11 0/1] Enable __BSD_VISIBLE >=20 > This backport is needed for 18.11 as the below commit > [Fixes: 54e4657b2385 ("net: define IPv4 IHL and VHL")] requires that > __BSD_VISIBLE is defined for in FreeBSD. >=20 > Otherwise, there is a build error on FreeBSD similar to the one originall= y > reported here http://inbox.dpdk.org/stable/3d694042-dbe9-7560-5912- > d865da048c7c@intel.com/ >=20 > The other option is to revert the following commits from branch 18.11. >=20 > commit d8084ac1f9c74ce9fe61b26c9d4198d872d5fc7e > Author: Saleh Alsouqi > Date: Thu Jul 4 07:33:22 2019 +0000 >=20 > app/testpmd: fix MPLS IPv4 encapsulation fields >=20 > [ upstream commit a97ec9ba45d4357c172df71be3fcf601dfdb8147 ] >=20 > Having version and ihl set to 0 would result in a > corrupted/incorrect encapsulating packet for MPLS, > this commit sets these fields to 4 and 5 respectively > as defined in librte_net/rte_ip.h. >=20 > Fixes: 3e77031be855 ("app/testpmd: add MPLSoGRE encapsulation") > Fixes: a1191d39cb57 ("app/testpmd: add MPLSoUDP encapsulation") >=20 > Signed-off-by: Saleh Alsouqi > Reviewed-by: Ferruh Yigit >=20 > commit 54e4657b238593c633367a2dda48ecf4e04249bb > Author: Saleh Alsouqi > Date: Thu Jul 4 07:33:19 2019 +0000 >=20 > net: define IPv4 IHL and VHL >=20 > [ upstream commit 2318d8d5456532e8022d324937a77a416b701d2b ] >=20 > Define IPv4 Minimum IHL and VHL according to rfc791 (see [1]) >=20 > "The Version field indicates the format of the > internet header." >=20 > "Internet Header Length (ihl) is the length of the > internet header in 32 bit words, and thus points > to the beginning of the data. Note that > the minimum value for a correct header is 5." >=20 > [1] https://tools.ietf.org/html/rfc791 >=20 > Signed-off-by: Saleh Alsouqi > Reviewed-by: Ferruh Yigit >=20 > Marcin Smoczynski (1): > build: enable BSD features visibility for FreeBSD >=20 > app/meson.build | 3 --- > config/meson.build | 8 ++++++++ > drivers/meson.build | 3 --- > examples/meson.build | 3 --- > lib/meson.build | 3 --- > meson.build | 6 +++++- > mk/target/generic/rte.vars.mk | 5 +++++ > 7 files changed, 18 insertions(+), 13 deletions(-) >=20 > -- > 2.20.1