From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C061A0540 for ; Wed, 8 Jun 2022 13:38:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1FE1C42905; Wed, 8 Jun 2022 13:38:06 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id A42C24021D; Wed, 8 Jun 2022 13:38:03 +0200 (CEST) Received: from [192.168.1.40] (unknown [188.170.81.145]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 08669306; Wed, 8 Jun 2022 14:38:02 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 08669306 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1654688283; bh=iqdhyTIezH5RweIjfbJ97WjIx5MaQgb8gD+V87WgyN0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=X4/eYrulrHxWy6KKEnqC0mTkSdsoBo+/+Ls7BGw02UeewMLvO01p/E6cEqUymfqZs av2/mxOuPmVYQEkglC4jUDoZwpLINYiB+RN/2fooEhaJtB1JHdUy76QDNpNo2Yl/v2 AObHCQdPuMj+9Ah1/E1AS8X3B+D3FHltE7/PYpqY= Message-ID: <59c2ef07-f476-a861-353b-45b8a5f83a8b@oktetlabs.ru> Date: Wed, 8 Jun 2022 14:38:01 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] app/testpmd: fix packets segments allocation Content-Language: en-US To: Raja Zidane , dev@dpdk.org Cc: matan@nvidia.com, stable@dpdk.org References: <20220602125947.12581-1-rzidane@nvidia.com> From: Andrew Rybchenko In-Reply-To: <20220602125947.12581-1-rzidane@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 6/2/22 15:59, Raja Zidane wrote: > When --mbuf-size cmdln parameter is specified, the segments to scatter > packets on are allocated sequentially from these extra memory pools > (the mbuf for the first segment is allocated from the first pool, the > second one from the second pool, and so on, if segment number is greater > then pool’s the mbuf for remaining segments will be allocated from the > last valid pool). > A bug in comparing segment index with mbuf index caused wrong mapping > of one of the segments. > > Fix the comparison. > > Fixes: 2befc67ff679 ("app/testpmd: add extended Rx queue setup") > Cc: stable@dpdk.org > > Signed-off-by: Raja Zidane > Acked-by: Matan Azrad Applied to dpdk-next-net/main, thanks.