From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 7D4084541F
for <public@inbox.dpdk.org>; Thu, 13 Jun 2024 18:51:32 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 789714114B;
Thu, 13 Jun 2024 18:51:32 +0200 (CEST)
Received: from NAM12-MW2-obe.outbound.protection.outlook.com
(mail-mw2nam12on2076.outbound.protection.outlook.com [40.107.244.76])
by mails.dpdk.org (Postfix) with ESMTP id 39A37402CB;
Thu, 13 Jun 2024 18:51:28 +0200 (CEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=JXrjP9U8KK+dfxug3Br9zOb3kGXd92yiAQk3XWJhMzlDpBPVr7oicI0EVaGn1J8dNJ3eu5hOErfS0YdJvYz62uYzIVO+L2Q0soTCZgTxsKL9Ta8TRx6ER5tZ5MsoitaDljo+p1AALkLSOdB3uKVyAjjk6IjPrNSP3mh5If2eqinoI+CKhw9rBoEPIOKoxRgyKinR1MLV8j15ERZTHgCcmVUJrv7L/JcuTnb4QaE49ve8JZLrdzSbjLqTTvgm0fgpCIIg9HejEK5yF1SUfY2tnzVLddoFHg6eB2qZhSYGMVUgnWsspQdzLjTcvLzi+m4ulOmXAclUG3t4IOmSWg/KLA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=s1P0XjeBMwYpEbf45idcU0MOcUvhb48BfTQbgV3xxAA=;
b=gBfZCKN5eZWaOX1OAW0toifzVs9KZtAxRZGJcPyesiOtyIym7jCuV4EEM9Yr2RFjHuepSWVbNNMvnH8c8Fg5ofyNm0pH3hfvgeNFsyFSS1nxia+O75FeowqGIGTGQ4oP3DOD2cViMW25ZK9PRla4/Qdf4RznmSUJpXLfAca8gGUNOBVjSJWIVv245zem/D2yoLitLsGNX/2DZdVLOh3Ea9I2im4e3dkhGkvS0sPQgGKP9jpR7ni2kjnbsEhoq/kQ00f8QLSWVamBmWu+eecRnA/CuBUyHUiT688otYj3mOLgMzzeElUWZb9uGTDCUeBsnGaBfNEA/Q0/hPu3BqKRSw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=s1P0XjeBMwYpEbf45idcU0MOcUvhb48BfTQbgV3xxAA=;
b=WlQVhDBB1yGXv61xQvGHFMHI1KwndsNg/O8jCCeIplxvRcXzKY3xocI/oQ/nczj7CUDZILzJ0gfPaU1aTbqJCy68t1GCi9tgj53u+vOwxfohgkSvsOoZQjU0vy4r2/RKSxEmLVUBKSKF5hEXaDnKAPIKN5uj0QnufpBvSpYULto=
Authentication-Results: dkim=none (message not signed)
header.d=none;dmarc=none action=none header.from=amd.com;
Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11)
by SJ2PR12MB7991.namprd12.prod.outlook.com (2603:10b6:a03:4d1::12)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.33; Thu, 13 Jun
2024 16:51:18 +0000
Received: from CH2PR12MB4294.namprd12.prod.outlook.com
([fe80::ebfb:2f9f:f9ca:82cd]) by CH2PR12MB4294.namprd12.prod.outlook.com
([fe80::ebfb:2f9f:f9ca:82cd%4]) with mapi id 15.20.7677.019; Thu, 13 Jun 2024
16:51:18 +0000
Message-ID: <5a0370e4-aa42-4bc4-a5a8-34c37b88b95f@amd.com>
Date: Thu, 13 Jun 2024 17:51:14 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] app/testpmd: fix lcore ID restriction
From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Sivaprasad Tummala <sivaprasad.tummala@amd.com>,
david.marchand@redhat.com, aman.deep.singh@intel.com, yuying.zhang@intel.com
Cc: dev@dpdk.org, stable@dpdk.org
References: <20240415194631.124343-1-sivaprasad.tummala@amd.com>
<20240416095556.173787-1-sivaprasad.tummala@amd.com>
<5de50671-73b8-432d-a1a2-ce6b3120e73d@amd.com>
Content-Language: en-US
Autocrypt: addr=ferruh.yigit@amd.com; keydata=
xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9
4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J
eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg
B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9
RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ
N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ
vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S
3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum
CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA
XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln
aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID
AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK
Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3
tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU
58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs
cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD
VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg
Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc
GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV
gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW
VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD
DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG
CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe
WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi
6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl
90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv
VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA
fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr
ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC
IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk
1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak
oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq
b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ
Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX
W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW
honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA
g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn
GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ
NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs
SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe
cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH
dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk=
In-Reply-To: <5de50671-73b8-432d-a1a2-ce6b3120e73d@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: LO4P123CA0439.GBRP123.PROD.OUTLOOK.COM
(2603:10a6:600:1a9::12) To CH2PR12MB4294.namprd12.prod.outlook.com
(2603:10b6:610:a9::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SJ2PR12MB7991:EE_
X-MS-Office365-Filtering-Correlation-Id: 8406d4cb-a2e7-4aea-9bc0-08dc8bc90bd7
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;ARA:13230035|376009|1800799019|366011;
X-Microsoft-Antispam-Message-Info: =?utf-8?B?OEhYZUY3SXZBRlpkRHBvaG0rcGRFS0pTcUJ2M3REclhBWHE1Sm40Q3pleDlZ?=
=?utf-8?B?MlpoSVB6VkRpRkcwUWR4NVlIM0pXeUQ2RDZMUUhYdU5jWGt2dTd4UlVCS1hK?=
=?utf-8?B?ZStXRVAzTklUcG1sNW9iVWltU0dGejVMSURxaTYvWGMvRmRiTkVTTFVWUEJj?=
=?utf-8?B?c2Q3bXdPR09wUUl6U2VJdFVrc3dYQTFxYUFibTFjbWh4S2toQ3JuV2pFdzFx?=
=?utf-8?B?YTBONEo0cDhTbVVkOG1DbW5Hdjh3bzY1TVE2WlVFTXdFS2dCWkxCZ0gycU1I?=
=?utf-8?B?cks2UWdQS2xnOXNwMW1ONTQ5VXBpazZpS2hPWnJBUXFUMFpRZUFhZmV5bU4x?=
=?utf-8?B?VjhjZnJJMXVOZWVBaGVodjE5K0JjM1hnaFF0SUFYZ2M2M3BVUmcyN2lmVU1O?=
=?utf-8?B?UjVQa3dDZzV1NUxLNkVnL05TZjNsMVRYVFE1eGdzMW8zZW9MbWdmSWpMd0Fr?=
=?utf-8?B?Q2kwZXNrSEdZQTg4MVkrOEF6MW1FMnBMUTdxWTcyYlhsNUNCWGRMd2ppSE9N?=
=?utf-8?B?enI2UjBVcFY3OUIwUjUvSWtBanFWRU9kcTNISEtmWWpZN0phNDZ6STJlbjRn?=
=?utf-8?B?YnpMUTJLMkNRMzVPdVgyR2FkdXZZNVpsVGlDaTk1RXk2c3JpUTRwaHV0amNa?=
=?utf-8?B?ZHB3TmpoTllKMU1Ec3pwZDI5Mjdwc3haUVZLUHp1YU03UUhSalZXT21QdHhl?=
=?utf-8?B?bnBKMGZ0RW91TW5VSWtGTXFXVFV3d1pmcW12eER2Q2xod3FKQ25nSW5LQnBr?=
=?utf-8?B?VmpjRGFZNktUbU1xVTZ4Um53OTZiVE1FMURmaWpkTHR1bjJhZnptRjFtdVhQ?=
=?utf-8?B?ZTQyeTd3bGo3Ri9oM3oyRWUzVmVqdmNpU3gvbWpUdlIrSHA2MS9oSWtTRjdp?=
=?utf-8?B?R1V2Yzc0VjlZVWxoTUhodHJoUzV5ZHp5d0ZMejdGRHo5NERGY3I1eGx6MmhF?=
=?utf-8?B?ckFJZlNDS0VGWVVSbXplcFVTeXhXZDlBRDdjcmRoN2YxYUgrazg2MmZ2ODJT?=
=?utf-8?B?TnpmeUJrcTd1U0lqYjhqNUsvTDExdHhCSDRIVGNuQkhaSWxhdG81M0phR2Rl?=
=?utf-8?B?ZjJIMGxraVBDa01PdytENWJMdnoveDFxT241OVhPc1pKdllpcHVjZ3FJOWZ1?=
=?utf-8?B?Z3dlanJMeWt1UzF1OVNDMVVWV3hMdFBBcXVTWGRGUzdvZXkxWnZ1WVBWTDM3?=
=?utf-8?B?dW1rTUk1RUlEUTJ5L3A3TnoyWWhhclNwQXI1UHV1YS8xRnY4eHNuZzBnekJi?=
=?utf-8?B?WUd6ZVZ2eHpHclRTUzVJZVBiTUhrRkxvdHZNZ0JMbWNsaUNWL3JkeXJpUkJ0?=
=?utf-8?B?VjBPL2ZrcW8xUmk5bnZhTXplY0VnUkFXYjZLVEFXL2tjZ3BMTVZBM0gwc1NJ?=
=?utf-8?B?OVV5QWl4ai9MK2xNZ1dJUlZ5TDFia1RpaUJ3Y1YzSFVvOFdhc1RlSDJZcFJC?=
=?utf-8?B?VnFaY0V4NlJTVDJuQ0sxU0xRUlpaRWdTVmxHcUUwL2FoaGNaUXByL2xYeEor?=
=?utf-8?B?UHJlZllubEdabkI5QTJscGp1ZmI0aCtpUmJIUVJadXg4dzIzYVhjVGp1TzF3?=
=?utf-8?B?M05FK2Jnb2NMdXp3UE9IQ1g5bFM0UFd1MVVFejVreTlKSzRuSzUrVW1OWm1n?=
=?utf-8?B?Sy9OUnZNZlpZYlZGb0RsRE5mWTAzWGpBdENWK0Rualc2cjdpeWc0TGRqUGdE?=
=?utf-8?B?WDFOVkFXZXVrWjhwUWNpcjlrOG9YVHdCL00rWk5qK1QraTN6QWZQSnRna0Mw?=
=?utf-8?Q?J3U3/iND/kk8TiO0U9axzW+kWTiFKJP+U0xlNP/?=
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE;
SFS:(13230035)(376009)(1800799019)(366011); DIR:OUT; SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MnlaODNWYUNsVXZhTWQ0bUJESGgrVlN2aW1pblE3bkV5ZkFKVGlkUzMvUU55?=
=?utf-8?B?TXFlb0lZWmhSdDE2UHdnd1NWdU12bnhyVFFkUlZ5dTlmRStkUFVIVlBxcURQ?=
=?utf-8?B?ZXYvK2ZjVTh6aVdlK2hTSFE3d2dTcGJVMTNxTUloL0orRXhXYTJsM3I2MmdW?=
=?utf-8?B?MFc3VzBiSVJxcTZMTXpERW42S2J4SzNyc0YzVzA4WS8xRVlWelFxMDBLamtB?=
=?utf-8?B?QkFDU2pNSFEwS3F4bHdaL1h6QW16amduSHVwOVhUNWU5RkNnNGt5Qk5SS2ZN?=
=?utf-8?B?WWt1Uk1rcy9uSmoxbmV5bVkvbkN1WStqMElrZWlaM2hGWmJzNGM4M0hnWE40?=
=?utf-8?B?aXM3Sk5zWG9zZ3BuVHRaS1BENitrejNyeVFSOGhFVHp3aWF3Sm04VHQya0hR?=
=?utf-8?B?YW5NUDFRKzZQVVhyaklBaHExeU84R1NleDQ0eGVsb3FxcXJQWThuOUpYWXZN?=
=?utf-8?B?UDhPRTNYZDN0dW9UdHMrSU9NNXpidXFrZ1lLSVFlcHRwNmFPRWFLZ0xzR3Av?=
=?utf-8?B?Q1dlQXVPZWRXZEY1M3pOZ0ZVNEovaFhBSENxOVYweUVERHRhTWhCS1hCbjlx?=
=?utf-8?B?WTN4TmIwN0F3U3ZPaXIwQWdOWFhsaW1qSzIvdXkyN0tDV25MMzB0Wnh4WmV0?=
=?utf-8?B?WmNEU3RhbGU2MlhqZmcybUVVekdaeFpFQ2liWXZzRTgyKzJhZks1VUtjaFZF?=
=?utf-8?B?clB6RzRPTlB2ejk5ZU9VVGV1a0h5MVJCcFdmMDZmV01OZ3pyNWt0bVMwVFV0?=
=?utf-8?B?cE1ZRGNvSzA4NkR6dFNuY0crQnhObEU1OXNnNEVnbDY4cXpzTWJDak9GVi82?=
=?utf-8?B?ZlhjQVZrR1VhaVdiZmxoSCtFN2ROODk0QTJmb1NFM0pHYXhUcWI3RDhXR2ww?=
=?utf-8?B?N0k5YTdrdjhWNlBtUUN1WTFJcmwrZktzY1ZRZkQ1OEN3N0hnOG8xVEhlUEU4?=
=?utf-8?B?cnY0SXNISzQwblN4Vk9EczdLUnRLUUFzYWxpVnd0Q3dVZFByUndXdCsvWUNk?=
=?utf-8?B?Znh2OE01WStBMkdlakhCK3ZOTDRWNVBlQXNUbzBUWjRZcW1jZkxaWUJEVXVF?=
=?utf-8?B?aWtCQTlvVkFKTTFCaVVqQzhFLy93Qjh5R0pERXpVSEZmN3JPeWVReFdKbktN?=
=?utf-8?B?blRteFNmQU5sWXZpa0hsaFVRTGEydE56SXVkcDZVOHB5NDVwaEFHR1ZHZUV0?=
=?utf-8?B?ZElZWXVRNVRpc1hXQm13ai80UnJwcnBmdUFCUVRNWWhydWR2cCtwdk9YTjFV?=
=?utf-8?B?ZlFhNEg2ZEt2WTUxWGFremRTckRZLzBuVlBVVGNWa09rUVF1dkpST3BvdC9n?=
=?utf-8?B?a0h0WGNSeVFQb1d2Yk05a1pDOUVaUFp6SklBU1RxWnVMM3lhazMvbW9udTZ6?=
=?utf-8?B?UlZKR3JONGppa1dzRGprSVcvUDlMQ1kzN1dhS0txNHBma21WZTZkV0hSVnJU?=
=?utf-8?B?RGtCdkpjM0JGWGhuTDh0cHVwb1dXdndZYmVoUU5qUW9MdEZtZXBNNDVSV3dw?=
=?utf-8?B?bUZCSDh3MTk4TXpMT1drVlNIVW4wb2dEWTVrNVdPN05oZHpGZUVIclprb2pK?=
=?utf-8?B?dlR4T0MyMlVYZERoQU1pNUxJbHBZeUdnVzlFTXlWSElIMS9jTHZFU3dQMzM4?=
=?utf-8?B?SWs5Wm5sV3V2MTZpMWlQR0dTbFNkdXdyNHg5MUlGSWV2akdsbCt1VStvUTdB?=
=?utf-8?B?bUFWZlpIbGdJUktZWGdZZ08yV0d2dTRkNHJiWGcxSFZheEkzRmU1Tzd2THhG?=
=?utf-8?B?SFdENW9JanNoVStUQklGbHNQZVZpVGtHZ2Exb0NnQnVCUDFUL0ZCSjVqaHgz?=
=?utf-8?B?TkxsaHZpQURXemhPaDhwVDNrdWYwUXFwanI4REorWEQ1YU92OUpnejZUdzRO?=
=?utf-8?B?MFIzL0VMUzljc3FUQlJEbW80aWRqc2F3VnVRZWpxOFFoNTNHZTc0b3ZMb2dN?=
=?utf-8?B?SlgyVkdnM3Y4MTRoZFVQd1grSG50djllSCtFUkhSUFdRRzF5WFpLME01Visr?=
=?utf-8?B?azR3VUw5a3NSWUVSdC9aaTVDKzgwQnR4TkFLckFmbXhhSDZTVEFIMWhoNHFo?=
=?utf-8?B?YkxiY3l4TXNYWU90d2p4bjRkMFN2M3hhUEIvbFVEenl0K3pXdStCa1EveE8w?=
=?utf-8?Q?xxrQfEzm8kzjJPgAzucsfN6L5?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8406d4cb-a2e7-4aea-9bc0-08dc8bc90bd7
X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2024 16:51:18.5692 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4tPsjjEt/HkOhdkcuH0OeH5TYVmdYBIl+MU9ezi+IUvWeWuAtw8KCP6raHTVkS6h
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB7991
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
On 4/19/2024 12:30 PM, Ferruh Yigit wrote:
> On 4/16/2024 10:55 AM, Sivaprasad Tummala wrote:
>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
>> index ba1007ace6..6b28c22c96 100644
>> --- a/app/test-pmd/config.c
>> +++ b/app/test-pmd/config.c
>> @@ -4785,9 +4785,9 @@ fwd_stream_on_other_lcores(uint16_t domain_id, lcoreid_t src_lc,
>> continue;
>> printf("Shared Rx queue group %u queue %hu can't be scheduled on different cores:\n",
>> share_group, share_rxq);
>> - printf(" lcore %hhu Port %hu queue %hu\n",
>> + printf(" lcore %u Port %hu queue %hu\n",
>> src_lc, src_port, src_rxq);
>> - printf(" lcore %hhu Port %hu queue %hu\n",
>> + printf(" lcore %u Port %hu queue %hu\n",
>> lc_id, fs->rx_port, fs->rx_queue);
>> printf("Please use --nb-cores=%hu to limit number of forwarding cores\n",
>> nb_rxq);
>> @@ -5159,7 +5159,7 @@ icmp_echo_config_setup(void)
>> lcoreid_t lc_id;
>> uint16_t sm_id;
>>
>> - if ((nb_txq * nb_fwd_ports) < nb_fwd_lcores)
>> + if ((lcoreid_t)(nb_txq * nb_fwd_ports) < nb_fwd_lcores)
>> cur_fwd_config.nb_fwd_lcores = (lcoreid_t)
>> (nb_txq * nb_fwd_ports);
>>
>
> Hi Sivaprasad,
>
> Is this '(lcoreid_t)' cast required? Because of integer promotion I
> think result will be correct without casting.
>
> (And without integer promotion considered, casting needs to be done on
> one of the variables, not to the result, because result may be already
> cast down I think. Anyway this is not required for this case since
> variables are u16.)
>
Why casing required (for record) is,
'nb_txq' -> uint16_t, promoted to 'int'
'nb_fwd_ports' -> uint16_t, promoted to 'int'
(nb_txq * nb_fwd_ports) -> result 'int'
nb_fwd_lcores -> 'uint32_t'
comparison between 'int' & 'uint32_t' gives warning. After some compiler
version it is smart enough to not give a warning, but casting is
required for old compilers.
And back to my comment above, casting one of the parameter to
'lcoreid_t' also works, as it forcing promotion to 'unsigned int'
instead. But logically casting looks odd, so keeping casting result.