* [dpdk-stable] [PATCH 1/9] bus: fix bus name registration [not found] <cover.1495629122.git.gaetan.rivet@6wind.com> @ 2017-05-24 15:12 ` Gaetan Rivet [not found] ` <cover.1495642202.git.gaetan.rivet@6wind.com> 1 sibling, 0 replies; 9+ messages in thread From: Gaetan Rivet @ 2017-05-24 15:12 UTC (permalink / raw) To: dev Cc: Gaetan Rivet, Jan Blunck, Stephen Hemminger, Maxime Coquelin, Jerin Jacob, David Marchand, stable The default bus registration function should not result in buses registering with double quotes within their names. Fixes: a97725791eec ("bus: introduce bus abstraction") Cc: stable@dpdk.org Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com> --- lib/librte_eal/common/include/rte_bus.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/include/rte_bus.h b/lib/librte_eal/common/include/rte_bus.h index 201b0ff..3893ad6 100644 --- a/lib/librte_eal/common/include/rte_bus.h +++ b/lib/librte_eal/common/include/rte_bus.h @@ -222,7 +222,7 @@ struct rte_bus *rte_bus_find_by_device(const struct rte_device *dev); #define RTE_REGISTER_BUS(nm, bus) \ static void __attribute__((constructor(101), used)) businitfn_ ##nm(void) \ {\ - (bus).name = RTE_STR(nm);\ + (bus).name = nm;\ rte_bus_register(&bus); \ } -- 2.1.4 ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <cover.1495642202.git.gaetan.rivet@6wind.com>]
* [dpdk-stable] [PATCH v2 1/9] bus: fix bus name registration [not found] ` <cover.1495642202.git.gaetan.rivet@6wind.com> @ 2017-05-24 16:15 ` Gaetan Rivet [not found] ` <cover.1496311609.git.gaetan.rivet@6wind.com> 1 sibling, 0 replies; 9+ messages in thread From: Gaetan Rivet @ 2017-05-24 16:15 UTC (permalink / raw) To: dev; +Cc: Gaetan Rivet, stable The default bus registration function should not result in buses registering with double quotes within their names. Fixes: a97725791eec ("bus: introduce bus abstraction") Cc: stable@dpdk.org Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com> --- lib/librte_eal/common/include/rte_bus.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/include/rte_bus.h b/lib/librte_eal/common/include/rte_bus.h index 201b0ff..3893ad6 100644 --- a/lib/librte_eal/common/include/rte_bus.h +++ b/lib/librte_eal/common/include/rte_bus.h @@ -222,7 +222,7 @@ struct rte_bus *rte_bus_find_by_device(const struct rte_device *dev); #define RTE_REGISTER_BUS(nm, bus) \ static void __attribute__((constructor(101), used)) businitfn_ ##nm(void) \ {\ - (bus).name = RTE_STR(nm);\ + (bus).name = nm;\ rte_bus_register(&bus); \ } -- 2.1.4 ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <cover.1496311609.git.gaetan.rivet@6wind.com>]
* [dpdk-stable] [PATCH v3 1/9] bus: fix bus name registration [not found] ` <cover.1496311609.git.gaetan.rivet@6wind.com> @ 2017-06-01 10:08 ` Gaetan Rivet [not found] ` <cover.1496876810.git.gaetan.rivet@6wind.com> 1 sibling, 0 replies; 9+ messages in thread From: Gaetan Rivet @ 2017-06-01 10:08 UTC (permalink / raw) To: dev; +Cc: Gaetan Rivet, stable The default bus registration function should not result in buses registering with double quotes within their names. Fixes: a97725791eec ("bus: introduce bus abstraction") Cc: stable@dpdk.org Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com> --- lib/librte_eal/common/include/rte_bus.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/include/rte_bus.h b/lib/librte_eal/common/include/rte_bus.h index 3c59fc2..3bc4e1c 100644 --- a/lib/librte_eal/common/include/rte_bus.h +++ b/lib/librte_eal/common/include/rte_bus.h @@ -234,7 +234,7 @@ struct rte_bus *rte_bus_find_by_device(const struct rte_device *dev); #define RTE_REGISTER_BUS(nm, bus) \ static void __attribute__((constructor(101), used)) businitfn_ ##nm(void) \ {\ - (bus).name = RTE_STR(nm);\ + (bus).name = nm;\ rte_bus_register(&bus); \ } -- 2.1.4 ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <cover.1496876810.git.gaetan.rivet@6wind.com>]
* [dpdk-stable] [PATCH v4 1/9] bus: fix bus name registration [not found] ` <cover.1496876810.git.gaetan.rivet@6wind.com> @ 2017-06-07 23:56 ` Gaetan Rivet [not found] ` <cover.1497999826.git.gaetan.rivet@6wind.com> 1 sibling, 0 replies; 9+ messages in thread From: Gaetan Rivet @ 2017-06-07 23:56 UTC (permalink / raw) To: dev; +Cc: Gaetan Rivet, stable The default bus registration function should not result in buses registering with double quotes within their names. Fixes: a97725791eec ("bus: introduce bus abstraction") Cc: stable@dpdk.org Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com> --- lib/librte_eal/common/include/rte_bus.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/include/rte_bus.h b/lib/librte_eal/common/include/rte_bus.h index cb44e46..7264e3f 100644 --- a/lib/librte_eal/common/include/rte_bus.h +++ b/lib/librte_eal/common/include/rte_bus.h @@ -247,7 +247,7 @@ struct rte_bus *rte_bus_find_by_device(const struct rte_device *dev); #define RTE_REGISTER_BUS(nm, bus) \ static void __attribute__((constructor(101), used)) businitfn_ ##nm(void) \ {\ - (bus).name = RTE_STR(nm);\ + (bus).name = nm;\ rte_bus_register(&bus); \ } -- 2.1.4 ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <cover.1497999826.git.gaetan.rivet@6wind.com>]
* [dpdk-stable] [PATCH v5 1/7] bus: fix bus name registration [not found] ` <cover.1497999826.git.gaetan.rivet@6wind.com> @ 2017-06-20 23:30 ` Gaetan Rivet 2017-06-27 15:53 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson 2017-06-27 19:19 ` Jan Blunck [not found] ` <cover.1499127915.git.gaetan.rivet@6wind.com> 1 sibling, 2 replies; 9+ messages in thread From: Gaetan Rivet @ 2017-06-20 23:30 UTC (permalink / raw) To: dev; +Cc: Gaetan Rivet, stable The default bus registration function should not result in buses registering with double quotes within their names. Fixes: a97725791eec ("bus: introduce bus abstraction") Cc: stable@dpdk.org Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com> --- lib/librte_eal/common/include/rte_bus.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/include/rte_bus.h b/lib/librte_eal/common/include/rte_bus.h index fcc2442..b220299 100644 --- a/lib/librte_eal/common/include/rte_bus.h +++ b/lib/librte_eal/common/include/rte_bus.h @@ -254,7 +254,7 @@ struct rte_bus *rte_bus_find_by_device(const struct rte_device *dev); #define RTE_REGISTER_BUS(nm, bus) \ static void __attribute__((constructor(101), used)) businitfn_ ##nm(void) \ {\ - (bus).name = RTE_STR(nm);\ + (bus).name = nm;\ rte_bus_register(&bus); \ } -- 2.1.4 ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v5 1/7] bus: fix bus name registration 2017-06-20 23:30 ` [dpdk-stable] [PATCH v5 1/7] " Gaetan Rivet @ 2017-06-27 15:53 ` Bruce Richardson 2017-06-27 19:19 ` Jan Blunck 1 sibling, 0 replies; 9+ messages in thread From: Bruce Richardson @ 2017-06-27 15:53 UTC (permalink / raw) To: Gaetan Rivet; +Cc: dev, stable On Wed, Jun 21, 2017 at 01:30:30AM +0200, Gaetan Rivet wrote: > The default bus registration function should not result in buses > registering with double quotes within their names. > > Fixes: a97725791eec ("bus: introduce bus abstraction") > Cc: stable@dpdk.org > > Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com> ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v5 1/7] bus: fix bus name registration 2017-06-20 23:30 ` [dpdk-stable] [PATCH v5 1/7] " Gaetan Rivet 2017-06-27 15:53 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson @ 2017-06-27 19:19 ` Jan Blunck 2017-07-04 1:05 ` Gaëtan Rivet 1 sibling, 1 reply; 9+ messages in thread From: Jan Blunck @ 2017-06-27 19:19 UTC (permalink / raw) To: Gaetan Rivet; +Cc: dev, stable On Wed, Jun 21, 2017 at 1:30 AM, Gaetan Rivet <gaetan.rivet@6wind.com> wrote: > The default bus registration function should not result in buses > registering with double quotes within their names. > This is breaking expectations with users. All other registration macro pass the names through the stringification. The problem is that you pass in the name as a string already ("PCI" instead of PCI). > Fixes: a97725791eec ("bus: introduce bus abstraction") > Cc: stable@dpdk.org > > Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com> > --- > lib/librte_eal/common/include/rte_bus.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_eal/common/include/rte_bus.h b/lib/librte_eal/common/include/rte_bus.h > index fcc2442..b220299 100644 > --- a/lib/librte_eal/common/include/rte_bus.h > +++ b/lib/librte_eal/common/include/rte_bus.h > @@ -254,7 +254,7 @@ struct rte_bus *rte_bus_find_by_device(const struct rte_device *dev); > #define RTE_REGISTER_BUS(nm, bus) \ > static void __attribute__((constructor(101), used)) businitfn_ ##nm(void) \ > {\ > - (bus).name = RTE_STR(nm);\ > + (bus).name = nm;\ > rte_bus_register(&bus); \ > } > > -- > 2.1.4 > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v5 1/7] bus: fix bus name registration 2017-06-27 19:19 ` Jan Blunck @ 2017-07-04 1:05 ` Gaëtan Rivet 0 siblings, 0 replies; 9+ messages in thread From: Gaëtan Rivet @ 2017-07-04 1:05 UTC (permalink / raw) To: Jan Blunck; +Cc: dev, stable On Tue, Jun 27, 2017 at 09:19:14PM +0200, Jan Blunck wrote: > On Wed, Jun 21, 2017 at 1:30 AM, Gaetan Rivet <gaetan.rivet@6wind.com> wrote: > > The default bus registration function should not result in buses > > registering with double quotes within their names. > > > > This is breaking expectations with users. All other registration macro > pass the names through the stringification. The problem is that you > pass in the name as a string already ("PCI" instead of PCI). > > I agree that it does not behave as expected. However, all buses are currently using it this way, and this cannot be fixed if maintainers keep using public define's for their bus name. > > Fixes: a97725791eec ("bus: introduce bus abstraction") > > Cc: stable@dpdk.org > > > > Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com> > > --- > > lib/librte_eal/common/include/rte_bus.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/librte_eal/common/include/rte_bus.h b/lib/librte_eal/common/include/rte_bus.h > > index fcc2442..b220299 100644 > > --- a/lib/librte_eal/common/include/rte_bus.h > > +++ b/lib/librte_eal/common/include/rte_bus.h > > @@ -254,7 +254,7 @@ struct rte_bus *rte_bus_find_by_device(const struct rte_device *dev); > > #define RTE_REGISTER_BUS(nm, bus) \ > > static void __attribute__((constructor(101), used)) businitfn_ ##nm(void) \ > > {\ > > - (bus).name = RTE_STR(nm);\ > > + (bus).name = nm;\ > > rte_bus_register(&bus); \ > > } > > > > -- > > 2.1.4 > > -- Gaëtan Rivet 6WIND ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <cover.1499127915.git.gaetan.rivet@6wind.com>]
* [dpdk-stable] [PATCH v6 1/6] bus: fix bus name registration [not found] ` <cover.1499127915.git.gaetan.rivet@6wind.com> @ 2017-07-04 0:58 ` Gaetan Rivet 0 siblings, 0 replies; 9+ messages in thread From: Gaetan Rivet @ 2017-07-04 0:58 UTC (permalink / raw) To: dev; +Cc: Gaetan Rivet, stable The default bus registration function should not result in buses registering with double quotes within their names. Fixes: a97725791eec ("bus: introduce bus abstraction") Cc: stable@dpdk.org Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com> --- lib/librte_eal/common/include/rte_bus.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/include/rte_bus.h b/lib/librte_eal/common/include/rte_bus.h index 34ea9d5..c1c8fa5 100644 --- a/lib/librte_eal/common/include/rte_bus.h +++ b/lib/librte_eal/common/include/rte_bus.h @@ -258,7 +258,7 @@ struct rte_bus *rte_bus_find_by_name(const char *busname); #define RTE_REGISTER_BUS(nm, bus) \ static void __attribute__((constructor(101), used)) businitfn_ ##nm(void) \ {\ - (bus).name = RTE_STR(nm);\ + (bus).name = nm;\ rte_bus_register(&bus); \ } -- 2.1.4 ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-07-04 1:05 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <cover.1495629122.git.gaetan.rivet@6wind.com>
2017-05-24 15:12 ` [dpdk-stable] [PATCH 1/9] bus: fix bus name registration Gaetan Rivet
[not found] ` <cover.1495642202.git.gaetan.rivet@6wind.com>
2017-05-24 16:15 ` [dpdk-stable] [PATCH v2 " Gaetan Rivet
[not found] ` <cover.1496311609.git.gaetan.rivet@6wind.com>
2017-06-01 10:08 ` [dpdk-stable] [PATCH v3 " Gaetan Rivet
[not found] ` <cover.1496876810.git.gaetan.rivet@6wind.com>
2017-06-07 23:56 ` [dpdk-stable] [PATCH v4 " Gaetan Rivet
[not found] ` <cover.1497999826.git.gaetan.rivet@6wind.com>
2017-06-20 23:30 ` [dpdk-stable] [PATCH v5 1/7] " Gaetan Rivet
2017-06-27 15:53 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2017-06-27 19:19 ` Jan Blunck
2017-07-04 1:05 ` Gaëtan Rivet
[not found] ` <cover.1499127915.git.gaetan.rivet@6wind.com>
2017-07-04 0:58 ` [dpdk-stable] [PATCH v6 1/6] " Gaetan Rivet
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).