From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 948E4433A7 for ; Thu, 23 Nov 2023 11:52:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6E168402A6; Thu, 23 Nov 2023 11:52:22 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 484B44026B for ; Thu, 23 Nov 2023 11:52:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700736740; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PPsnhK+eWoDz0jdMy2W3s2PyRajee/TQ3eEAgDUxIuI=; b=bMPzOlh7ZQl8zaLUIPzfHDYSlHmCqD+lQVqfeG4iPDPMnqHh7DjaIpzWqwwZ9ECILoBUOp 2scempm0hyvaFyKjO7G7ANOs+Nu7g/xzVPax0hGNlg+zuVxNNw19ZsW7HapUyRyw/Nr9r6 PoAlYss2lB0YHBhBSeJXF2OcUNu10OM= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-376-Wvawjl1OMCSwENhRQztC7A-1; Thu, 23 Nov 2023 05:52:19 -0500 X-MC-Unique: Wvawjl1OMCSwENhRQztC7A-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-332cb492d0aso380876f8f.2 for ; Thu, 23 Nov 2023 02:52:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700736738; x=1701341538; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PPsnhK+eWoDz0jdMy2W3s2PyRajee/TQ3eEAgDUxIuI=; b=pGS+bnbkzVzBZ+WNdkpdx+AL2T/J/HOgXxdjygmjYhfBEYyGicb9J7euG6eg8sVYPg MckD5ZL6PRSdb89zXAjT/RquYyn5dsU9BRyVrMICDIYzM42fVuU8QCCmf7M355UsabrA h8XW5kn0kQdKm/6CasgtmuUlEy5VEL9Re5mxmzS3iEDDQDbxPlgzBfiCtEfDdramD8yz N7q86qtnCAC1gJxWXczS6yXKOkdUIRstQa4ZcsMnvAkaYyJuHIq0KKDm4fx5NBfZPdFx ys0r+0HPNZxgsdYwZU3Cyp8Rw6aOzwPKsmGj754vunW5GQUoigN6GsyCnElyZ37gPg6E lpfw== X-Gm-Message-State: AOJu0YxuOxw27MzOzgfaLUwdW2Zj05lBoRdnh0G/LP4E8hVA8jHTPhzh OqsoYes2PJ6WW+6OBr29zBHOtVMdj2IHbyygvcc+Ko9FiPvzx6rBYgc+Uv1T1UmVs0LTRqtmH4+ snCxEuQs= X-Received: by 2002:a5d:6dac:0:b0:332:d369:2da4 with SMTP id u12-20020a5d6dac000000b00332d3692da4mr4114239wrs.9.1700736738354; Thu, 23 Nov 2023 02:52:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IHnPTob0DiVhbmq2Y2fYWSylb6vB5NSYKNbHrUK46SsGaj2mhm6iCRCpXjrbOQI2sdCBrBcRQ== X-Received: by 2002:a5d:6dac:0:b0:332:d369:2da4 with SMTP id u12-20020a5d6dac000000b00332d3692da4mr4114224wrs.9.1700736738019; Thu, 23 Nov 2023 02:52:18 -0800 (PST) Received: from [192.168.0.36] ([78.16.130.39]) by smtp.gmail.com with ESMTPSA id j8-20020adfe508000000b00318147fd2d3sm1336458wrm.41.2023.11.23.02.52.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Nov 2023 02:52:17 -0800 (PST) Message-ID: <5a9bec54-cd4e-051e-9fc4-eb412abbd846@redhat.com> Date: Thu, 23 Nov 2023 10:52:16 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 To: Dengdui Huang , stable@dpdk.org Cc: liuyonglong@huawei.com References: <20231123011927.2993620-1-huangdengdui@huawei.com> From: Kevin Traynor Subject: Re: [PATCH 21.11] net/hns3: fix IMP or global reset In-Reply-To: <20231123011927.2993620-1-huangdengdui@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 23/11/2023 01:19, Dengdui Huang wrote: > [ upstream commit 1eee1ea75c0eadaea6dde368b289cf0acf6a1190 ] > > Currently, when the IMP or Global reset detected, the vector0 > interrupt is enabled before the reset process is completed. > At this moment, if the initialization of IMP is not completed, > and the vector0 interrupt may continue to be reported. In this > scenario, the IMP/global reset being performed by the driver > does not need to be interrupted. Therefore, for IMP and global > resets, the driver has to enable the interrupt after the end > of reset. > > The RAS interrupt is also shared with the vector0 interrupt. > When the interrupt is disabled, the RAS interrupt can still be > reported to the driver and the driver interrupt processing > function is also called. In this case, the interrupt status of > the IMP/global may still exist. Therefore, this patch also has > to the check of the new reset level based on the priority of > reset level in the interrupt handler. > > Fixes: 2790c6464725 ("net/hns3: support device reset") > Fixes: 3988ab0eee52 ("net/hns3: add abnormal interrupt process") > Cc:stable@dpdk.org > > Signed-off-by: Dengdui Huang > --- > drivers/net/hns3/hns3_ethdev.c | 88 ++++++++++++++++++++++++++++------ > drivers/net/hns3/hns3_ethdev.h | 1 + > drivers/net/hns3/hns3_intr.c | 2 + > 3 files changed, 77 insertions(+), 14 deletions(-) Applied to 21.11 branch. Thanks for backporting.