From: David Christensen <drc@linux.vnet.ibm.com>
To: luca.boccassi@gmail.com, stable@dpdk.org
Subject: Re: [PATCH 20.11] config/ppc: fix build with GCC >= 10
Date: Thu, 20 Jan 2022 10:00:35 -0800 [thread overview]
Message-ID: <5b092990-c53c-e688-8eb5-ee4e73dee285@linux.vnet.ibm.com> (raw)
In-Reply-To: <20220120110250.1469529-1-luca.boccassi@gmail.com>
On 1/20/22 3:02 AM, luca.boccassi@gmail.com wrote:
> From: David Marchand <david.marchand@redhat.com>
>
> [ backported from upstream commit dfb1ad1e7a070926c9bd9fdf38e6b944a21f1d49 ]
>
> Like for python, multiline statements in meson must either use a
> backslash character (explicit continuation) or be enclosed in ()
> (implicit continuation).
>
> python PEP8 recommends the latter [1], and it looks like meson had
> an issue with backslash before 0.50 [2].
>
> 1: https://www.python.org/dev/peps/pep-0008/#multiline-if-statements
> 2: https://github.com/mesonbuild/meson/commit/90c9b868b20b
>
> Fixes: 394407f50c90 ("config/ppc: ignore GCC 11 psabi warnings")
>
> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> Required to fix build on ppc64el with gcc 10+
Reviewed-by: David Christensen <drc@linux.vnet.ibm.com>
prev parent reply other threads:[~2022-01-20 18:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 11:02 luca.boccassi
2022-01-20 18:00 ` David Christensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b092990-c53c-e688-8eb5-ee4e73dee285@linux.vnet.ibm.com \
--to=drc@linux.vnet.ibm.com \
--cc=luca.boccassi@gmail.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).