[dpdk-stable] 18.11.3 (LTS) patches review and test

[Kevin Traynor <ktraynor@redhat.com>]

On 19/09/2019 11:22, Yu, PingX wrote:
> Hi all,
> Update Intel test result here.
> 

Hi Yu Ping,

Thanks for testing. Some comments/questions on the failures,

> # Basic Intel(R) NIC testing
> * PF(i40e): Pass
> * PF(ixgbe): Pass
> * VF: Pass 
> * Build or compile: 3 bugs are found.
>   1. [dpdk-stable 18.11.3] compile error on freebsd12

ok, I've figured this out and will send a patch.

>   2. [dpdk-stable 18.11.3] meson build error on ub1604-i86

What are the error logs? Is it a regression for you? i.e. did this test
pass with 18.11.2?

>   3. [dpdk-stable 18.11.3] config\x86\meson.build error on WIN10

Windows support was not added until DPDK 19.05.

thanks,
Kevin.

> * Intel NIC single core/NIC performance: Pass 
> 
> #Basic cryptodev and virtio testing
> * vhost/virtio basic loopback, PVP and performance test: Pass.
> * cryptodev: Pass
> 
> Regards,
> Yu Ping
> 
> -----Original Message-----
> From: Kevin Traynor [mailto:ktraynor@redhat.com] 
> Sent: Saturday, September 14, 2019 12:31 AM
> To: stable@dpdk.org
> Cc: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>; Walker, Benjamin <benjamin.walker@intel.com>; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Yu, PingX <pingx.yu@intel.com>; Xu, Qian Q <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
> Subject: 18.11.3 (LTS) patches review and test
> 
> Hi all,
> 
> Here is a list of patches targeted for LTS release 18.11.3. 
> 
> The planned date for the final release is 9th October.
> 
> Please help with testing and validation of your use cases and report any issues/results in reply to this mail. For the final release the fixes and reported validations will be added to the release notes.
> 
> A release candidate tarball can be found at:
> 
>     https://dpdk.org/browse/dpdk-stable/tag/?id=v18.11.3-rc1
> 
> These patches are located at branch 18.11 of dpdk-stable repo:
>     https://dpdk.org/browse/dpdk-stable/
> 
> Thanks.
> 
> Kevin Traynor
> 
> ---
> Aaron Conole (2):
>       test/flow_classify: fix undefined behavior
>       acl: fix undefined behavior of bit shifts
> 
> Adam Dybkowski (1):
>       compress/zlib: fix error handling
> 
> Aideen McLoughlin (1):
>       net/pcap: fix possible mbuf double freeing
> 
> Ajit Khaparde (6):
>       net/bnxt: fix TSO
>       net/bnxt: check for error conditions in Tx path
>       net/bnxt: fix RSS RETA indirection table ops
>       net/bnxt: save the number of EM flow count
>       net/bnxt: fix compiler warning
>       net/bnxt: remove unnecessary interrupt disable
> 
> Akash Saxena (1):
>       crypto/openssl: remove useless check before freeing
> 
> Ali Alnubani (3):
>       examples/ip_fragmentation: fix Tx queues init
>       net/mlx5: fix 32-bit build
>       doc: fix link about bifurcated model in Linux guide
> 
> Amit Gupta (2):
>       net/thunderx: fix crash on detach
>       app/testpmd: fix latency stats deinit on signal
> 
> Anatoly Burakov (4):
>       eal/freebsd: fix init completion
>       eal/freebsd: fix config creation
>       vfio: use contiguous mapping for IOVA as VA mode
>       test: enable installing app with meson
> 
> Andrew Lee (1):
>       net/sfc/base: fix signed/unsigned mismatch
> 
> Andrew Rybchenko (16):
>       ethdev: fix Tx prepare documentation to use positive errno
>       net/atlantic: fix Tx prepare to set positive rte_errno
>       net/e1000: fix Tx prepare to set positive rte_errno
>       net/enic: fix Tx prepare to set positive rte_errno
>       net/fm10k: fix Tx prepare to set positive rte_errno
>       net/i40e: fix Tx prepare to set positive rte_errno
>       net/iavf: fix Tx prepare to set positive rte_errno
>       net/ixgbe: fix Tx prepare to set positive rte_errno
>       net/qede: fix Tx prepare to set positive rte_errno
>       net/vmxnet3: fix Tx prepare to set positive rte_errno
>       ethdev: avoid error on PCI unplug of closed port
>       net/sfc: ensure that device is closed on removal
>       ethdev: avoid getting uninitialized info for bad port
>       net/sfc: fix power of 2 round up when align has smaller type
>       net/sfc: fix align to power of 2 when align has smaller type
>       net/sfc: unify power of 2 alignment check macro
> 
> Andrius Sirvys (2):
>       usertools: replace unsafe input function
>       usertools: fix input handling in telemetry script
> 
> Andy Pei (1):
>       net/i40e: fix crash when TxQ/RxQ set to 0 in VF
> 
> Ankur Dwivedi (1):
>       app/crypto-perf: fix CSV format
> 
> Arek Kusztal (2):
>       crypto/openssl: fix usage of non constant time memcmp
>       crypto/openssl: fix free of asymmetric crypto keys
> 
> Asaf Penso (2):
>       net/mlx5: fix condition for link update fallback
>       net/mlx5: check memory allocation in flow creation
> 
> Bao-Long Tran (2):
>       examples/l3fwd-vf: remove unused Rx/Tx configuration
>       doc: remove useless Rx configuration in l2fwd guide
> 
> Bernard Iremonger (1):
>       flow_classify: fix out-of-bounds access
> 
> Bruce Richardson (5):
>       examples: fix make clean when using pkg-config
>       kernel/freebsd: fix module build on latest head
>       test: add rawdev autotest to meson
>       examples: fix pkg-config detection with older make
>       doc: fix build with latest meson
> 
> Chenbo Xia (1):
>       crypto/virtio: check PCI config read
> 
> Congwen Zhang (1):
>       net/ixgbe/base: fix product version check
> 
> David Harton (1):
>       net/ena: fix admin CQ polling for 32-bit
> 
> David Hunt (2):
>       examples/power: fix FreeBSD meson lib dependency
>       examples/power: fix strcpy buffer overrun
> 
> David Marchand (26):
>       net/cxgbe: do not dereference global config struct
>       examples/multi_process: do not dereference global config struct
>       examples/qos_sched: do not dereference global config struct
>       test/hash: use existing lcore API
>       examples/multi_process: fix FreeBSD build
>       net/virtio: remove useless check on mempool
>       net/i40e: fix dropped packets statistics name
>       examples/vdpa: remove trace of legacy linuxapp
>       test/hash: fix off-by-one check on core count
>       eal: hide internal hotplug function
>       vfio: remove incorrect experimental tag
>       mem: remove incorrect experimental tag on static symbol
>       telemetry: add missing header include
>       net/bnx2x: fix invalid free on unplug
>       drivers/net: fix double free on init failure
>       mem: fix typo in API description
>       kni: abort when IOVA is not PA
>       net/pcap: fix Rx with small buffers
>       net/pcap: fix Tx return count in error conditions
>       app/testpmd: fix eth packet dump for small buffers
>       app/testpmd: rename ambiguous VF config variable
>       eal: fix control thread affinity with --lcores
>       test: remove link to ixgbe/i40e with meson
>       eal: hide internal function
>       bus/pci: remove unused x86 Linux constant
>       net/pcap: fix concurrent multiseg Tx
> 
> Dekel Peled (8):
>       net/mlx5: fix missing validation of null pointer
>       net/mlx5: fix description of return value
>       net/mlx5: fix memory free on queue create error
>       net/mlx5: fix order of items in NEON scatter
>       doc: fix ethernet addresses in flow API guide
>       net/mlx5: fix typos in comments
>       net/mlx5: remove redundant item from union
>       net/mlx5: fix validation of VLAN PCP item
> 
> Dharmik Thakkar (1):
>       test/hash: rectify slave id to point to valid cores
> 
> Dilshod Urazov (7):
>       net/virtio: add Tx preparation
>       net/virtio: move VLAN tag insertion to Tx prepare
>       examples/ipsec-secgw: fix error sign
>       eventdev: fix error sign
>       event/sw: fix error sign
>       event/opdl: fix error sign
>       net: adjust L2 length on soft VLAN insertion
> 
> Ed Czeck (1):
>       net/ark: fix queue packet replacement
> 
> Erik Gabriel Carrillo (1):
>       examples/performance-thread: init timer subsystem
> 
> Fan Zhang (3):
>       examples/vhost_crypto: remove unused function
>       vhost/crypto: fix logically dead code
>       vhost/crypto: fix inferred misuse of enum
> 
> Ferruh Yigit (5):
>       telemetry: fix build
>       kni: fix segmented mbuf data overflow
>       cryptodev: fix typo in comment
>       security: remove duplicated symbols from map file
>       igb_uio: fix build on Linux 5.3 for fall through
> 
> Fiona Trahe (1):
>       doc: clarify data plane error handling in compressdev
> 
> Flavia Musatescu (1):
>       telemetry: fix build warnings seen when using gcc 9
> 
> Gagandeep Singh (1):
>       eal: increase maximum different hugepage sizes on Arm
> 
> Gage Eads (1):
>       doc: add a note for multi-process in mempool guide
> 
> Gautam Dawar (1):
>       net/sfc/base: enable chained multicast on all EF10 cards
> 
> Gosia Bakota (1):
>       crypto/qat: set message field to zero in sym SGL case
> 
> Haiyue Wang (3):
>       net/ixgbevf: add full link status check option
>       app/testpmd: fix parsing RSS queue rule
>       examples/tep_term: remove duplicate definitions
> 
> Hariprasad Govindharajan (1):
>       examples/l3fwd: fix unaligned memory access on x86
> 
> Harman Kalra (3):
>       test/distributor: fix flush with worker shutdown
>       distributor: fix check of workers number
>       examples/ptpclient: fix delay request message
> 
> Hemant Agrawal (5):
>       crypto/dpaa2_sec: fix handling of session init failure
>       net/dpaa: check multi-segment external buffers
>       net/dpaa: fix build with 0 headroom
>       bus/fslmc: fix build with 0 headroom
>       net/virtio: fix build with 0 headroom
> 
> Herakliusz Lipiec (3):
>       test: fix autotest crash
>       mk: fix custom kernel directory name
>       net/i40e: fix MAC removal check
> 
> Honnappa Nagarahalli (2):
>       test/hash: fix data reset on new run
>       hash: use ordered loads only if signature matches
> 
> Igor Ryzhov (1):
>       kernel/linux: fix modules install path
> 
> Ilya Maximets (1):
>       eal: fix positive error codes from probe/remove
> 
> Ivan Malov (2):
>       net: fix encapsulation markers for inner L3 offset
>       net: fix how L4 checksum choice is tested
> 
> Jananee Parthasarathy (1):
>       table: fix crash in LPM IPv6
> 
> Jay Ding (1):
>       net/bnxt: check invalid VNIC id for firmware
> 
> Jerin Jacob (4):
>       acl: fix build with some arm64 compiler
>       eventdev: fix doxygen comment
>       net/virtio: fix build
>       devtools: fix building kernel component tags
> 
> John Daley (2):
>       net/enic: remove flow count action support
>       net/enic: remove flow locks
> 
> Joyce Kong (2):
>       test/rwlock: benchmark on all available cores
>       test/rwlock: amortize the cost of getting time
> 
> Kalesh AP (15):
>       net/bnxt: fix xstats
>       net/bnxt: fix crash on probe failure
>       net/bnxt: fix enabling/disabling interrupts
>       net/bnxt: check invalid VNIC in cleanup path
>       net/bnxt: fix error handling in port start
>       net/bnxt: fix check of address mapping
>       net/bnxt: fix adding MAC address
>       net/bnxt: fix unconditional wait in link update
>       net/bnxt: fix setting primary MAC address
>       net/bnxt: fix device init error path
>       net/bnxt: reset filters before registering interrupts
>       net/bnxt: fix return values to standard error codes
>       net/bnxt: fix lock release on getting NVM info
>       net/bnxt: fix checking result of HWRM command
>       net/bnxt: reduce verbosity of a message
> 
> Konstantin Ananyev (6):
>       bpf: fix pseudo calls for program loaded from ELF
>       ip_frag: fix IPv6 fragment size calculation
>       bpf: fix check array size
>       bpf: fix validate for function return value
>       examples/ip_frag: fix unknown ethernet type
>       examples/bpf: fix build
> 
> Krzysztof Kanas (1):
>       eal: fix typo in comments
> 
> Lance Richardson (6):
>       net/bnxt: fix endianness in ring macros
>       net/bnxt: fix ring type macro name
>       net/bnxt: fix variable width in endian conversion
>       net/bnxt: fix Tx hang after port stop/start
>       net/bnxt: retry IRQ callback deregistration
>       net/bnxt: fix getting statistics
> 
> Liang Ma (1):
>       distributor: fix livelock on flush
> 
> Liron Himi (1):
>       net/mvneta: fix ierror statistics
> 
> Lu Qiuwen (1):
>       net/fm10k: fix stats crash in multi-process
> 
> Luo Gaoliang (1):
>       kni: fix build on RHEL8
> 
> Maciej Bielski (1):
>       net/ena: fix L4 checksum Tx offload
> 
> Marcin Zapolski (4):
>       examples: fix use of ethdev internal device array
>       examples/ipsec-secgw: fix use of ethdev internal struct
>       examples/ip_frag: fix use of ethdev internal device array
>       examples/ip_frag: fix stale content of ethdev info
> 
> Mariusz Drost (2):
>       net/ixgbe: fix IP type for crypto session
>       examples/ipsec-secgw: fix inline modes
> 
> Mark Spender (1):
>       net/sfc/base: fix shift by more bits than field width
> 
> Matan Azrad (1):
>       net/mlx5: fix device arguments error detection
> 
> Maxime Coquelin (1):
>       net/virtio: fix in-order Rx with segmented packet
> 
> Michael Santana (1):
>       fix off-by-one errors in snprintf
> 
> Michal Krawczyk (2):
>       net/ena: fix assigning NUMA node to IO queue
>       net/ena: fix Rx checksum errors statistics
> 
> Mohsin Mazhar Shaikh (1):
>       net/netvsc: fix xstats id
> 
> Morten Brørup (1):
>       net: fix definition of IPv6 traffic class mask
> 
> Moti Haimovsky (1):
>       net/mlx5: fix crash on null operation
> 
> Naresh Kumar PBS (2):
>       net/bnxt: fix interrupt vector initialization
>       net/bnxt: fix icc build
> 
> Nicolas Dichtel (1):
>       mem: ease init in a docker container
> 
> Nipun Gupta (2):
>       event/dpaa2: fix timeout ticks
>       net/dpaa2: fix multi-segment Tx
> 
> Noa Ezra (1):
>       vhost: fix missing include
> 
> Pavan Nikhilesh (2):
>       app/eventdev: fix order test port creation
>       test/eventdev: fix producer core validity checks
> 
> Peng Huang (1):
>       net/i40e: fix RSS hash update for X722 VF
> 
> Qi Zhang (5):
>       net/i40e: fix Tx threshold setup
>       net/ixgbe: fix Tx threshold setup
>       net/i40e: fix unexpected skip FDIR setup
>       net/avf: fix Rx bytes stats
>       net/avf: fix endless loop
> 
> Qingmin Liu (1):
>       net/bnxt: fix RxQ count if ntuple filtering is disabled
> 
> Rahul Gupta (2):
>       net/bnxt: fix L4 checksum error indication in Rx
>       net/bnxt: fix interrupt rearm logic
> 
> Rasesh Mody (5):
>       net/bnx2x: fix reading VF id
>       net/bnx2x: fix link events polling for SRIOV
>       net/bnx2x: fix fastpath SB allocation for SRIOV
>       doc: add co-existence consideration for bnx2x
>       doc: add co-existence consideration for qede
> 
> Reshma Pattan (1):
>       telemetry: fix memory leak
> 
> Ruifeng Wang (1):
>       doc: fix Linux guide for arm64 cross-compilation
> 
> Saleh Alsouqi (2):
>       net: define IPv4 IHL and VHL
>       app/testpmd: fix MPLS IPv4 encapsulation fields
> 
> Santoshkumar Karanappa Rastapur (1):
>       net/bnxt: fix extended port counter statistics
> 
> Shahed Shaikh (5):
>       net/bnx2x: fix packet drop
>       net/bnx2x: fix interrupt flood
>       net/bnx2x: fix memory leak
>       net/bnx2x: fix link state
>       net/bnx2x: fix supported max Rx/Tx descriptor count
> 
> Somnath Kotur (1):
>       net/bnxt: check for null completion ring doorbell
> 
> Sriharsha Basavapatna (2):
>       net/bnxt: fix Tx batching
>       net/bnxt: optimize Tx batching
> 
> Stephen Hemminger (36):
>       net/atlantic: remove unnecessary cast
>       net/ark: remove unnecessary cast
>       net/axgbe: remove unnecessary cast
>       net/bnxt: remove unnecessary cast
>       net/bonding: remove unnecessary cast
>       net/cxgbe: remove unnecessary cast
>       net/e1000: remove unnecessary cast
>       net/ena: remove unnecessary cast
>       net/enic: remove unnecessary cast
>       net/i40e: remove unnecessary cast
>       net/ixgbe: remove unnecessary cast
>       net/mlx5: remove unnecessary cast
>       net/failsafe: fix reported device info
>       bus/pci: fix TOCTOU for sysfs access
>       net/netvsc: initialize VF spinlock
>       net/i40e: remove empty queue stats mapping set devops
>       net/bnx2x: fix warnings from invalid assert
>       net/qede: fix warnings from invalid assert
>       bus/vmbus: skip non-network devices
>       net/netvsc: fix RSS offload settings
>       net/netvsc: fix xstats for VF device
>       net/netvsc: fix definition of offload values
>       compress/isal: fix use after free
>       kni: fix copy_from_user failure handling
>       kni: fix style
>       net/tap: remove redundant declarations
>       net/af_packet: remove redundant declaration
>       net/vhost: remove redundant declaration
>       net/null: remove redundant declaration
>       net/pcap: remove redundant declaration
>       net/ring: remove redundant declaration
>       net/virtio_user: remove redundant declaration
>       raw/skeleton: remove redundant declaration
>       raw/dpaa2_cmdif: remove redundant declaration
>       net/bnxt: fix Rx interrupt vector
>       net/mlx4: fix crash on info query in secondary process
> 
> Sunil Kumar Kori (1):
>       examples/ip_frag: remove Tx fast free offload flag
> 
> Thierry Herbelot (5):
>       doc: cleanup test removal in armv8 and openssl guides
>       crypto/mvsam: fix typo in comment
>       doc: fix triplicated typo in prog guides
>       doc: fix grammar in prog guides
>       drivers: fix typo in NXP comments
> 
> Thinh Tran (1):
>       raw/skeleton: fix test of attribute set/get
> 
> Thomas Monjalon (6):
>       doc: robustify PDF build
>       doc: fix PDF with greek letter
>       doc: fix typo in EAL guide
>       eal/linux: fix return after alarm registration failure
>       doc: fix PDF build
>       doc: update features supported by mlx
> 
> Tianfei Zhang (2):
>       raw/ifpga/base: fix use of untrusted scalar value
>       raw/ifpga/base: fix physical address info
> 
> Timothy Redaelli (1):
>       usertools: fix refresh binding infos
> 
> Ting Xu (1):
>       net/avf: fix driver crash when enable TSO
> 
> Tiwei Bie (4):
>       net/virtio: fix queue memory leak on error
>       net/virtio: unmap port IO for legacy device
>       net/virtio: unmap device on initialization error
>       net/virtio: fix memory leak in in-order Rx
> 
> Tom Barbette (1):
>       net/mlx5: report imissed statistics
> 
> Tomasz Jozwiak (2):
>       app/crypto-perf: fix display once detection
>       app/crypto-perf: check lcore job failure
> 
> Vamsi Attunuru (1):
>       test/eal: fix --socket-mem option
> 
> Viacheslav Ovsiienko (1):
>       app/testpmd: fix show port info routine
> 
> Wei Zhao (3):
>       app/testpmd: fix offloads config
>       app/testpmd: fix queue offload configuration
>       net/ixgbe: fix RETA size for VF
> 
> Xiao Wang (2):
>       net/fm10k: advertise supported RSS hash function
>       net/fm10k: fix descriptor filling in vector Tx
> 
> Xiao Zhang (6):
>       net/i40e: fix SFP X722 with FW4.16
>       net/e1000: fix buffer overrun while i219 processing DMA
>       net/ixgbe: fix address of first segment
>       net/i40e: fix address of first segment
>       net/avf: fix address of first segment
>       net/fm10k: fix address of first segment
> 
> Xiaolong Ye (5):
>       eal: correct log for alarm error
>       doc: fix typos in flow API guide
>       doc: fix a grammar mistake in rawdev guide
>       net/i40e: fix ethernet flow rule
>       net/i40e: fix flow director rule destroy
> 
> Xiaoyu Min (3):
>       net/mlx5: fix VLAN inner type matching on DR/DV
>       net/mlx5: fix link speed info when link is down
>       net/mlx5: fix crash for empty raw encap data
> 
> Yangchao Zhou (1):
>       kni: fix kernel crash with multi-segments
> 
> Yogev Chaimovich (1):
>       net/vmxnet3: fix uninitialized variable
> 
> Yongseok Koh (1):
>       config: disable armv8 crypto extension
> 
> Yunjian Wang (1):
>       net/ixgbe: fix unexpected link handler
>