From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9533A45D79 for ; Fri, 22 Nov 2024 01:33:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 80B274329E; Fri, 22 Nov 2024 01:33:26 +0100 (CET) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id E45F74026E; Fri, 22 Nov 2024 01:33:23 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.162.254]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Xvbck1Y0Wz10WHK; Fri, 22 Nov 2024 08:31:18 +0800 (CST) Received: from kwepemk500009.china.huawei.com (unknown [7.202.194.94]) by mail.maildlp.com (Postfix) with ESMTPS id CB433180106; Fri, 22 Nov 2024 08:33:21 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by kwepemk500009.china.huawei.com (7.202.194.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 22 Nov 2024 08:33:21 +0800 Message-ID: <5ba4136b-6910-4ab4-b9f8-3bfeaa64cd9b@huawei.com> Date: Fri, 22 Nov 2024 08:33:20 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 9/9] app/test-pmd: avoid potential outside of array reference To: Stephen Hemminger , CC: , , Bruce Richardson , Ori Kam , Aman Singh References: <20241114001403.147609-1-stephen@networkplumber.org> <20241121182443.68025-1-stephen@networkplumber.org> <20241121182443.68025-10-stephen@networkplumber.org> Content-Language: en-US From: fengchengwen In-Reply-To: <20241121182443.68025-10-stephen@networkplumber.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemk500009.china.huawei.com (7.202.194.94) X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Acked-by: Chengwen Feng On 2024/11/22 2:23, Stephen Hemminger wrote: > The order of comparison is wrong, and potentially allows > referencing past the array. > > Link: https://pvs-studio.com/en/blog/posts/cpp/1179/ > > Fixes: 3e3edab530a1 ("ethdev: add flow quota") > Cc: getelson@nvidia.com > Cc: stable@dpdk.org > > Signed-off-by: Stephen Hemminger > Acked-by: Bruce Richardson > --- > app/test-pmd/cmdline_flow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > index 1e4f2ebc55..9e4fc2d95d 100644 > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -12892,7 +12892,7 @@ comp_names_to_index(struct context *ctx, const struct token *token, > RTE_SET_USED(token); > if (!buf) > return names_size; > - if (names[ent] && ent < names_size) > + if (ent < names_size && names[ent] != NULL) > return rte_strscpy(buf, names[ent], size); > return -1; >