From: Kevin Traynor <ktraynor@redhat.com>
To: Ciara Power <ciara.power@intel.com>, stable@dpdk.org
Subject: Re: [PATCH 21.11] crypto/qat: fix NULL algorithm digest placement
Date: Thu, 23 Nov 2023 10:47:43 +0000 [thread overview]
Message-ID: <5c86cf16-635c-2064-5823-22196a3be059@redhat.com> (raw)
In-Reply-To: <20231109142852.4052616-1-ciara.power@intel.com>
On 09/11/2023 14:28, Ciara Power wrote:
> [upstream commit 8b4618a7b453dec02ca8ea40871fb124100f98f4]
>
> QAT HW generates bytes of 0x00 digest, even when a digest of len 0 is
> requested for NULL. This caused test failures when the test vector had
> digest len 0, as the buffer has unexpected changed bytes.
>
> By placing the digest into the cookie for NULL authentication,
> the buffer remains unchanged as expected, and the digest
> is placed to the side, as it won't be used anyway.
>
> Fixes: db0e952a5c01 ("crypto/qat: add NULL capability")
>
> Signed-off-by: Ciara Power<ciara.power@intel.com>
> ---
> drivers/crypto/qat/qat_sym.c | 6 +++---
> drivers/crypto/qat/qat_sym.h | 2 ++
> drivers/crypto/qat/qat_sym_pmd.c | 5 +++++
> 3 files changed, 10 insertions(+), 3 deletions(-)
Applied to 21.11. Thanks for backporting.
prev parent reply other threads:[~2023-11-23 10:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 14:28 Ciara Power
2023-11-23 10:47 ` Kevin Traynor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c86cf16-635c-2064-5823-22196a3be059@redhat.com \
--to=ktraynor@redhat.com \
--cc=ciara.power@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).