From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 095E9433A7 for ; Thu, 23 Nov 2023 11:47:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 03D0D402A6; Thu, 23 Nov 2023 11:47:49 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 5289D4026B for ; Thu, 23 Nov 2023 11:47:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700736466; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hd9xrRNmvLOyk2ZrmRIK4C2F/bSHKORFbkRY2Hi4feI=; b=KJ13gDb1iI+4XpRcnGrCyq6bt7f7yAJjyZwq+Vb1w8Sg0LK18/KeBV8pXdsbVaPKhP2hAf h1nFz+Q5vkcJ8HTNvWOS3maLroCdkfY9PissAbaiN6wrftctZaQrvwNSdo0aVZ3daZst1e iDt3t7yvPaYby4i/K7BhZOErbcuwLgc= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-561-UnjWimdzPmq-4BA6vv-Urg-1; Thu, 23 Nov 2023 05:47:45 -0500 X-MC-Unique: UnjWimdzPmq-4BA6vv-Urg-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-33174d082b7so402368f8f.0 for ; Thu, 23 Nov 2023 02:47:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700736464; x=1701341264; h=content-transfer-encoding:in-reply-to:subject:content-language :references:to:from:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Hd9xrRNmvLOyk2ZrmRIK4C2F/bSHKORFbkRY2Hi4feI=; b=QMSG54I3NT4C2RLBBenXy7AsE4Wzg6pP5Q1lzFxINhAFBpqJHZSOszTs9v0zgIUtzx 175O6l5i+W236zEqY/8sxIckyegi/jFL/VSdlFLzEeDcAC/rqDYt6vASONuVNlAfqVq9 i0C7iA6U5ouy+Jz43EMd5uJ3dTSYGxau2tumMmRMUO+EjOT5JPJKaDWZAzuiL6FMd2Er 3mJiuqWoSKgbJxchoNP3gx51sfth19QL6K8z1puDVuOoTC1UHPYsz3KASmcxFenQ987f UAkZUnBntynlZWFvWW24/+lZwUpSS/rR2G34lIwxuDepVEmi6oGPlcdJ2VHqnZJZIwmD fW7Q== X-Gm-Message-State: AOJu0Yx+sInYUxbpvmTn4AmrTFcW/IAEB2EKyVTjI3nkikeHKhmJFvQ0 OwtsxCeBLYkS3Xr3o82ZfbRetHJelGXxbcOoxsophH9wzOr6lEycvmo0NW66vZxLzoxah+FeoKF 6fa8RXP8= X-Received: by 2002:a5d:6484:0:b0:332:d288:30de with SMTP id o4-20020a5d6484000000b00332d28830demr3480432wri.6.1700736464426; Thu, 23 Nov 2023 02:47:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IE/TsiabpnyKOmfq0JCawGkv12boroL6+UcgYkOKojBi4yI3QMUgQEW76iTzpGeHI3rhRZTbA== X-Received: by 2002:a5d:6484:0:b0:332:d288:30de with SMTP id o4-20020a5d6484000000b00332d28830demr3480424wri.6.1700736464153; Thu, 23 Nov 2023 02:47:44 -0800 (PST) Received: from [192.168.0.36] ([78.16.130.39]) by smtp.gmail.com with ESMTPSA id x12-20020adff64c000000b0032dcb08bf94sm1310652wrp.60.2023.11.23.02.47.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Nov 2023 02:47:43 -0800 (PST) Message-ID: <5c86cf16-635c-2064-5823-22196a3be059@redhat.com> Date: Thu, 23 Nov 2023 10:47:43 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 From: Kevin Traynor To: Ciara Power , stable@dpdk.org References: <20231109142852.4052616-1-ciara.power@intel.com> Subject: Re: [PATCH 21.11] crypto/qat: fix NULL algorithm digest placement In-Reply-To: <20231109142852.4052616-1-ciara.power@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 09/11/2023 14:28, Ciara Power wrote: > [upstream commit 8b4618a7b453dec02ca8ea40871fb124100f98f4] > > QAT HW generates bytes of 0x00 digest, even when a digest of len 0 is > requested for NULL. This caused test failures when the test vector had > digest len 0, as the buffer has unexpected changed bytes. > > By placing the digest into the cookie for NULL authentication, > the buffer remains unchanged as expected, and the digest > is placed to the side, as it won't be used anyway. > > Fixes: db0e952a5c01 ("crypto/qat: add NULL capability") > > Signed-off-by: Ciara Power > --- > drivers/crypto/qat/qat_sym.c | 6 +++--- > drivers/crypto/qat/qat_sym.h | 2 ++ > drivers/crypto/qat/qat_sym_pmd.c | 5 +++++ > 3 files changed, 10 insertions(+), 3 deletions(-) Applied to 21.11. Thanks for backporting.