From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f170.google.com (mail-wr0-f170.google.com [209.85.128.170]) by dpdk.org (Postfix) with ESMTP id A624D2BB1 for ; Wed, 1 Mar 2017 13:38:08 +0100 (CET) Received: by mail-wr0-f170.google.com with SMTP id u48so29244349wrc.0 for ; Wed, 01 Mar 2017 04:38:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=KOPJpRndqIKPtaPiy4bMOy3+kLhish44XBpgEMOQ8HE=; b=obMMDQa+DOL32MPoOrJeCSRGJ8QngwcrQaLNvyb06WtcFdFvz3Wo8YZG47RuvqXqoQ RBDBKwGOnGW2VE3rKM7fUF5r1mvoVYnh6wtcgaMS/LzotwzSStJtiUDyoYZRJvuXeu/J JnQluBh54urxt1LajlciGpSngbETW7a0HVzBd7SqUlAAya2tubfwPdPRj3rGI/a42qWr tAoX9HtbhBdK65t8+jIKCZjP8vIkZ6fgSLj6oKC3eS+DDNkzrpT9DUppw73Wp1U8JQX6 85GCbp+wQnsGaOl+CASOprH1+wZpbCCit0HNj9Ycw/mfDrmuh+4zkxEOsL59CrOqtqyM zgFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=KOPJpRndqIKPtaPiy4bMOy3+kLhish44XBpgEMOQ8HE=; b=rkWDFJptfD6cEWaqc1LXAvTfhaJI4xWgSaKoHmk2eAPxZnCmkTNCdVRhdva7jmcfAy ToWa5vDaSWl3NbFpydeX5wN7voP8Bi7r+tLzlqKCNTTTtM2li4lYsIhJtlpliXt1Kelp qsXdub+TEb/xlDKw3AfI1L7emMyYzgXu/rIj9vg7wcrjnl6chjog9ABhJY/otrZoj3Tf NegiBCp7ykq/HUelGQjkwSw5LVYmoRnv8aZdRXoBtyxhH6ZQiGIToPQj4E2g3eqL/Qhh bd4x/KyagpYYzEUf49p+6a/NgusZi4X28tbbZ206ObdZ0qkYjtod1QPNgEHzPVJpxIWv eU7g== X-Gm-Message-State: AMke39l2dlXXdclAS9S4ESsvo0EM31f4DDm9OHpoHnddtiWmbRQ80Cr9TSJztcKDNHEgxZQ4 X-Received: by 10.223.128.3 with SMTP id 3mr7141660wrk.58.1488371888407; Wed, 01 Mar 2017 04:38:08 -0800 (PST) Received: from ping.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id g127sm2128053wmd.30.2017.03.01.04.38.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 01 Mar 2017 04:38:07 -0800 (PST) From: Nelio Laranjeiro To: Cc: Adrien Mazarguil , stable@dpdk.org Date: Wed, 1 Mar 2017 13:37:39 +0100 Message-Id: <5e6c21620fe267815f565186168f5fd500f3b460.1488364873.git.nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-stable] [PATCH 2/9] net/mlx5: fix resources free in the right function X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 12:38:08 -0000 ibv_attr should be freed in the function which allocates the memory. Fixes: 2097d0d1e2cc ("net/mlx5: support basic flow items and actions") CC: stable@dpdk.org Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_flow.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 6765a77..0712926 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -974,7 +974,6 @@ priv_flow_create_action_queue(struct priv *priv, ibv_exp_destroy_wq(rte_flow->wq); if (!rte_flow->rxq && rte_flow->cq) ibv_destroy_cq(rte_flow->cq); - rte_free(rte_flow->ibv_attr); rte_free(rte_flow); return NULL; } @@ -1068,6 +1067,8 @@ priv_flow_create(struct priv *priv, } rte_flow = priv_flow_create_action_queue(priv, flow.ibv_attr, &action, error); + if (!rte_flow) + goto exit; return rte_flow; exit: rte_free(flow.ibv_attr); -- 2.1.4