From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76F2048B60 for ; Fri, 21 Nov 2025 15:16:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 50DD740267; Fri, 21 Nov 2025 15:16:35 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 5049240267 for ; Fri, 21 Nov 2025 15:16:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763734593; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=AMwEnlJKB4KOsIJnxYNMGkg98fGiQGQAK5sn2XvD/Rc=; b=VT3TUol6dhVof1cmgpnTfZr9uVt7eLhi65jwgqw5jZdXkFb+E5+W2EfHwglZVn93+PdEGh QM6izBhSEs9mF0Wjt2pLkizZVEOgoynyt0JqlN636Rjay4RbRpPVJd/IoYgm759zGpoy0d iha/w3DLqjzy72ax8Bk0Buc4aNe4QHA= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-184-KT07ug54N_WqWztB8tM5LQ-1; Fri, 21 Nov 2025 09:16:32 -0500 X-MC-Unique: KT07ug54N_WqWztB8tM5LQ-1 X-Mimecast-MFC-AGG-ID: KT07ug54N_WqWztB8tM5LQ_1763734591 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-429c5da68e5so1281497f8f.1 for ; Fri, 21 Nov 2025 06:16:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763734591; x=1764339391; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AMwEnlJKB4KOsIJnxYNMGkg98fGiQGQAK5sn2XvD/Rc=; b=KBXIn9VKnwq+EgdwkAehIGF7BaDnXdyI9LRt5QFWJUSdPXYwaO08q/oriH50GL8GLL UnZ2wCxmb/0/5pzCmBQpqQeSJu96ZT9arC2cyQL4L1rx5S07ilcQCQIH0jYWwv47I4bk 8/AEeqyr9VjmhZL+ruv8gKYHuwo77OcGBQ+l7ao2PTmQ63e1XslIG6nrOGrHFiWUli1C Poc60CrxeiYXSP/YvsrSbshXlOsafTezijU6oPdROicQ7LcKZwZRzLB7V0AmwCd5wLzH /4UhxjTHTyNtXnud7d32ribQOQVKyGpZq8yfZVqsV0aVpL0qq1P5vLxnN09WXslc3TOV YvBA== X-Forwarded-Encrypted: i=1; AJvYcCVS3Xhg3Qb3wLaO4XLGAIdkjCAZdRzwtlKQs4UxeGFtkm0g6drc4bgHTDqmPlcd9Qwn4O3rb+E=@dpdk.org X-Gm-Message-State: AOJu0Yw5tzx4i5/CIxqLgi0OqfWoGeEnNEbIyJ4jY8HNYNeEcnVKlHU2 WhPEGfZGDITl9d8XQGfHwIAX0aqb7bbdI0yZDbFh/2csR3z/THpVHafytR3SFLZY75nrFWzUzEA qE/V1eYqWogNkiHFZ7LwloLYOL+ndXr8yC3ojHlC1w4iMXHDs X-Gm-Gg: ASbGncvTRdW2jpsVf6Wvw6ZvJ1Zq+AxZdFZgqqcZqp8Bfy4qGka+KwqOe2e8MfUZyNc MnB0TE9LZPJeFKGpExtRJCYYxRn6fAwnd7BN+X0aBA4YBnT4qLRO6sDG9+dvWXOSYD3liYYGzZy Thwfiuimd7pHcinwvkQxKHaXg1hwm5/y3072vmV1N/dKcELVvxavv9DvwiT0iJEiXuCjlnW8svd q7vActExj15Gs5JBTmcLEOqolnqVfm4Q1yCT2ZsX20N5gim7JESeNj45pSay8Fw2aT8jhoGq7qz MkTPam0IPu2BdD7jnPnGHrzfqzZJTU6j+KFIXBWZCFiaLdKIK1/ubvou/GJ+h2ni/gup0e4YKIu Q+MRtE2xBCr7x X-Received: by 2002:a05:6000:26c6:b0:429:cf03:8b2e with SMTP id ffacd0b85a97d-42cc135db4fmr2667693f8f.13.1763734590887; Fri, 21 Nov 2025 06:16:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IFY3r2E4U3s+muJtbeqcb75AC4G922XYRQviNLTU2VqguwCRoFfVeYhhvTc4wbL7Firi0sLEg== X-Received: by 2002:a05:6000:26c6:b0:429:cf03:8b2e with SMTP id ffacd0b85a97d-42cc135db4fmr2667658f8f.13.1763734590435; Fri, 21 Nov 2025 06:16:30 -0800 (PST) Received: from [192.168.0.56] ([78.16.128.110]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f34ff3sm11840677f8f.16.2025.11.21.06.16.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Nov 2025 06:16:29 -0800 (PST) Message-ID: <5e81447a-0edc-4ec7-893b-39de52dc3ccc@redhat.com> Date: Fri, 21 Nov 2025 14:16:28 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 22.11] net/mlx5: fix control flow leakage for external SQ To: Viacheslav Ovsiienko , stable@dpdk.org Cc: bluca@debian.org, xuemingl@nvidia.com, Dariusz Sosnowski References: <20251118165158.1315992-1-viacheslavo@nvidia.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= xsFNBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABzSNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPsLBjgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71zsFNBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABwsF2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= In-Reply-To: <20251118165158.1315992-1-viacheslavo@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: nET7q3MsrIhOM7nveuZ2KZp7rhplPzkn4tIyY8jPWKY_1763734591 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 18/11/2025 16:51, Viacheslav Ovsiienko wrote: > [ upstream commit 3bf9f0f9f0beb8dcd4f3b316c3216a87bc9ab49f ] > > There is the private API rte_pmd_mlx5_external_sq_enable(), > that allows application to create the Send Queue (SQ) on its own > and then enable this queue usage as "external SQ". > > On this enabling call some implicit flows are created to provide > compliant SQs behavior - copy metadata register, forward queue > originated packet to correct VF, etc. > > These implicit flows are marked as "external" ones, and there is > no cleanup on device start and stop for this kind of flows. > Also, PMD has no knowledge if external SQ is still in use by > application and implicit cleanup can not be performed. > > As a result, on multiple device start/stop cycles application > re-creates and re-enables many external SQs, causing implicit > flow tables overflow. > > To resolve this issue the rte_pmd_mlx5_external_sq_disable() > API is provided, that allows to application to notify PMD > the external SQ is not in usage anymore and related implicit > flows can be dismissed. > > Fixes: 26e1eaf2dac4 ("net/mlx5: support device control for E-Switch default rule") > Cc: stable@dpdk.org > > Signed-off-by: Viacheslav Ovsiienko > Acked-by: Dariusz Sosnowski > --- > drivers/net/mlx5/mlx5_flow.h | 12 ++-- > drivers/net/mlx5/mlx5_flow_hw.c | 106 +++++++++++++++++++++++++++++++- > drivers/net/mlx5/mlx5_trigger.c | 2 +- > drivers/net/mlx5/mlx5_txq.c | 54 ++++++++++++++-- > drivers/net/mlx5/rte_pmd_mlx5.h | 18 ++++++ > drivers/net/mlx5/version.map | 1 + > 6 files changed, 181 insertions(+), 12 deletions(-) > Hi Slava, I applied this to 24.11 branch with a small rebase, but it's causing build errors, so I think it will need a dedicated 24.11 backport. thanks, Kevin.