From: Shachar Beiser <shacharbe@mellanox.com>
To: dev@dpdk.org
Cc: Shachar Beiser <shacharbe@mellanox.com>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Nelio Laranjeiro <nelio.laranjeiro@6wind.com>,
stable@dpdk.org
Subject: [dpdk-stable] [PATCH] net/mlx5: fix verification of device context
Date: Wed, 26 Jul 2017 05:43:24 +0000 [thread overview]
Message-ID: <5ec0604196fb087a42fa75e6ddc2a04aab293593.1501047767.git.shacharbe@mellanox.com> (raw)
Get interface name function lacks verification of device context.
It might lead to segmentation fault when trying to query the name
after the device is closed.fixing it by adding the missing verification
Fixes: cd89f22a1e9770 ("net/mlx5: remove unused interface name query")
Cc: stable@dpdk.org
Signed-off-by: Shachar Beiser <shacharbe@mellanox.com>
---
drivers/net/mlx5/mlx5_ethdev.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c
index b70b7b9..6e67461 100644
--- a/drivers/net/mlx5/mlx5_ethdev.c
+++ b/drivers/net/mlx5/mlx5_ethdev.c
@@ -173,6 +173,10 @@ struct priv *
char match[IF_NAMESIZE] = "";
{
+ if (priv->ctx == NULL) {
+ DEBUG("The device is closed, cannot query interface name ");
+ return -1;
+ }
MKSTR(path, "%s/device/net", priv->ctx->device->ibdev_path);
dir = opendir(path);
--
1.8.3.1
next reply other threads:[~2017-07-26 5:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-26 5:43 Shachar Beiser [this message]
2017-07-26 9:06 ` Adrien Mazarguil
2017-07-26 9:21 ` Shachar Beiser
[not found] ` <cover.1501075226.git.gaetan.rivet@6wind.com>
2017-07-26 13:30 ` [dpdk-stable] [PATCH 1/6] ethdev: fix device state on detach Gaetan Rivet
[not found] ` <cover.1501076035.git.gaetan.rivet@6wind.com>
2017-07-26 13:35 ` [dpdk-stable] [PATCH v2 " Gaetan Rivet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ec0604196fb087a42fa75e6ddc2a04aab293593.1501047767.git.shacharbe@mellanox.com \
--to=shacharbe@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).