From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id AF4D31B00C;
 Sat, 16 Dec 2017 03:31:00 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 15 Dec 2017 18:30:59 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.45,407,1508828400"; d="scan'208";a="12265015"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.53])
 ([10.241.225.53])
 by FMSMGA003.fm.intel.com with ESMTP; 15 Dec 2017 18:30:58 -0800
To: Olivier Matz <olivier.matz@6wind.com>, dev@dpdk.org,
 Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: stable@dpdk.org
References: <20171214142825.28176-1-olivier.matz@6wind.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <5f0b6b54-9813-b03f-47ed-c10e49cb3d44@intel.com>
Date: Fri, 15 Dec 2017 18:30:58 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <20171214142825.28176-1-olivier.matz@6wind.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-stable] [PATCH 1/2] net/bnxt: fix headroom initialization
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Dec 2017 02:31:01 -0000

On 12/14/2017 6:28 AM, Olivier Matz wrote:
> When allocating a new mbuf for Rx, the value of m->data_off should not
> be reset to its default value (RTE_PKTMBUF_HEADROOM), instead of reusing
> the previous undefined value, which could cause the packet to have a too
> small or too high headroom.
> 
> Fixes: 2eb53b134aae ("net/bnxt: add initial Rx code")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
>  drivers/net/bnxt/bnxt_rxr.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c
> index 188df362e..3fff4d437 100644
> --- a/drivers/net/bnxt/bnxt_rxr.c
> +++ b/drivers/net/bnxt/bnxt_rxr.c
> @@ -75,7 +75,7 @@ static inline int bnxt_alloc_rx_data(struct bnxt_rx_queue *rxq,
>  
>  	rx_buf->mbuf = data;
>  
> -	rxbd->addr = rte_cpu_to_le_64(RTE_MBUF_DATA_DMA_ADDR(rx_buf->mbuf));
> +	rxbd->addr = rte_cpu_to_le_64(rte_mbuf_data_dma_addr_default(data));

Hi Olivier,

Using deprecated rte_mbuf_data_dma_addr_default() breaks build for this commit.

What do you think using directly rte_mbuf_data_iova_default() in this patch?

Thanks,
ferruh