* [dpdk-stable] [PATCH] devtools: fix symbol check when adding experimental section [not found] <1543978226-23480-1-git-send-email-gfree.wind@vip.163.com> @ 2018-12-05 2:50 ` gfree.wind 2018-12-05 3:46 ` [dpdk-stable] [dpdk-dev] " Gao Feng 0 siblings, 1 reply; 2+ messages in thread From: gfree.wind @ 2018-12-05 2:50 UTC (permalink / raw) To: dev; +Cc: David Marchand, stable From: David Marchand <david.marchand@redhat.com> The incriminated commit did relax the condition to catch all sections but dropped the + removal which can trigger false detection of the special EXPERIMENTAL section when adding symbols and the section in the same patch. Fixes: 7281cf520f89 ("devtools: relax rule for identifying symbol section") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com> Acked-by: Neil Horman <nhorman@tuxdriver.com> --- devtools/check-symbol-change.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh index 4b8d9f3..020da7e 100755 --- a/devtools/check-symbol-change.sh +++ b/devtools/check-symbol-change.sh @@ -31,6 +31,7 @@ build_map_changes() # Triggering this rule sets in_sec to 1, which actives the # symbol rule below /^.*{/ { + gsub("+", ""); if (in_map == 1) { sec=$(NF-1); in_sec=1; } -- 2.7.4 ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH] devtools: fix symbol check when adding experimental section 2018-12-05 2:50 ` [dpdk-stable] [PATCH] devtools: fix symbol check when adding experimental section gfree.wind @ 2018-12-05 3:46 ` Gao Feng 0 siblings, 0 replies; 2+ messages in thread From: Gao Feng @ 2018-12-05 3:46 UTC (permalink / raw) To: 我; +Cc: dev, David Marchand, stable Sorry for the noise. Please ignore this reply. It is caused by wrong command. Best Regards Feng At 2018-12-05 10:50:26, "" <gfree.wind@vip.163.com> wrote: >From: David Marchand <david.marchand@redhat.com> > >The incriminated commit did relax the condition to catch all sections >but dropped the + removal which can trigger false detection of the >special EXPERIMENTAL section when adding symbols and the section in the >same patch. > >Fixes: 7281cf520f89 ("devtools: relax rule for identifying symbol section") >Cc: stable@dpdk.org > >Signed-off-by: David Marchand <david.marchand@redhat.com> >Acked-by: Neil Horman <nhorman@tuxdriver.com> >--- > devtools/check-symbol-change.sh | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh >index 4b8d9f3..020da7e 100755 >--- a/devtools/check-symbol-change.sh >+++ b/devtools/check-symbol-change.sh >@@ -31,6 +31,7 @@ build_map_changes() > # Triggering this rule sets in_sec to 1, which actives the > # symbol rule below > /^.*{/ { >+ gsub("+", ""); > if (in_map == 1) { > sec=$(NF-1); in_sec=1; > } >-- >2.7.4 > > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-05 3:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1543978226-23480-1-git-send-email-gfree.wind@vip.163.com>
2018-12-05 2:50 ` [dpdk-stable] [PATCH] devtools: fix symbol check when adding experimental section gfree.wind
2018-12-05 3:46 ` [dpdk-stable] [dpdk-dev] " Gao Feng
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).