* [dpdk-stable] [PATCH] net/ixgbe: fix adding multiple mirror type in a rule
@ 2017-09-05 9:16 Wei Dai
2017-09-08 0:23 ` Wu, Jingjing
0 siblings, 1 reply; 3+ messages in thread
From: Wei Dai @ 2017-09-05 9:16 UTC (permalink / raw)
To: wenzhuo.lu, konstantin.ananyev, jingjing.wu; +Cc: dev, Wei Dai, stable
mirror rule_type can be a bit OR result of multiple mirror type of
a rule. Before the commit which introduced this issue, the code
supported adding multiple mirror type in a rule.
Fixes: 7ba29a76b196 ("ethdev: rename and extend the mirror type")
Cc: stable@dpdk.org
Signed-off-by: Wei Dai <wei.dai@intel.com>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 22171d8..858230d 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -5450,13 +5450,13 @@ ixgbe_mirror_rule_set(struct rte_eth_dev *dev,
IXGBE_WRITE_REG(hw, IXGBE_MRCTL(rule_id), mr_ctl);
/* write pool mirrror control register */
- if (mirror_conf->rule_type == ETH_MIRROR_VIRTUAL_POOL_UP) {
+ if (mirror_conf->rule_type & ETH_MIRROR_VIRTUAL_POOL_UP) {
IXGBE_WRITE_REG(hw, IXGBE_VMRVM(rule_id), mp_lsb);
IXGBE_WRITE_REG(hw, IXGBE_VMRVM(rule_id + rule_mr_offset),
mp_msb);
}
/* write VLAN mirrror control register */
- if (mirror_conf->rule_type == ETH_MIRROR_VLAN) {
+ if (mirror_conf->rule_type & ETH_MIRROR_VLAN) {
IXGBE_WRITE_REG(hw, IXGBE_VMRVLAN(rule_id), mv_lsb);
IXGBE_WRITE_REG(hw, IXGBE_VMRVLAN(rule_id + rule_mr_offset),
mv_msb);
--
2.7.5
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-stable] [PATCH] net/ixgbe: fix adding multiple mirror type in a rule
2017-09-05 9:16 [dpdk-stable] [PATCH] net/ixgbe: fix adding multiple mirror type in a rule Wei Dai
@ 2017-09-08 0:23 ` Wu, Jingjing
2017-09-08 9:36 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Wu, Jingjing @ 2017-09-08 0:23 UTC (permalink / raw)
To: Dai, Wei, Lu, Wenzhuo, Ananyev, Konstantin; +Cc: dev, stable
> -----Original Message-----
> From: Dai, Wei
> Sent: Tuesday, September 5, 2017 5:17 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; Dai, Wei <wei.dai@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/ixgbe: fix adding multiple mirror type in a rule
>
> mirror rule_type can be a bit OR result of multiple mirror type of a rule. Before
> the commit which introduced this issue, the code supported adding multiple
> mirror type in a rule.
>
> Fixes: 7ba29a76b196 ("ethdev: rename and extend the mirror type")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wei Dai <wei.dai@intel.com>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-stable] [PATCH] net/ixgbe: fix adding multiple mirror type in a rule
2017-09-08 0:23 ` Wu, Jingjing
@ 2017-09-08 9:36 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-09-08 9:36 UTC (permalink / raw)
To: Wu, Jingjing, Dai, Wei, Lu, Wenzhuo, Ananyev, Konstantin; +Cc: dev, stable
On 9/8/2017 1:23 AM, Wu, Jingjing wrote:
>
>
>> -----Original Message-----
>> From: Dai, Wei
>> Sent: Tuesday, September 5, 2017 5:17 PM
>> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin
>> <konstantin.ananyev@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
>> Cc: dev@dpdk.org; Dai, Wei <wei.dai@intel.com>; stable@dpdk.org
>> Subject: [PATCH] net/ixgbe: fix adding multiple mirror type in a rule
>>
>> mirror rule_type can be a bit OR result of multiple mirror type of a rule. Before
>> the commit which introduced this issue, the code supported adding multiple
>> mirror type in a rule.
>>
>> Fixes: 7ba29a76b196 ("ethdev: rename and extend the mirror type")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Wei Dai <wei.dai@intel.com>
> Acked-by: Jingjing Wu <jingjing.wu@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-08 9:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-05 9:16 [dpdk-stable] [PATCH] net/ixgbe: fix adding multiple mirror type in a rule Wei Dai
2017-09-08 0:23 ` Wu, Jingjing
2017-09-08 9:36 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).