From: "Xueming(Steven) Li" <xuemingl@nvidia.com>
To: "beilei.xing@intel.com" <beilei.xing@intel.com>,
"chenqiming_huawei@163.com" <chenqiming_huawei@163.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH 20.11] net/i40e: fix vf resource leakage problem
Date: Mon, 8 Nov 2021 11:44:53 +0000 [thread overview]
Message-ID: <5f81dab5903bfc2288ac0f636257c368b88e7c68.camel@nvidia.com> (raw)
In-Reply-To: <MN2PR11MB38074F0E2C10E7F7317F2F23F7D49@MN2PR11MB3807.namprd11.prod.outlook.com>
On Wed, 2021-09-08 at 03:53 +0000, Xing, Beilei wrote:
>
> > -----Original Message-----
> > From: Qiming Chen <chenqiming_huawei@163.com>
> > Sent: Monday, September 6, 2021 3:12 PM
> > To: stable@dpdk.org
> > Cc: Xing, Beilei <beilei.xing@intel.com>; Qiming Chen
> > <chenqiming_huawei@163.com>
> > Subject: [PATCH 20.11] net/i40e: fix vf resource leakage problem
> Please also refine the title.
>
> >
> > In the i40evf_dev_init function, when the MAC memory alloc fails, the
> > previously initialized vf resource is not released, resulting in leakage.
> > The patch calls the i40evf_uninit_vf function in the abnormal branch to
> > release resources.
> >
> > Fixes: 5c9222058df7 ("i40e: move to drivers/net/")
> The fix commit should be " i40e: new poll mode driver".
>
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Qiming Chen <chenqiming_huawei@163.com>
> > ---
> > drivers/net/i40e/i40e_ethdev_vf.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
> > b/drivers/net/i40e/i40e_ethdev_vf.c
> > index 003d41373b..f64db72e9a 100644
> > --- a/drivers/net/i40e/i40e_ethdev_vf.c
> > +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> > @@ -1622,6 +1622,7 @@ i40evf_dev_init(struct rte_eth_dev *eth_dev)
> > PMD_INIT_LOG(ERR, "Failed to allocate %d bytes needed to"
> > " store MAC addresses",
> > RTE_ETHER_ADDR_LEN *
> > I40E_NUM_MACADDR_MAX);
> > + (void)i40evf_uninit_vf(eth_dev);
> > return -ENOMEM;
> > }
> > rte_ether_addr_copy((struct rte_ether_addr *)hw->mac.addr,
> > --
> > 2.30.1.windows.1
>
Hi Qiming,
To catch up v20.11.4, could you address Beilei's comments and send v2?
prev parent reply other threads:[~2021-11-08 11:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 7:11 Qiming Chen
2021-09-08 3:53 ` Xing, Beilei
2021-11-08 11:44 ` Xueming(Steven) Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f81dab5903bfc2288ac0f636257c368b88e7c68.camel@nvidia.com \
--to=xuemingl@nvidia.com \
--cc=beilei.xing@intel.com \
--cc=chenqiming_huawei@163.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).