From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B420641D4B for ; Thu, 23 Feb 2023 09:08:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AF1AE430C1; Thu, 23 Feb 2023 09:08:30 +0100 (CET) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 781C94021F; Thu, 23 Feb 2023 09:08:27 +0100 (CET) Received: from kwepemm600004.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4PMlxz017KzrS6R; Thu, 23 Feb 2023 16:07:50 +0800 (CST) Received: from [10.67.103.231] (10.67.103.231) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Thu, 23 Feb 2023 16:08:23 +0800 Message-ID: <5f8d0435-def4-b874-b9ea-4a8a3c0191b5@huawei.com> Date: Thu, 23 Feb 2023 16:08:22 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v3] app/testpmd: fix secondary process not forwarding To: Shiyang He , CC: , , Yuying Zhang , Aman Singh , Anatoly Burakov , Matan Azrad , Dmitry Kozlyuk References: <20221230075554.25244-1-shiyangx.he@intel.com> <20230223144106.707999-1-shiyangx.he@intel.com> From: "lihuisong (C)" In-Reply-To: <20230223144106.707999-1-shiyangx.he@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.231] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm600004.china.huawei.com (7.193.23.242) X-CFilter-Loop: Reflected X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org 在 2023/2/23 22:41, Shiyang He 写道: > Under multi-process scenario, the secondary process gets queue state > from the wrong location (the global variable 'ports'). Therefore, the > secondary process can not forward since "stream_init" is not called. > > This commit fixes the issue by calling 'rte_eth_rx/tx_queue_info_get' > to get queue state from shared memory. > > Fixes: 3c4426db54fc ("app/testpmd: do not poll stopped queues") > Cc: stable@dpdk.org > > Signed-off-by: Shiyang He > Acked-by: Yuying Zhang > > v3: Add return value description > --- > app/test-pmd/testpmd.c | 45 ++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 43 insertions(+), 2 deletions(-) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index 0c14325b8d..a050472aea 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -2418,9 +2418,50 @@ start_packet_forwarding(int with_tx_first) > if (!pkt_fwd_shared_rxq_check()) > return; > > - if (stream_init != NULL) > - for (i = 0; i < cur_fwd_config.nb_fwd_streams; i++) > + if (stream_init != NULL) { > + for (i = 0; i < cur_fwd_config.nb_fwd_streams; i++) { > + if (rte_eal_process_type() == RTE_PROC_SECONDARY) { > + struct fwd_stream *fs = fwd_streams[i]; > + struct rte_eth_rxq_info rx_qinfo; > + struct rte_eth_txq_info tx_qinfo; > + int32_t rc; > + rc = rte_eth_rx_queue_info_get(fs->rx_port, > + fs->rx_queue, &rx_qinfo); > + if (rc == 0) { > + ports[fs->rx_port].rxq[fs->rx_queue].state = > + rx_qinfo.queue_state; > + } else if (rc == -ENOTSUP) { > + /* Set the rxq state to RTE_ETH_QUEUE_STATE_STARTED > + * to ensure that the PMDs do not implement > + * rte_eth_rx_queue_info_get can forward. > + */ > + ports[fs->rx_port].rxq[fs->rx_queue].state = > + RTE_ETH_QUEUE_STATE_STARTED; > + } else { > + TESTPMD_LOG(WARNING, > + "Failed to get rx queue info\n"); > + } > + > + rc = rte_eth_tx_queue_info_get(fs->tx_port, > + fs->tx_queue, &tx_qinfo); > + if (rc == 0) { > + ports[fs->tx_port].txq[fs->tx_queue].state = > + tx_qinfo.queue_state; > + } else if (rc == -ENOTSUP) { > + /* Set the txq state to RTE_ETH_QUEUE_STATE_STARTED > + * to ensure that the PMDs do not implement > + * rte_eth_tx_queue_info_get can forward. > + */ > + ports[fs->tx_port].txq[fs->tx_queue].state = > + RTE_ETH_QUEUE_STATE_STARTED; > + } else { > + TESTPMD_LOG(WARNING, > + "Failed to get tx queue info\n"); > + } > + } This code is a little long after adding some comments.😂 It is a full code block. Let's extract a function to do it. what do you think, Shiyang? > stream_init(fwd_streams[i]); > + } > + } > > port_fwd_begin = cur_fwd_config.fwd_eng->port_fwd_begin; > if (port_fwd_begin != NULL) {