From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60396A0540 for ; Fri, 8 Jul 2022 11:12:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4CE8A40A7B; Fri, 8 Jul 2022 11:12:35 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 6E4204280D for ; Fri, 8 Jul 2022 11:12:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657271552; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OGkcKFm34dKqfInf+R/q+K8pU7QRpdKD9DE2lXCLC7I=; b=i651V0liqOVZI4+ml5FWxxepPDpnMtTkKqUEvE9lOvG0vmhfDKY/1dx+B6VyOU/6RqMYB7 F9cbrCE9P2mZ8YyZZ8xORx8T1kcaZrBl+tgQ8KbfuSu0hwHcbVPZ2YE/xqcggOW3r6KEvE VwJ5gaqF/r4e3JrfEvapIyW8nk8wXG0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-226-1HmPjyLRNWeIe1LClEMg4g-1; Fri, 08 Jul 2022 05:12:29 -0400 X-MC-Unique: 1HmPjyLRNWeIe1LClEMg4g-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B6CF28339B4; Fri, 8 Jul 2022 09:12:28 +0000 (UTC) Received: from [10.39.208.8] (unknown [10.39.208.8]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9906D40CF8E4; Fri, 8 Jul 2022 09:12:27 +0000 (UTC) Message-ID: <602570a7-e3ba-99c1-acf2-2884425240cf@redhat.com> Date: Fri, 8 Jul 2022 11:12:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] vdpa/mlx5: fix leak on event thread creation To: David Marchand , dev@dpdk.org Cc: stable@dpdk.org, Matan Azrad , Viacheslav Ovsiienko , Xueming Li References: <20220620131044.1858049-1-david.marchand@redhat.com> From: Maxime Coquelin In-Reply-To: <20220620131044.1858049-1-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 6/20/22 15:10, David Marchand wrote: > As stated in the manual, pthread_attr_init return value should be > checked. > Besides, a pthread_attr_t should be destroyed once unused. > > In practice, we may have no leak (from what I read in glibc current code), > but this may change in the future. > Stick to a correct use of the API. > > Fixes: 5cf3fd3af4df ("vdpa/mlx5: add CPU core parameter to bind polling thread") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > --- > Note: this is only compile tested. > > --- > drivers/vdpa/mlx5/mlx5_vdpa_event.c | 30 +++++++++++++++++++---------- > 1 file changed, 20 insertions(+), 10 deletions(-) > Applied to dpdk-next-virtio/main. Thanks, Maxime