patches for DPDK stable branches
 help / color / mirror / Atom feed
* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] windows: build warnings with clang
       [not found]     ` <6379652.DfeunkggAM@thomas>
@ 2020-12-09  9:30       ` Nick Connolly
  0 siblings, 0 replies; only message in thread
From: Nick Connolly @ 2020-12-09  9:30 UTC (permalink / raw)
  To: Thomas Monjalon
  Cc: dev, Bruce Richardson, David Marchand, Dmitry Kozlyuk,
	pallavi.kadam, stable

Copying stable@dpdk.org - given that 20.11 has now been released I 
assume this needs to be applied there as well.

On 07/12/2020 20:34, Thomas Monjalon wrote:
> 03/12/2020 01:02, Dmitry Kozlyuk:
>> On Sun, 29 Nov 2020 16:00:24 +0000, Nick Connolly wrote:
>>> Microsoft CRT defines Windows-specific secure alternatives to
>>> standard library functions and triggers warnings when "insecure"
>>> functions are used [1]. However, calling code already has all
>>> necessary checks around those functions, so these warnings are not
>>> useful for DPDK. MinGW provides its own CRT without this issue.
>>>
>>> [1]:
>>> https://docs.microsoft.com/en-us/cpp/c-runtime-library/security-features-in-the-crt?view=msvc-160
>>>
>>> Disable this by defining -D_CRT_SECURE_NO_WARNINGS.
>>>
>>> Signed-off-by: Nick Connolly <nick.connolly@mayadata.io>
>>> ---
>>> v2:
>>> * Adjust commit wording as per Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
>>>
>>> Note: It is unclear exactly which commit this fixes.  It is probably a
>>> consequence of building more libraries for Windows.
>> Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> Applied, thanks
>
>


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-12-09  9:31 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20201127113623.26707-1-nick.connolly@mayadata.io>
     [not found] ` <20201129160024.879-1-nick.connolly@mayadata.io>
     [not found]   ` <20201203030215.0e7c6fce@sovereign>
     [not found]     ` <6379652.DfeunkggAM@thomas>
2020-12-09  9:30       ` [dpdk-stable] [dpdk-dev] [PATCH v2] windows: build warnings with clang Nick Connolly

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git