patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Akhil Goyal <gakhil@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>,
	stable@dpdk.org
Subject: Re: [EXT] [PATCH] app/test: don't count skipped tests as executed
Date: Wed, 06 Mar 2024 22:34:51 +0100	[thread overview]
Message-ID: <6087884.GJh79HuArf@thomas> (raw)
In-Reply-To: <Zec2BTO4lJmyYILs@bricha3-mobl1.ger.corp.intel.com>

05/03/2024 16:11, Bruce Richardson:
> On Tue, Mar 05, 2024 at 02:36:27PM +0000, Akhil Goyal wrote:
> > > Subject: [EXT] [PATCH] app/test: don't count skipped tests as executed
> > > The logic around skipped tests is a little confusing in the unit test
> > > runner.
> > > * Any explicitly disabled tests are counted as skipped but not
> > >   executed.
> > > * Any tests that return TEST_SKIPPED are counted as both skipped and
> > >   executed, using the same statistics counters.
> > > 
> > > This makes the stats very strange and hard to correlate, since the
> > > totals don't add up.  One would expect that SKIPPED + EXECUTED +
> > > UNSUPPORTED == TOTAL, and that PASSED + FAILED == EXECUTED.
> > > 
> > > To achieve this, mark any tests returning TEST_SKIPPED, or ENOTSUP as
> > > not having executed.
> > > 
> > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > 
> > Acked-by: Akhil Goyal <gakhil@marvell.com>
> Cc: stable@dpdk.org
> 
> > 
> > Yes this makes sense.
> > One would say executed should count the unsupported cases as well.
> > But I think this makes sense to not include them in executed cases.
> 
> It's a good question and there are arguments either way. I'd say that no
> test should return ENOTSUP now, and that such tests should return
> TEST_SKIPPED. For now, I think it's best to treat them the same.
> 
> > This would give better correlation.
> > Can we backport this as well?
> > 
> 
> If LTS maintainers want it, sure. Adding stable on CC.

Applied, thanks.



      reply	other threads:[~2024-03-06 21:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20231113150533.249808-1-bruce.richardson@intel.com>
     [not found] ` <CO6PR18MB448454916276F82ED0833F96D8222@CO6PR18MB4484.namprd18.prod.outlook.com>
2024-03-05 15:11   ` Bruce Richardson
2024-03-06 21:34     ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6087884.GJh79HuArf@thomas \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).