From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 2BC7F1B223; Mon, 2 Oct 2017 15:58:44 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP; 02 Oct 2017 06:58:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,469,1500966000"; d="scan'208";a="1201265277" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga001.fm.intel.com with ESMTP; 02 Oct 2017 06:58:42 -0700 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.28]) by IRSMSX103.ger.corp.intel.com ([169.254.3.49]) with mapi id 14.03.0319.002; Mon, 2 Oct 2017 14:58:41 +0100 From: "Jastrzebski, MichalX K" To: "skhare@vmware.com" CC: "dev@dpdk.org" , "Jain, Deepak K" , "Yigit, Ferruh" , "yongwang@vmware.com" , "stable@dpdk.org" , "Kulasek, TomaszX" Thread-Topic: [PATCH v2] net/vmxnet3: fix dereference before null check Thread-Index: AQHTOSOi9AG7+2gmVkSDhAtoT/vxTqLQmpBA Date: Mon, 2 Oct 2017 13:58:40 +0000 Message-ID: <60ABE07DBB3A454EB7FAD707B4BB158213C40F45@IRSMSX109.ger.corp.intel.com> References: <20170922123906.13308-1-michalx.k.jastrzebski@intel.com> <20170929130402.32196-1-michalx.k.jastrzebski@intel.com> In-Reply-To: <20170929130402.32196-1-michalx.k.jastrzebski@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2VlOTYwNWItYzYzOS00YzliLWFhMDQtMWQ2NGM0MjM0YmZhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkpvZ0xNR1pwQ0lTdzJKcXlnXC9iUFBSK3NhdFNjYWVxMlV3QXF2WVBwMlF3PSJ9 x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH v2] net/vmxnet3: fix dereference before null check X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Oct 2017 13:58:45 -0000 > -----Original Message----- > From: Jastrzebski, MichalX K > Sent: Friday, September 29, 2017 3:04 PM > To: skhare@vmware.com > Cc: dev@dpdk.org; Jain, Deepak K ; Yigit, Ferruh > ; Jastrzebski, MichalX K > ; yongwang@vmware.com; > stable@dpdk.org; Kulasek, TomaszX > Subject: [PATCH v2] net/vmxnet3: fix dereference before null check >=20 > Coverity reports check_after_deref: > Null-checking rq suggests that it may be null, but it > has already been dereferenced on all paths leading to > the check. > This patch removes NULL checking of "rq" from function > vmxnet3_dev_rx_queue_reset as it is already checked against NULL > one level up the callstack (function vmxnet3_dev_clear_queues). >=20 > Coverity issue: 143468 > Fixes: 5aecdc17a97d ("vmxnet3: fix stop/restart") > Cc: yongwang@vmware.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Tomasz Kulasek > Signed-off-by: Michal Jastrzebski > --- > drivers/net/vmxnet3/vmxnet3_rxtx.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c > b/drivers/net/vmxnet3/vmxnet3_rxtx.c > index d9cf437..0f8cfff 100644 > --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c > +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c > @@ -265,11 +265,9 @@ vmxnet3_dev_rx_queue_reset(void *rxq) > struct vmxnet3_rx_data_ring *data_ring =3D &rq->data_ring; > int size; >=20 > - if (rq !=3D NULL) { > - /* Release both the cmd_rings mbufs */ > - for (i =3D 0; i < VMXNET3_RX_CMDRING_SIZE; i++) > - vmxnet3_rx_cmd_ring_release_mbufs(&rq- > >cmd_ring[i]); > - } > + /* Release both the cmd_rings mbufs */ > + for (i =3D 0; i < VMXNET3_RX_CMDRING_SIZE; i++) > + vmxnet3_rx_cmd_ring_release_mbufs(&rq->cmd_ring[i]); >=20 > ring0 =3D &rq->cmd_ring[0]; > ring1 =3D &rq->cmd_ring[1]; > -- > 2.7.4 Hi Shrikrishna Khare, I would like to ask for a feedback regarding proposed fix. If everything is ok with it, please send acked-by. Best regards Michal.