From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 098C2A04C2 for ; Thu, 3 Sep 2020 16:18:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DFE111C0B6; Thu, 3 Sep 2020 16:18:01 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id B2EDEDE0; Thu, 3 Sep 2020 16:17:58 +0200 (CEST) IronPort-SDR: aZ9UVwQTuPamiX0SoVaR3uSRHO6Ds/Ne/1BhgaWW82ipxKWT9S7NQIDPhyUxZw6UUQ2Rd3zsvS ZYv7bbUU+r8g== X-IronPort-AV: E=McAfee;i="6000,8403,9733"; a="156846424" X-IronPort-AV: E=Sophos;i="5.76,387,1592895600"; d="scan'208";a="156846424" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2020 07:17:57 -0700 IronPort-SDR: B9Uv2xjZ75o+zRPOQ1SFs40+wSRoC8VCS0LXEPATAhbSF8RKMxE2l3auy7aJMPN4NBhtFvwkcr P9k2pWT7IGbQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,387,1592895600"; d="scan'208";a="298052066" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga003.jf.intel.com with ESMTP; 03 Sep 2020 07:17:57 -0700 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 3 Sep 2020 07:17:56 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 3 Sep 2020 22:17:54 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.1713.004; Thu, 3 Sep 2020 22:17:54 +0800 From: "Zhang, Qi Z" To: "Yang, Qiming" , "Jiang, JunyuX" , "dev@dpdk.org" CC: "Xing, Beilei" , "Wu, Jingjing" , "stable@dpdk.org" Thread-Topic: [PATCH] net/iavf: fix mismatch command Thread-Index: AQHWgZS2rSPCZvZS4E21PZ2nv/FhIalW9srg Date: Thu, 3 Sep 2020 14:17:54 +0000 Message-ID: <61380f2a379c4226b40e8dfcab0d2ba9@intel.com> References: <20200901081436.34963-1-junyux.jiang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.108.32.68] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH] net/iavf: fix mismatch command X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: dev On Behalf Of Yang, Qiming > Sent: Thursday, September 3, 2020 9:51 AM > To: Jiang, JunyuX ; dev@dpdk.org > Cc: Xing, Beilei ; Wu, Jingjing ; > stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix mismatch command >=20 >=20 >=20 > > -----Original Message----- > > From: Jiang, JunyuX > > Sent: 2020=1B$BG/=1B(B9=1B$B7n=1B(B1=1B$BF|=1B(B 16:15 > > To: dev@dpdk.org > > Cc: Xing, Beilei ; Wu, Jingjing > > ; Yang, Qiming ; Jiang, > > JunyuX ; stable@dpdk.org > > Subject: [PATCH] net/iavf: fix mismatch command > > > > The "command mismatch" warning shouldn't be triggered by > > VIRTCHNL_OP_EVENT opcode, because the VIRTCHNL_OP_EVENT opcode is > used > > by PF notifies status change events to VF. > > This patch fixed the issue. > > > > Fixes: 837c2ed86e4c ("net/iavf: return error if opcode is mismatched") > > Cc: stable@dpdk.org > > > > Signed-off-by: Junyu Jiang > > --- > > drivers/net/iavf/iavf_vchnl.c | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/iavf/iavf_vchnl.c > > b/drivers/net/iavf/iavf_vchnl.c index > > 33acea54a..331018f14 100644 > > --- a/drivers/net/iavf/iavf_vchnl.c > > +++ b/drivers/net/iavf/iavf_vchnl.c > > @@ -53,8 +53,11 @@ iavf_read_msg_from_pf(struct iavf_adapter *adapter, > > uint16_t buf_len, > > opcode, vf->cmd_retval); > > > > if (opcode !=3D vf->pend_cmd) { > > - PMD_DRV_LOG(WARNING, "command mismatch, expect %u, > > get %u", > > - vf->pend_cmd, opcode); > > + if (opcode !=3D VIRTCHNL_OP_EVENT) { > > + PMD_DRV_LOG(WARNING, > > + "command mismatch, expect %u, get %u", > > + vf->pend_cmd, opcode); > > + } > > return IAVF_ERR_OPCODE_MISMATCH; > > } > > > > -- > > 2.17.1 > Reviewed-by: Qiming Yang Applied to dpdk-next-net-intel. Thanks Qi