* [dpdk-stable] [PATCH] net/iavf: fix mismatch command
@ 2020-09-01 8:14 Junyu Jiang
2020-09-03 1:50 ` Yang, Qiming
0 siblings, 1 reply; 3+ messages in thread
From: Junyu Jiang @ 2020-09-01 8:14 UTC (permalink / raw)
To: dev; +Cc: Beilei Xing, Jingjing Wu, Qiming Yang, Junyu Jiang, stable
The "command mismatch" warning shouldn't be triggered by
VIRTCHNL_OP_EVENT opcode, because the VIRTCHNL_OP_EVENT
opcode is used by PF notifies status change events to VF.
This patch fixed the issue.
Fixes: 837c2ed86e4c ("net/iavf: return error if opcode is mismatched")
Cc: stable@dpdk.org
Signed-off-by: Junyu Jiang <junyux.jiang@intel.com>
---
drivers/net/iavf/iavf_vchnl.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c
index 33acea54a..331018f14 100644
--- a/drivers/net/iavf/iavf_vchnl.c
+++ b/drivers/net/iavf/iavf_vchnl.c
@@ -53,8 +53,11 @@ iavf_read_msg_from_pf(struct iavf_adapter *adapter, uint16_t buf_len,
opcode, vf->cmd_retval);
if (opcode != vf->pend_cmd) {
- PMD_DRV_LOG(WARNING, "command mismatch, expect %u, get %u",
- vf->pend_cmd, opcode);
+ if (opcode != VIRTCHNL_OP_EVENT) {
+ PMD_DRV_LOG(WARNING,
+ "command mismatch, expect %u, get %u",
+ vf->pend_cmd, opcode);
+ }
return IAVF_ERR_OPCODE_MISMATCH;
}
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-stable] [PATCH] net/iavf: fix mismatch command 2020-09-01 8:14 [dpdk-stable] [PATCH] net/iavf: fix mismatch command Junyu Jiang @ 2020-09-03 1:50 ` Yang, Qiming 2020-09-03 14:17 ` Zhang, Qi Z 0 siblings, 1 reply; 3+ messages in thread From: Yang, Qiming @ 2020-09-03 1:50 UTC (permalink / raw) To: Jiang, JunyuX, dev; +Cc: Xing, Beilei, Wu, Jingjing, stable > -----Original Message----- > From: Jiang, JunyuX <junyux.jiang@intel.com> > Sent: 2020年9月1日 16:15 > To: dev@dpdk.org > Cc: Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; > Yang, Qiming <qiming.yang@intel.com>; Jiang, JunyuX > <junyux.jiang@intel.com>; stable@dpdk.org > Subject: [PATCH] net/iavf: fix mismatch command > > The "command mismatch" warning shouldn't be triggered by > VIRTCHNL_OP_EVENT opcode, because the VIRTCHNL_OP_EVENT opcode is > used by PF notifies status change events to VF. > This patch fixed the issue. > > Fixes: 837c2ed86e4c ("net/iavf: return error if opcode is mismatched") > Cc: stable@dpdk.org > > Signed-off-by: Junyu Jiang <junyux.jiang@intel.com> > --- > drivers/net/iavf/iavf_vchnl.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c index > 33acea54a..331018f14 100644 > --- a/drivers/net/iavf/iavf_vchnl.c > +++ b/drivers/net/iavf/iavf_vchnl.c > @@ -53,8 +53,11 @@ iavf_read_msg_from_pf(struct iavf_adapter *adapter, > uint16_t buf_len, > opcode, vf->cmd_retval); > > if (opcode != vf->pend_cmd) { > - PMD_DRV_LOG(WARNING, "command mismatch, expect %u, > get %u", > - vf->pend_cmd, opcode); > + if (opcode != VIRTCHNL_OP_EVENT) { > + PMD_DRV_LOG(WARNING, > + "command mismatch, expect %u, get %u", > + vf->pend_cmd, opcode); > + } > return IAVF_ERR_OPCODE_MISMATCH; > } > > -- > 2.17.1 Reviewed-by: Qiming Yang <qiming.yang@intel.com> ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [PATCH] net/iavf: fix mismatch command 2020-09-03 1:50 ` Yang, Qiming @ 2020-09-03 14:17 ` Zhang, Qi Z 0 siblings, 0 replies; 3+ messages in thread From: Zhang, Qi Z @ 2020-09-03 14:17 UTC (permalink / raw) To: Yang, Qiming, Jiang, JunyuX, dev; +Cc: Xing, Beilei, Wu, Jingjing, stable > -----Original Message----- > From: dev <dev-bounces@dpdk.org> On Behalf Of Yang, Qiming > Sent: Thursday, September 3, 2020 9:51 AM > To: Jiang, JunyuX <junyux.jiang@intel.com>; dev@dpdk.org > Cc: Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; > stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix mismatch command > > > > > -----Original Message----- > > From: Jiang, JunyuX <junyux.jiang@intel.com> > > Sent: 2020年9月1日 16:15 > > To: dev@dpdk.org > > Cc: Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing > > <jingjing.wu@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Jiang, > > JunyuX <junyux.jiang@intel.com>; stable@dpdk.org > > Subject: [PATCH] net/iavf: fix mismatch command > > > > The "command mismatch" warning shouldn't be triggered by > > VIRTCHNL_OP_EVENT opcode, because the VIRTCHNL_OP_EVENT opcode is > used > > by PF notifies status change events to VF. > > This patch fixed the issue. > > > > Fixes: 837c2ed86e4c ("net/iavf: return error if opcode is mismatched") > > Cc: stable@dpdk.org > > > > Signed-off-by: Junyu Jiang <junyux.jiang@intel.com> > > --- > > drivers/net/iavf/iavf_vchnl.c | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/iavf/iavf_vchnl.c > > b/drivers/net/iavf/iavf_vchnl.c index > > 33acea54a..331018f14 100644 > > --- a/drivers/net/iavf/iavf_vchnl.c > > +++ b/drivers/net/iavf/iavf_vchnl.c > > @@ -53,8 +53,11 @@ iavf_read_msg_from_pf(struct iavf_adapter *adapter, > > uint16_t buf_len, > > opcode, vf->cmd_retval); > > > > if (opcode != vf->pend_cmd) { > > - PMD_DRV_LOG(WARNING, "command mismatch, expect %u, > > get %u", > > - vf->pend_cmd, opcode); > > + if (opcode != VIRTCHNL_OP_EVENT) { > > + PMD_DRV_LOG(WARNING, > > + "command mismatch, expect %u, get %u", > > + vf->pend_cmd, opcode); > > + } > > return IAVF_ERR_OPCODE_MISMATCH; > > } > > > > -- > > 2.17.1 > Reviewed-by: Qiming Yang <qiming.yang@intel.com> Applied to dpdk-next-net-intel. Thanks Qi ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-03 14:18 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-09-01 8:14 [dpdk-stable] [PATCH] net/iavf: fix mismatch command Junyu Jiang 2020-09-03 1:50 ` Yang, Qiming 2020-09-03 14:17 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).