patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Ali Alnubani <alialnu@nvidia.com>
Cc: dev@dpdk.org, michaelba@mellanox.com, stable@dpdk.org,
	rasland@nvidia.com, david.marchand@redhat.com,
	bruce.richardson@intel.com
Subject: Re: [PATCH v2] net/mlx5: fix build with clang 14
Date: Wed, 15 Jun 2022 10:16:57 +0200	[thread overview]
Message-ID: <6144105.lOV4Wx5bFT@thomas> (raw)
In-Reply-To: <20220511164109.1574109-1-alialnu@nvidia.com>

11/05/2022 18:41, Ali Alnubani:
> Use fgets instead of fscanf to resolve the following warning
> reported by clang 14.0.0 in Fedora 37 (Rawhide):
> 
> drivers/net/mlx5/linux/mlx5_ethdev_os.c:1137:52: error:
>   'fscanf' may overflow; destination buffer in argument 3 has size 16,
>   but the corresponding specifier may require size 17
>   [-Werror,-Wfortify-source]
>   ret = fscanf(file, "%" RTE_STR(IF_NAMESIZE) "s", port_name);

Some other patches are proposing to declare the variable
of size IF_NAMESIZE+1 but I think it's wrong because
IF_NAMESIZE includes a terminating null byte.

> Fixes: 63d1db710fbc ("net/mlx5: fix unlimited parsing of switch info")
> Cc: michaelba@mellanox.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
[...]
> -		ret = fscanf(file, "%" RTE_STR(IF_NAMESIZE) "s", port_name);
> -		fclose(file);
> -		if (ret == 1)
> +		if (fgets(port_name, IF_NAMESIZE, file) != NULL)
>  			mlx5_translate_port_name(port_name, &data);
> +		fclose(file);

Acked-by: Thomas Monjalon <thomas@monjalon.net>



  reply	other threads:[~2022-06-15  8:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-11 13:58 [PATCH] " Ali Alnubani
2022-05-11 14:04 ` David Marchand
2022-05-11 16:41 ` [PATCH v2] " Ali Alnubani
2022-06-15  8:16   ` Thomas Monjalon [this message]
2022-06-15  8:41     ` David Marchand
2022-06-15  8:21   ` Slava Ovsiienko
2022-06-15 10:08   ` Raslan Darawsheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6144105.lOV4Wx5bFT@thomas \
    --to=thomas@monjalon.net \
    --cc=alialnu@nvidia.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=michaelba@mellanox.com \
    --cc=rasland@nvidia.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).