From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: stable@dpdk.org, bruce.richardson@intel.com,
Chenbo Xia <chenbox@nvidia.com>,
Nipun Gupta <nipun.gupta@amd.com>,
Ranjit Menon <ranjit.menon@intel.com>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: Re: [PATCH v3 1/3] bus/pci: fix build with MinGW 13
Date: Wed, 10 Sep 2025 14:59:23 +0200 [thread overview]
Message-ID: <6190162.lOV4Wx5bFT@thomas> (raw)
In-Reply-To: <20250908212034.699713-2-thomas@monjalon.net>
08/09/2025 23:17, Thomas Monjalon:
> After an upgrade to MinGW version 13, some compilation errors appear:
>
> drivers/bus/pci/windows/pci.c:362:58:
> error: 'GUID_DEVCLASS_NETUIO' undeclared
> drivers/bus/pci/windows/pci_netuio.c:57:39:
> error: 'GUID_DEVINTERFACE_NETUIO' undeclared
>
> The cause is MinGW has set NTDDI_VERSION to the highest version
> without defining the expected NETUIO constants.
>
> It is safer to not rely on Windows headers version,
> and instead define what is not already defined,
> after including Windows headers.
[...]
> -#if !defined(NTDDI_WIN10_FE) || NTDDI_VERSION < NTDDI_WIN10_FE
> -/* GUID definition for device class netUIO */
> +/* GUID_DEVCLASS_NETUIO should be defined in devguid.h */
> +#ifndef GUID_DEVCLASS_NETUIO
> DEFINE_GUID(GUID_DEVCLASS_NETUIO, 0x78912bc1, 0xcb8e, 0x4b28,
> 0xa3, 0x29, 0xf3, 0x22, 0xeb, 0xad, 0xbe, 0x0f);
> +#endif
Unfortunately it cannot work because DEFINE_GUID is declaring a variable,
not a macro.
It is sad, we have to check Windows and MinGW versions.
next prev parent reply other threads:[~2025-09-10 12:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250813152829.457463-1-thomas@monjalon.net>
2025-08-13 15:25 ` [PATCH " Thomas Monjalon
2025-08-13 15:25 ` [PATCH 2/3] net/mlx5: " Thomas Monjalon
2025-08-14 9:50 ` Dariusz Sosnowski
2025-08-13 15:25 ` [PATCH 3/3] bbdev: wrong fix for " Thomas Monjalon
2025-08-19 13:51 ` Bruce Richardson
[not found] ` <20250827151759.1448018-1-thomas@monjalon.net>
2025-08-27 15:16 ` [PATCH v2 1/3] bus/pci: fix build with " Thomas Monjalon
2025-08-27 15:16 ` [PATCH v2 2/3] net/mlx5: " Thomas Monjalon
2025-08-27 15:16 ` [PATCH v2 3/3] bbdev: wrong fix for " Thomas Monjalon
2025-08-29 5:36 ` Hemant Agrawal
[not found] ` <20250908212034.699713-1-thomas@monjalon.net>
2025-09-08 21:17 ` [PATCH v3 1/3] bus/pci: fix build with " Thomas Monjalon
2025-09-10 12:59 ` Thomas Monjalon [this message]
2025-09-08 21:17 ` [PATCH v3 2/3] net/mlx5: " Thomas Monjalon
2025-09-08 21:17 ` [PATCH v3 3/3] bbdev: " Thomas Monjalon
2025-09-10 13:00 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6190162.lOV4Wx5bFT@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=chenbox@nvidia.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=nipun.gupta@amd.com \
--cc=ranjit.menon@intel.com \
--cc=roretzla@linux.microsoft.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).