From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 9C2FD455FE
for <public@inbox.dpdk.org>; Thu, 11 Jul 2024 17:56:47 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 8DFAC42E7A;
Thu, 11 Jul 2024 17:56:47 +0200 (CEST)
Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16])
by mails.dpdk.org (Postfix) with ESMTP id 24AAC42E5F;
Thu, 11 Jul 2024 17:56:45 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1720713407; x=1752249407;
h=message-id:date:subject:to:cc:references:from:
in-reply-to:content-transfer-encoding:mime-version;
bh=9aDfWqiq9Dz3HbfGjQZl4u1HWN8K8K8ZlKH0uhFCvLc=;
b=AlE9Znufp9M51KcEgoFaFYsxX3OxRJ296SoGsT+/n87LnmaGT8Gmfexk
CedIhIVz9zj2N/Eyj9Mh6r/fsvVOj6s9AmRIdWGJohH3eYtsDlYjUd+Wj
gGrSGkqb+ux0ttUW85P+FdNIeRzL8wNLmSctkjG5mwLbtwMzz6gWjMp3+
hZtuujBw/O+UdaB37QOxvgSfENV8gBPPIEDqB2yJy8uwvXTZTawS6jhTs
BogcdkCfUDpNxTlxys8tHFX7xfYZaCbMfvotrcCxMXvLc6Tb1NRrz9v0e
HjhCUDbo6AKl4jufmZSnz6Kmhp+OiX1ki2i24lkX9HtReJtue861mMlhU Q==;
X-CSE-ConnectionGUID: A8YS73JXT/673S6l0ZCq/A==
X-CSE-MsgGUID: OH6q4vl9RVySul2gK33iVQ==
X-IronPort-AV: E=McAfee;i="6700,10204,11130"; a="18248172"
X-IronPort-AV: E=Sophos;i="6.09,200,1716274800"; d="scan'208";a="18248172"
Received: from orviesa006.jf.intel.com ([10.64.159.146])
by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
11 Jul 2024 08:56:46 -0700
X-CSE-ConnectionGUID: 9IKeYdVpRmiwH86WA05aDQ==
X-CSE-MsgGUID: 52MuE4RiSCa34Gto3g4fuw==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="6.09,200,1716274800"; d="scan'208";a="49034617"
Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15])
by orviesa006.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384;
11 Jul 2024 08:56:45 -0700
Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by
ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.39; Thu, 11 Jul 2024 08:56:44 -0700
Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by
orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.39 via Frontend Transport; Thu, 11 Jul 2024 08:56:44 -0700
Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169)
by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2507.39; Thu, 11 Jul 2024 08:56:44 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=S2l5VcQu3zRH2dUSMjEV8ZILE87TG2wquLfHDnkD4flTVwnxxocvfU7ePDH1U4yiy65dBnBhxydplD3I5xg7YR9XaJJH8o/SIjW5hVFdvjvQIDJDRv3mUX+d1pUOmYHy251CypZovMwDUU6jcD8RdpIqh3Z+V+gNRfeRxbj8hOMy2ZHGPsHj0YRXYWCUnEA2NX10gDxFhm9s9Akqcbc1hi1jVB0+PG64zgI3eXUr5G29+8ygIplDnbL002SGqfCTnb0VNVn355BtdUUdLE0J3oMApGKxYtQKBvGC0oUQpVsjcBhvr78asnZVTDkxNBx+akAKh0aeXwJx/OyXGItlWg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=Ko6tvh4rvTTM02x4n56pvs5igmL6XO40VQL+KAw63sk=;
b=HidPJTJg7ANRAF0Pj11Ab1G64RTpF4cC1wISPRaYmTzf3grj32ARC92v06XZUYNIiyMuEy805qVD2ySaJAhkn02Yze1Fyys3yPwitIpnKKSLvM+7FWIm5DogRRE9S2Qi7TQCsYK8d0Qiv82UJyqH9j6CzZV/LFzY24BBqJDOywSeA4bZca3ye2srAY+Nn6OXrmPvLrrcEd0b04/u/tlvR3W/mrgEIy4ZBsYJLW+9bFRsNPyyU3/jjM5ujv6iXMuHg5sZtveVOcbjVUXqCBLregmBGG8CA2vC7Gwc9Dgbfn5mlsIGqNam9dsf1MF7KMe08ie8uPrutdMkW4kcplqSsA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
Authentication-Results: dkim=none (message not signed)
header.d=none;dmarc=none action=none header.from=intel.com;
Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by
DS7PR11MB7692.namprd11.prod.outlook.com (2603:10b6:8:ef::15) with
Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.7762.20; Thu, 11 Jul 2024 15:56:42 +0000
Received: from DM4PR11MB6502.namprd11.prod.outlook.com
([fe80::21e4:2d98:c498:2d7a]) by DM4PR11MB6502.namprd11.prod.outlook.com
([fe80::21e4:2d98:c498:2d7a%6]) with mapi id 15.20.7741.033; Thu, 11 Jul 2024
15:56:42 +0000
Message-ID: <61973fda-fd67-49cc-9e41-aca7fd5bdbe1@intel.com>
Date: Thu, 11 Jul 2024 17:56:34 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/3] bus/vdev: revert fix devargs after multi-process bus
scan
To: Mingjin Ye <mingjinx.ye@intel.com>, <dev@dpdk.org>
CC: <stable@dpdk.org>
References: <20240314093630.1066948-1-mingjinx.ye@intel.com>
<20240314093630.1066948-3-mingjinx.ye@intel.com>
Content-Language: en-US
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
In-Reply-To: <20240314093630.1066948-3-mingjinx.ye@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: DU2PR04CA0065.eurprd04.prod.outlook.com
(2603:10a6:10:232::10) To DM4PR11MB6502.namprd11.prod.outlook.com
(2603:10b6:8:89::7)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|DS7PR11MB7692:EE_
X-MS-Office365-Filtering-Correlation-Id: 29cafded-dcbc-4dd6-9e40-08dca1c20e75
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016;
X-Microsoft-Antispam-Message-Info: =?utf-8?B?dDZJUlBabXRaTzB5RmVCajVPZ0dGOS9vWmh6NW5tOUdXalZlbGx3U1oxdDJF?=
=?utf-8?B?Z2hxUkNtVXYrOFF3WGxYL2V1aDNnQ0Z3YjM2Q0hqWVZZUElzY2hCRnprZjN1?=
=?utf-8?B?KzUweEo2a3RWcWQvOTdVNmVjYUt1QnB3N1R6Q3FjVDBDcU9nRVhXTk1BMWZX?=
=?utf-8?B?SUxXc0l4TWlzTnVUc2s1SGRUaFd0VlhsY3NQRFFIcGtvaXFUUERYTklELzFW?=
=?utf-8?B?UkJFUHJxQVlxZTM2S2ZqN1plMkRNTStnQmxYanZQTUs2aS94MGQ3cUdpZ0hI?=
=?utf-8?B?L1RNaS9nMCt1MW9DbFhJZVBHbGdJVE9oc2E1RjB5NW4wdXIxbEF1cHFCMk1C?=
=?utf-8?B?QlZQVEUxNGlOVVd4aFlSTFIvUmx1SHZad1JFNTNQcllkN1hsY3ZYZ01UUS9v?=
=?utf-8?B?bC9DNTczcnExenc5MlZvZWdlVDJENm54QjFRNi8vN2JHZUtLZkorMitIMXBR?=
=?utf-8?B?MjdzYUYyTHhCR0N1Yi9NQ0dWOE1ML05JdXlvZTFoREJndlg0V2V5VkZEcTBU?=
=?utf-8?B?Q3RrVjdGeHZXZEd3cEJwT0kvYTlWK3l1VUpLMFRkL0hlaCtpMlkvZCtnS05l?=
=?utf-8?B?ODZNL2pUYStobytsdTlaek00dWtzSW1SY05pZ3lOalRGcDZIcnNoWlZ1cmti?=
=?utf-8?B?aEVnVUJxN2czZjh6WFpJM0Y2WXhDb1JKNk1za0Rld1cvdUptM2NpNUUxNVZB?=
=?utf-8?B?ekJsS3hJakF5b2VYNWRVSEZYNG1pUU5tQU0zcnVvSFh3Zm9CcXp3YkFkWGRZ?=
=?utf-8?B?ZU10T0xiYkFnZDhJcXp6Z3puUXdEbVdkS3d4eVdpRERVdTczMUhwWFAwZ3F6?=
=?utf-8?B?bHVLU3JIM3lKdGNjY2FBTXVaRVNNYmNpZmdBMXJRNi9FSEhOTzBrN001RUR3?=
=?utf-8?B?cUxMVDNqbTRZdGRzTEcyZ3FFaWtEb3M1RWg5Mmg1dVhQVytFQnhRMDVUV0tu?=
=?utf-8?B?Nm1oS2Y0eGVmeEl2M1lZWnFsSEJkZWtlTTdSNGhPdjkxenVTeDgyZmtaYnJD?=
=?utf-8?B?bVdXT3NDc1o2RU9Vd1J6SFBYTUJabjV6UkZBQkxLdmV1a2F1cVdHUzhKQ1dt?=
=?utf-8?B?Z3hocVNoUXVhWDR6ZFI0L2hPcUJiV2FPM0RZUTNudkNFOWcrM2NqeGZjaDU2?=
=?utf-8?B?TWw1M1p1Zm9ZN1NTK280S3d0RlJ1NXFad2RvRS85Q3NVVHBSV2VHd0M0L3Fo?=
=?utf-8?B?cjZsR2M4QjFMUWgrMXdxY3FJNzY0NkZoemtWaG11Ylh0N3dUTjJBbXlzQ1ZN?=
=?utf-8?B?SC9Cam5iKzBTeG1zY1JPa2hKeldKSTRYUnFFdVRuOTArRGdraUYzclBPQ09o?=
=?utf-8?B?RlRUcmx4b0pHaFBjL0dycVIwZlV6dGpjWkpydVNEbDl6aHBRZVRnZzRyK2k2?=
=?utf-8?B?Zmk5QmhrcFdxL1p2cTVIV1Jtby9BRW9WbVNScC9oU3NnbFcyeUVva1dFdWls?=
=?utf-8?B?cHE0OE5ySkUzelE5aGRWSlpGUUdqVmJwUVNQZGxEVHR5bVI0N2V4NHU0cGV3?=
=?utf-8?B?UStQWXcyak4rcXZjSlUxcExLa1FEMDZ5THZmYjY2S3BOdVhZb2dnUWd4MGZB?=
=?utf-8?B?QmlkdWVFZ1pMRm1TYm9NSUIvR2VaTkpvaFdYM3BGdDdrYnlOcXlubCtZRzNO?=
=?utf-8?B?eDI0YUxoV0JKTTF2dHhrTmFSZ2RPYml5dVQzUHQranl4T0hRS0lzSHpkUCta?=
=?utf-8?B?eVJqc3B4c1U1RERwSGtjZXQwRDdOakJ5Y0EvV1VYWFB4b0k2MjBqT3ZmUkxr?=
=?utf-8?B?NWxnOXkyQXM0aERENTY5Y2FITEM5NlVGYkVvRkU3MDRaZFMxc25VV0JadzQy?=
=?utf-8?B?LzdUa3daVkxCSDdZV2NMQT09?=
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S3dIdE9PTzJieEZoSWtVSzBPWUhqbHQ3UmlNQzhxeUR6cGw0YlhnV0lFYllP?=
=?utf-8?B?S09HL1pSTUlRQ2doamV1UjFsdlo4TDlGNDQ4L21UdjMybm5Nb0xXYXpSWGxy?=
=?utf-8?B?WFFDZHByZS9ybnpVNGpNK2pKNnVYSnplUTJGWkdnSEpaSXFpdHduSlZ5NHY2?=
=?utf-8?B?cUdMREd5M0Zka25NOFhGamhOZWs1VFFPT2VXR0tXS1BGUHByWWxLWU9UaTJS?=
=?utf-8?B?SzJGYVJ4am13YjNtcjAwSXpaQy9zRkoraXBSajVpOUtIZlpPNzgvamRSTlIz?=
=?utf-8?B?UUtFdW9ZOFJxVUVZREJTUFlaU1lwdXBkckp1dzF3M3g2YitNVnlyS2IvUHE5?=
=?utf-8?B?WHlZL2Zmbnp1SWNJalU5aEswRFNoUEIzQjR0ZjF3Z0R6Tm05OTcvTEFYdE5n?=
=?utf-8?B?a1M2MVFmQ3ZkVllNbm1VTnd2Nm1SbmU5S1BxY3hLNjdEbnZ0VTB3TUV2RTBR?=
=?utf-8?B?Vi82SGRiL0JnWWF4bU9oOVpVTTR4ekNnRStvZ3JSS2lNOEhCMWZFa0tnWWlS?=
=?utf-8?B?cHlmY3VjeStNMWN2N3JoTWROaGgzeSs0QWJKaEY0WGVnd1NueUZpUWV3NkJC?=
=?utf-8?B?d3hmMlpOMDhNdTh3bU1ZNDF0UFd5aUI2UVVyZ3o5OUdRYXkrRmh4Z1Uya2Rw?=
=?utf-8?B?L3JvNmJCYjhIOHoxYW0waFBKYmsyN0xObHQyM3J5MVJacnBsV0FPeGZ3Q1VU?=
=?utf-8?B?SCtUejNpUXEzSlQzL01XbENkVmcvelhER2Qra1JnUHhPLzZSdEF6a0gvdm8w?=
=?utf-8?B?am1mQnBqTEVKWkwwTEtsM2JJUWJnbWl3T1B4LzNpNzZxTndTTWpiSSs3MmQ5?=
=?utf-8?B?clg5eTgycW1nYThKY2ZmV1h4OURNMTZSSmhwM0tsOFUwdDZZQVV4WEFJbXlu?=
=?utf-8?B?cWdBTTF4ckxHTk15QnU4QUs2V1JlZnRqdHJ5cTU3S01uVmc0THZzcXBySWE1?=
=?utf-8?B?SHlaY29Nbzk4UnYyRzVhNXJhU3c4d2pUWW9SSnQzdmZlTE1mYTFLTC9rSUlX?=
=?utf-8?B?cVF3RUhQSnZRbEFXR0RNR0MwODVxdm5sUkpuSzJITDZHc0pDRWIrZENKVTdZ?=
=?utf-8?B?ZGtLNE5vY1VoSUhSK3RVR1FWcEJjTG5sNHgxN3hDNE8zZUlIV0ZxUU0vbnM2?=
=?utf-8?B?U25mcUZsc25McCt4KzJhRVJiMGpmZHMvaGloR0NaU0NPQk0xQUJKY3E1RHBG?=
=?utf-8?B?WnIybTNZTWFOb2V6b3BiVy9ubUVmN2VGZ2c3Q2V6YmtBUVVOWmdHRll0a2py?=
=?utf-8?B?bFVVSFlBZ0prY3hLT1Y3bGg1WGFJVTRvSGcrVlZzWkJGUFdDRk9hWlBLRTFW?=
=?utf-8?B?aEtCYm9lWUpHTzQzYUVHcklFbVdQeGlhcDZCK0F4cW0yelNWdlBqK2V3ZnVv?=
=?utf-8?B?VVNBUEthUFBPVE0xSzg4SWxhZGhOTWxtQWp5T09CejNFWVJFL1ltZjE5MHpk?=
=?utf-8?B?bGVHaC9NQjBtTzM5cXF1TVI5enB6NFVDQ21qaG5MWE5qZnVQbVJhQ3N1eDdC?=
=?utf-8?B?QXdHNmV4cDIyYTg2K2FnRStQcU1LNHB5dUZyU25rdmczK0w0TE04Z3RzZ0Z0?=
=?utf-8?B?dXBjS0M5bW1BWmtRWUpqamtVY1V2ZWF2bGtyUU8ySUYvaFFDRndoRjNkZWY2?=
=?utf-8?B?WFR3SGxsQS9mcVVRVEtuWHVJWGxlaXhnMGVmU2NzWGhrUVkzcEpkYzYvYjlZ?=
=?utf-8?B?N3d4S3FGRmw0aEhaRGt6RWdSaXlWdGYxeEVWTE1idHVXS0NmekFrS0tYNW9y?=
=?utf-8?B?Wnk4Qzh1ajlIbitXUWYrK0lmeExVSDh5M21mY1lscUMxTS8rdE16TUJxNENs?=
=?utf-8?B?aXJaZ0JuV1VSTVBYaUNZcU4vbHlsbkJ5UlhuVG8wNWNSSTNtTTIvZHp1UmxH?=
=?utf-8?B?akpseWxTNzdMZjc4WTE2akl4MjF2NWVLY1lyMHAxTFdYYm43Y1RMaVdlU3No?=
=?utf-8?B?Q21CZHp5WWUzVTFiRU13bm8xNG1oaFhFMmFLWE5uanpPTEtHT0VrSEl3Qk80?=
=?utf-8?B?eWg3czZKODJNa25kZ0w4KzNmcThueTA2VHlEQlRhRUx5Q2dqUXIrOEtFRDEx?=
=?utf-8?B?SkU2UGk0OVQzazlaeGtFTW9ucllnUmVsSDA0VkxmZ3dOWUdxVEdQd3FTY2VU?=
=?utf-8?B?Y0J5NnNzaGxRU2Z3akZYc3BVaVdDSXhVZXNucDFLanV3K3BydExvelFMRTI1?=
=?utf-8?B?MEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 29cafded-dcbc-4dd6-9e40-08dca1c20e75
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2024 15:56:42.1695 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WOE2nIOEEl49jpqKtacEgimaZRBR6BFFPTT6GW9A3ppmUjDUbXHEr2YBIo5sejycuZMRPFW+MwbGBnL5LPfiEIm6HoJeKgAdRij2olc8bRQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7692
X-OriginatorOrg: intel.com
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
On 3/14/2024 10:36 AM, Mingjin Ye wrote:
> The asan tool detected a memory leak in the vdev driver alloc_devargs.
> The previous commit does not insert device arguments into devargs_list
> when attaching a device during a bus scan of a secondary process.
> This resulted in an existing memory leak when removing a vdev device,
> since rte_devargs_remove actually does nothing.
>
> Therefore the following commit was reverted accordingly.
>
> Fixes: f5b2eff0847d ("bus/vdev: fix devargs after multi-process bus scan")
>
> Restoring this commit will fix the memory leak. There was an issue with
> device parameters using free devargs when inserting a vdev device when
> devargs_list already existed, resulting in a core dump. A new patch
> will fix this issue.
>
> Fixes: f5b2eff0847d ("bus/vdev: fix devargs after multi-process bus scan")
> Cc: stable@dpdk.org
>
> Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
> ---
Hi Mingjin,
I've been trying to understand what this patchset does.
> drivers/bus/vdev/vdev.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
> index 38d05a9fe9..1a6cc7d12d 100644
> --- a/drivers/bus/vdev/vdev.c
> +++ b/drivers/bus/vdev/vdev.c
> @@ -264,9 +264,7 @@ alloc_devargs(const char *name, const char *args)
> }
>
> static int
> -insert_vdev(const char *name, const char *args,
> - struct rte_vdev_device **p_dev,
> - bool init)
> +insert_vdev(const char *name, const char *args, struct rte_vdev_device **p_dev)
> {
> struct rte_vdev_device *dev;
> struct rte_devargs *devargs;
> @@ -300,8 +298,7 @@ insert_vdev(const char *name, const char *args,
> goto fail;
> }
>
> - if (init)
> - rte_devargs_insert(&devargs);
> + rte_devargs_insert(&devargs);
The original commit message states that "it is not necessary" to add
devargs to the list in secondary processes, but does not state why it is
unnecessary and what issue was that fix for. With that understanding, I
think the commit message for this patch can be reworded like follows:
---
This patch reverts commit f5b2eff0847d ("bus/vdev: fix devargs after
multi-process bus scan")
With current code, we do not add devargs to devargs list when we add a
vdev in secondary process (because `init` flag is set to `false`).
Because of this, when we do vdev_uninit, we call rte_devargs_remove on
the &devargs pointer (the one we didn't add to devargs list but did save
inside rte_vdev_device struct), but in secondary process, because
devargs were not added to the list in the first place, devargs_remove
does not find the associated devargs in its list and therefore does not
free associated resources. As a result, we get a memory leak, because we
free the rte_vdev_device but not its associated devargs.
Revert this patch to avoid leaking devargs on vdev uninit.
---
I think this would be clearer summation of what is going on in this patch.
Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
> dev->device.devargs = devargs;
> TAILQ_INSERT_TAIL(&vdev_device_list, dev, next);
>
> @@ -323,7 +320,7 @@ rte_vdev_init(const char *name, const char *args)
> int ret;
>
> rte_spinlock_recursive_lock(&vdev_device_list_lock);
> - ret = insert_vdev(name, args, &dev, true);
> + ret = insert_vdev(name, args, &dev);
> if (ret == 0) {
> ret = vdev_probe_all_drivers(dev);
> if (ret) {
> @@ -449,7 +446,7 @@ vdev_action(const struct rte_mp_msg *mp_msg, const void *peer)
> break;
> case VDEV_SCAN_ONE:
> VDEV_LOG(INFO, "receive vdev, %s", in->name);
> - ret = insert_vdev(in->name, NULL, NULL, false);
> + ret = insert_vdev(in->name, NULL, NULL);
> if (ret == -EEXIST)
> VDEV_LOG(DEBUG, "device already exist, %s", in->name);
> else if (ret < 0)
--
Thanks,
Anatoly