From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45316A00E6 for ; Thu, 11 Jul 2019 17:33:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 011E331FC; Thu, 11 Jul 2019 17:33:39 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id A84F931FC for ; Thu, 11 Jul 2019 17:33:36 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jul 2019 08:33:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,479,1557212400"; d="scan'208";a="249821589" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga001.jf.intel.com with ESMTP; 11 Jul 2019 08:33:34 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.88]) by IRSMSX102.ger.corp.intel.com ([169.254.2.59]) with mapi id 14.03.0439.000; Thu, 11 Jul 2019 16:33:33 +0100 From: "OLoughlin, John" To: "Morrissey, Sean" CC: "ciara.power@intel.com" , "stable@dpdk.org" Thread-Topic: [PATCH] lib/librte_eal: fix unrecongized telemetry eal arg Thread-Index: AQHVN/aZuc0diw15k0O158rq45Whu6bFi50Q Date: Thu, 11 Jul 2019 15:33:33 +0000 Message-ID: <619A2585A61B984286AE439D7BFDAECE712C1573@IRSMSX101.ger.corp.intel.com> References: <20190711144017.23081-1-sean.morrissey@intel.com> In-Reply-To: <20190711144017.23081-1-sean.morrissey@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDhkMWExM2QtZDkwYi00Y2RkLWI3NjAtZjI2YzIxNGFjMDU4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicjVVRlpEMHU5K2lxSGREa1BPTjVtdGl4NlNWaXp0R0pqeHRhTnFkUURrd3pWUitrc3NjelJyZUJRV1ZINHFObSJ9 x-ctpclassification: CTP_NT x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-stable] [PATCH] lib/librte_eal: fix unrecongized telemetry eal arg X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi Se=E1n, Thanks for that I can confirm that the patch is functionally correct Regards John -----Original Message----- From: Morrissey, Sean = Sent: Thursday, July 11, 2019 3:40 PM To: OLoughlin, John Cc: Morrissey, Sean ; ciara.power@intel.com; stab= le@dpdk.org Subject: [PATCH] lib/librte_eal: fix unrecongized telemetry eal arg Added telemetry to EAL long options so that when --telemetry is passed as a= n EAL arg that there is no unrecognized argument error message printed. Fixes: 8877ac688b52 ("telemetry: introduce infrastructure") Cc: ciara.power@intel.com Cc: stable@dpdk.org Signed-off-by: Sean Morrissey --- lib/librte_eal/common/eal_common_options.c | 3 +++ lib/librte_eal/common/eal_options.h | 8 +++++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/co= mmon/eal_common_options.c index 512d5088e..b7e511a63 100644 --- a/lib/librte_eal/common/eal_common_options.c +++ b/lib/librte_eal/common/eal_common_options.c @@ -80,6 +80,9 @@ eal_long_options[] =3D { {OPT_VMWARE_TSC_MAP, 0, NULL, OPT_VMWARE_TSC_MAP_NUM }, {OPT_LEGACY_MEM, 0, NULL, OPT_LEGACY_MEM_NUM }, {OPT_SINGLE_FILE_SEGMENTS, 0, NULL, OPT_SINGLE_FILE_SEGMENTS_NUM}, +#ifdef RTE_LIBRTE_TELEMETRY + {OPT_TELEMETRY, 0, NULL, OPT_TELEMETRY_NUM }, +#endif {OPT_MATCH_ALLOCATIONS, 0, NULL, OPT_MATCH_ALLOCATIONS_NUM}, {0, 0, NULL, 0 } }; diff --git a/lib/librte_eal/common/eal_options.h b/lib/librte_eal/common/ea= l_options.h index 9855429e5..f819845f5 100644 --- a/lib/librte_eal/common/eal_options.h +++ b/lib/librte_eal/common/eal_options.h @@ -67,9 +67,15 @@ enum { OPT_SINGLE_FILE_SEGMENTS_NUM, #define OPT_IOVA_MODE "iova-mode" OPT_IOVA_MODE_NUM, + +#ifdef RTE_LIBRTE_TELEMETRY + #define OPT_TELEMETRY "telemetry" + OPT_TELEMETRY_NUM, +#endif + #define OPT_MATCH_ALLOCATIONS "match-allocations" OPT_MATCH_ALLOCATIONS_NUM, - OPT_LONG_MAX_NUM + OPT_LONG_MAX_NUM, }; = extern const char eal_short_options[]; -- 2.17.1 -------------------------------------------------------------- Intel Research and Development Ireland Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact = the sender and delete all copies.