patches for DPDK stable branches
 help / color / mirror / Atom feed
* [PATCH] buildtools: fix avx512 check for Python 3.5
@ 2022-01-03 17:09 Lance Richardson
  2022-01-03 18:00 ` Dmitry Kozlyuk
  0 siblings, 1 reply; 3+ messages in thread
From: Lance Richardson @ 2022-01-03 17:09 UTC (permalink / raw)
  To: Bruce Richardson, Konstantin Ananyev, Dmitry Kozlyuk; +Cc: dev, stable

[-- Attachment #1: Type: text/plain, Size: 1154 bytes --]

Python 3.5 subprocess.run() does not have a capture_output
parameter (it is present only in 3.7 and up). Capture output
by using subprocess.PIPE for stdout instead.

Fixes: bb9cd91095b3 ("buildtools: make AVX512 check portable")
Cc: stable@dpdk.org
Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
---
 buildtools/binutils-avx512-check.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/buildtools/binutils-avx512-check.py b/buildtools/binutils-avx512-check.py
index a4e14f3593..9d7d360d95 100644
--- a/buildtools/binutils-avx512-check.py
+++ b/buildtools/binutils-avx512-check.py
@@ -15,7 +15,7 @@
     src = '__asm__("vpgatherqq {}");'.format(gather_params).encode('utf-8')
     subprocess.run(cc + ['-c', '-xc', '-o', obj.name, '-'], input=src, check=True)
     asm = subprocess.run([objdump, '-d', '--no-show-raw-insn', obj.name],
-                         capture_output=True, check=True).stdout.decode('utf-8')
+                         stdout=subprocess.PIPE, check=True).stdout.decode('utf-8')
     if gather_params not in asm:
 	    print('vpgatherqq displacement error with as')
 	    sys.exit(1)
-- 
2.25.1


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] buildtools: fix avx512 check for Python 3.5
  2022-01-03 17:09 [PATCH] buildtools: fix avx512 check for Python 3.5 Lance Richardson
@ 2022-01-03 18:00 ` Dmitry Kozlyuk
  2022-01-12 17:07   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Kozlyuk @ 2022-01-03 18:00 UTC (permalink / raw)
  To: Lance Richardson; +Cc: Bruce Richardson, Konstantin Ananyev, dev, stable

2022-01-03 12:09 (UTC-0500), Lance Richardson:
> Python 3.5 subprocess.run() does not have a capture_output
> parameter (it is present only in 3.7 and up). Capture output
> by using subprocess.PIPE for stdout instead.
> 
> Fixes: bb9cd91095b3 ("buildtools: make AVX512 check portable")
> Cc: stable@dpdk.org
> Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>

Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] buildtools: fix avx512 check for Python 3.5
  2022-01-03 18:00 ` Dmitry Kozlyuk
@ 2022-01-12 17:07   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2022-01-12 17:07 UTC (permalink / raw)
  To: Lance Richardson
  Cc: dev, Bruce Richardson, Konstantin Ananyev, dev, stable, Dmitry Kozlyuk

03/01/2022 19:00, Dmitry Kozlyuk:
> 2022-01-03 12:09 (UTC-0500), Lance Richardson:
> > Python 3.5 subprocess.run() does not have a capture_output
> > parameter (it is present only in 3.7 and up). Capture output
> > by using subprocess.PIPE for stdout instead.
> > 
> > Fixes: bb9cd91095b3 ("buildtools: make AVX512 check portable")
> > Cc: stable@dpdk.org
> > Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
> 
> Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>

Applied, thanks.



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-01-12 17:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-03 17:09 [PATCH] buildtools: fix avx512 check for Python 3.5 Lance Richardson
2022-01-03 18:00 ` Dmitry Kozlyuk
2022-01-12 17:07   ` Thomas Monjalon

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git