From: Ferruh Yigit <ferruh.yigit@xilinx.com>
To: Peng Zhang <peng.zhang@corigine.com>
Cc: <niklas.soderlund@corigine.com>, <oss-drivers@corigine.com>,
<stable@dpdk.org>, Yong Xu <yong.xu@corigine.com>,
Chaoyong He <chaoyong.he@corigine.com>, <dev@dpdk.org>
Subject: Re: [PATCH v2] net/nfp: fix bug of disable VLAN strip
Date: Tue, 31 May 2022 14:27:46 +0100 [thread overview]
Message-ID: <626c0852-1e6a-d6df-66c6-84edf4a056a1@xilinx.com> (raw)
In-Reply-To: <20220526143444.990674-1-peng.zhang@corigine.com>
On 5/26/2022 3:34 PM, Peng Zhang wrote:
> "vlan set strip off 0" can't work, due to the incorrect usage
> of the mask, it just represent that the status is changed or not,
> not represent offloaded or not, so that the driver send the
> error control message to the nic.
>
> Now, by first inspect the mask of things that changed, and then
> change the requested state if VLAN stripping according the
> requested offload status. So this change can fix this bug.
>
> Fixes: d4a27a3b092a ("nfp: add basic features")
> Cc:stable@dpdk.org
>
> Signed-off-by: Peng Zhang<peng.zhang@corigine.com>
> Signed-off-by: Yong Xu<yong.xu@corigine.com>
> Signed-off-by: Chaoyong He<chaoyong.he@corigine.com>
> Signed-off-by: Niklas Söderlund<niklas.soderlund@corigine.com>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2022-05-31 13:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 8:38 [PATCH] net/nfp: fix the issue about set the vlan strip offload off Peng Zhang
2022-05-20 15:20 ` Ferruh Yigit
2022-05-23 21:16 ` Niklas Söderlund
2022-05-24 12:57 ` Ferruh Yigit
2022-05-26 14:34 ` [PATCH v2] net/nfp: fix bug of disable VLAN strip Peng Zhang
2022-05-31 13:27 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=626c0852-1e6a-d6df-66c6-84edf4a056a1@xilinx.com \
--to=ferruh.yigit@xilinx.com \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=niklas.soderlund@corigine.com \
--cc=oss-drivers@corigine.com \
--cc=peng.zhang@corigine.com \
--cc=stable@dpdk.org \
--cc=yong.xu@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).