From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5092C48BAE for ; Wed, 26 Nov 2025 01:40:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 000324029A; Wed, 26 Nov 2025 01:40:01 +0100 (CET) Received: from canpmsgout06.his.huawei.com (canpmsgout06.his.huawei.com [113.46.200.221]) by mails.dpdk.org (Postfix) with ESMTP id E4AF74029A for ; Wed, 26 Nov 2025 01:40:00 +0100 (CET) dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=9VEOFNNhli8lyYmK6DVpDp8QjRqr02U+aT+iOSqKDZA=; b=YFUqOpQqims+R1jfuX7dMVIDOVuRcIR31l43ZlZkgh9GJ9419wEd+ySJHe6ykd5geZqMJvySF S0gW28uxYW56xN59aFtNG4R0n6Hn259h0YFwLFbo+JJUqMUc/RsghzFQMXYlJjo2BJCwC3UUFcj W2PENC8a4BDIvxmFI4u0Xtk= Received: from mail.maildlp.com (unknown [172.19.163.174]) by canpmsgout06.his.huawei.com (SkyGuard) with ESMTPS id 4dGLJK4ZtHzRhQq; Wed, 26 Nov 2025 08:38:09 +0800 (CST) Received: from kwepemk500009.china.huawei.com (unknown [7.202.194.94]) by mail.maildlp.com (Postfix) with ESMTPS id 5B8EB14027A; Wed, 26 Nov 2025 08:39:57 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by kwepemk500009.china.huawei.com (7.202.194.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 26 Nov 2025 08:39:56 +0800 Message-ID: <62920f36-c536-48ab-83ea-e094ea21a479@huawei.com> Date: Wed, 26 Nov 2025 08:39:56 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 24.11 1/3] [PATCH 24.11] vhost: fix compile error when without vduse.h To: Kevin Traynor , CC: References: <20251125015130.12867-1-fengchengwen@huawei.com> <20251125015130.12867-2-fengchengwen@huawei.com> <21aa83aa-b145-4412-b4ef-e607e2ca4964@redhat.com> Content-Language: en-US From: fengchengwen In-Reply-To: <21aa83aa-b145-4412-b4ef-e607e2ca4964@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: kwepems200002.china.huawei.com (7.221.188.68) To kwepemk500009.china.huawei.com (7.202.194.94) X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 11/25/2025 6:30 PM, Kevin Traynor wrote: > On 25/11/2025 01:51, Chengwen Feng wrote: >> Fix compile error when don't set VHOST_HAS_VDUSE. >> >> Fixes: 0ea4b51e84ce ("vhost: fix external buffer in VDUSE") >> >> Signed-off-by: Chengwen Feng >> --- >> lib/vhost/vduse.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lib/vhost/vduse.h b/lib/vhost/vduse.h >> index 353f297d5a..e923aeac56 100644 >> --- a/lib/vhost/vduse.h >> +++ b/lib/vhost/vduse.h >> @@ -17,7 +17,7 @@ int vduse_device_destroy(const char *path); >> #else >> >> static inline int >> -vduse_device_create(const char *path, bool compliant_ol_flags, bool extbuf, bool linearbuf); >> +vduse_device_create(const char *path, bool compliant_ol_flags, bool extbuf, bool linearbuf) >> { >> RTE_SET_USED(compliant_ol_flags); >> RTE_SET_USED(extbuf); > > Ah, thanks for finding this. This was a mistake in rebasing for 24.11 > that was not caught as the VHOST_HAS_VDUSE is set. > > The commit referenced is not pushed yet, so I will fix it directly there > before push, rather than introducing the issue and then fixing it. Okay, I happened to compile dpdk on the old kernel which don't support vduse. > > Thanks again for catching it, > Kevin. > >