patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: stable@dpdk.org, dev@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v2] mem: warn user when running without NUMA support
Date: Thu, 28 Mar 2019 21:29:29 +0100	[thread overview]
Message-ID: <6372870.QIItS3NvGG@xps> (raw)
In-Reply-To: <1eaac2264febd5c36654a90b0cc13ba43a0b28ca.1553693720.git.anatoly.burakov@intel.com>

27/03/2019 14:35, Anatoly Burakov:
> Running in non-legacy mode on a NUMA-enabled system without libnuma
> is unsupported, so explicitly print out a warning when trying to
> do so.
> 
> Running in legacy mode without libnuma is still supported whether or
> not we are running with libnuma support enabled, so also fix init to
> allow that scenario.
> 
> Cc: stable@dpdk.org
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
> 
> Notes:
>     v2:
>     - Removed unneeded eal_options include that broke the compile

There is another error when building build-arm64-host-clang:

../lib/librte_eal/linux/eal/eal_memory.c: In function 'rte_eal_memseg_init':
../lib/librte_eal/linux/eal/eal_memory.c:2437:40: error: expected ')' before 'OPT_LEGACY_MEM'
   RTE_LOG(WARNING, EAL, "Please use --"OPT_LEGACY_MEM" option, or recompile with NUMA support.\n");
                                        ^~~~~~~~~~~~~~




  reply	other threads:[~2019-03-28 20:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-22 15:59 [dpdk-stable] [PATCH] " Anatoly Burakov
2019-03-27 10:31 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2019-03-27 11:52   ` Burakov, Anatoly
2019-03-27 13:35 ` [dpdk-stable] [PATCH v2] " Anatoly Burakov
2019-03-28 20:29   ` Thomas Monjalon [this message]
2019-03-29 12:30   ` [dpdk-stable] [PATCH v3] " Anatoly Burakov
2019-03-29 12:43     ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2019-03-29 14:01     ` [dpdk-stable] [PATCH v4] " Anatoly Burakov
2019-03-29 23:27       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6372870.QIItS3NvGG@xps \
    --to=thomas@monjalon.net \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).