From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0F5CA04FF for ; Tue, 22 Mar 2022 11:39:20 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9BA0A40151; Tue, 22 Mar 2022 11:39:20 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3CF1D40151 for ; Tue, 22 Mar 2022 11:39:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647945558; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O6ZuFWDqzIsTwa3q1fjeKLNpMMdB0cfDFhVdMEEkwjM=; b=TZgLfnZb0/e3BiKrmhTlNSsjQdYXDM5vdhRqYfKOhxTqUSb+ckNIZ6vg4ZPoYIEuYGhoDT Q9FQWupJ9Ba563cct+t+1iTR+YUme7vwKiT5KHhOm1sQjjSZStw7V9LaRK85l2n+k1BAf4 jJisfXqFY330l+twEDWKGSPigWolSYM= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-648-VPp8qAjSMV6bIglXQe2QZQ-1; Tue, 22 Mar 2022 06:39:15 -0400 X-MC-Unique: VPp8qAjSMV6bIglXQe2QZQ-1 Received: by mail-wm1-f69.google.com with SMTP id h127-20020a1c2185000000b0038c6f7e22a4so924838wmh.9 for ; Tue, 22 Mar 2022 03:39:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:references:from:subject:in-reply-to :content-transfer-encoding; bh=O6ZuFWDqzIsTwa3q1fjeKLNpMMdB0cfDFhVdMEEkwjM=; b=MRycRkH//YewyDARXs5aFoECuip/Rxwo64ras0wajg4qRL9bElG0VMKPzmejLcrac/ 68zCJa3ygDmHAcui5ZVptMsezO8dj4nIelkcNoJ+GUpF/MuGbyXyte25cIgQlUO9ovMA 9mosqh4t+3/G/FximQnA/FuGBZ3lgMm59MQYmNfuwz6BT4BXEjT6tLSyPWLMU6oqyv4u qWhv418KT4OR39PB5UgHyV+XbzAbmMM66qEXb4lZHd7aFnbSv9lBBfEIjgR1+m/th4+5 1E9lLJmpkm5xkoa2C+ycVzvoo7kHgAoGsgItuptrMYQoD3U0lu9mVTOZPCREougXroGv bNxg== X-Gm-Message-State: AOAM5321QnPloV2T5ix9Sbz3k0vADCJtm9zttaSlMrzKUzyUcw01tuE+ CPxNQP+/I8peICRiiJENLc12xWZpr8dbstqhem2pcw0WhHQwCvvOJvbdnUBEZ2VyH5AGqw77WJQ joVyylsw= X-Received: by 2002:a5d:6f0d:0:b0:203:dc69:2e69 with SMTP id ay13-20020a5d6f0d000000b00203dc692e69mr20922264wrb.533.1647945554257; Tue, 22 Mar 2022 03:39:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwS5afoym+5ZfYPBv0yEcrzb1BnzRm9LMEX6DYNP8Z4zj4YUAZTcU5Miwqm6xnCNL1ZFZE5RQ== X-Received: by 2002:a5d:6f0d:0:b0:203:dc69:2e69 with SMTP id ay13-20020a5d6f0d000000b00203dc692e69mr20922250wrb.533.1647945554044; Tue, 22 Mar 2022 03:39:14 -0700 (PDT) Received: from [192.168.0.36] ([78.17.178.139]) by smtp.gmail.com with ESMTPSA id p16-20020a5d6390000000b00203ffebddf3sm12315565wru.99.2022.03.22.03.39.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Mar 2022 03:39:13 -0700 (PDT) Message-ID: <6376a40f-d2b2-dbe7-f9a2-d3be728c38c2@redhat.com> Date: Tue, 22 Mar 2022 10:39:12 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 To: "De Lara Guarch, Pablo" , "luca.boccassi@gmail.com" , "stable@dpdk.org" References: <20220314110559.1502861-1-pablo.de.lara.guarch@intel.com> <386cb1f9-b82a-4988-bb34-9536ef2c51fa@redhat.com> <3a9ab8af-0a11-248d-24e3-37c7bde7b850@redhat.com> From: Kevin Traynor Subject: Re: [PATCH 20.11 1/2] crypto/ipsec_mb: fix length and offset settings In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 21/03/2022 20:02, De Lara Guarch, Pablo wrote: > Hi Kevin, > >> -----Original Message----- >> From: Kevin Traynor >> Sent: Tuesday, March 15, 2022 11:19 AM >> To: De Lara Guarch, Pablo ; >> luca.boccassi@gmail.com; stable@dpdk.org >> Subject: Re: [PATCH 20.11 1/2] crypto/ipsec_mb: fix length and offset settings >> >> On 15/03/2022 11:10, Kevin Traynor wrote: >>> Hi Pablo, >>> >>> On 14/03/2022 11:05, Pablo de Lara wrote: >>>> [ upstream commit a501609ea6466ed8526c0dfadedee332a4d4a451 ] >>>> >>>> KASUMI, SNOW3G and ZUC require lengths and offsets to be set in bits >>>> or bytes depending on the algorithm. >>>> There were some algorithms that were mixing these two, so this commit >>>> is fixing this issue. >>>> >>>> Fixes: ae8e085c608d ("crypto/aesni_mb: support KASUMI F8/F9") >>>> Fixes: 6c42e0cf4d12 ("crypto/aesni_mb: support SNOW3G-UEA2/UIA2") >>>> Fixes: fd8df85487c4 ("crypto/aesni_mb: support ZUC-EEA3/EIA3") >>>> >>>> Signed-off-by: Pablo de Lara >>>> --- >>> >>> For 21.11. I backported and applied a501609ea6466 from dpdk main >>> branch to 21.11 branch [0]. The version sent here directly to 20.11 is >>> quite different as it adds the 'switch (job->cipher_mode)'. (It feels >>> like some other patch adding 'switch (job->cipher_mode)' was missed >>> for >>> backported) >>> >>> As this switch is not in [0], the following GMAC patch [1] won't apply >>> for 21.11. >>> >>> One option is that you send a patch to just add the missing parts, and >>> then I apply the GMAC patch. >>> >>> But the simplest option is that I revert [0], apply updated 20.11 >>> version + GMAC patch. >>> >>> I'll go with the latter option (assuming they apply cleanly), but >>> please let me know if that sounds ok. >>> >> >> I just noticed Luca is reporting build failures. In that case, please send these 2 >> patches rebased for 21.11 branch as well. If the same patches work for >> 20.11/21.11 you can indicate in the subject-prefix. I will revert [0] and apply >> those. >> > > I'll wait for the build issue on 20.11 to be resolved (I think it's system environment related), > but I think all we need is the second patch (crypto/ipsec_mb: fix GMAC parameters setting). > I can send it as soon as this is done. > Sure, i'll hold off the revert and wait for rework of GMAC patch. You can base rework off the 21.11 branch on dpdk-stable tree on dpdk.org as it is almost fully up to date. thanks, Kevin. > Thanks, > Pablo > >>> thanks, >>> Kevin >>> >>> [0] >>> http://git.dpdk.org/dpdk-stable/commit/?h=21.11&id=daf06c45e8576d8a2a8 >>> 6455e33e2bc4574f8f8b4 >>> >>> [1] 837269c2e5c5 ("crypto/ipsec_mb: fix GMAC parameters setting") >>> >>> >