From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 97CD242C9D for ; Tue, 13 Jun 2023 03:43:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9136A42670; Tue, 13 Jun 2023 03:43:01 +0200 (CEST) Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mails.dpdk.org (Postfix) with ESMTP id 52E8540C35; Tue, 13 Jun 2023 03:42:58 +0200 (CEST) Received: from loongson.cn (unknown [10.20.42.90]) by gateway (Coremail) with SMTP id _____8BxKuqgyYdkxlgEAA--.9202S3; Tue, 13 Jun 2023 09:42:56 +0800 (CST) Received: from [10.20.42.90] (unknown [10.20.42.90]) by localhost.localdomain (Coremail) with SMTP id AQAAf8AxPMqfyYdk6BcYAA--.60090S3; Tue, 13 Jun 2023 09:42:55 +0800 (CST) Subject: Re: [PATCH v3] net/ixgbe: add proper memory barriers for some Rx functions To: Thomas Monjalon , Ruifeng Wang , "Zhang, Qi Z" Cc: dev@dpdk.org, "mb@smartsharesystems.com" , "konstantin.v.ananyev@yandex.ru" , "Yang, Qiming" , "Wu, Wenjun1" , "drc@linux.vnet.ibm.com" , "roretzla@linux.microsoft.com" , "stable@dpdk.org" , "maobibo@loongson.cn" , nd , david.marchand@redhat.com, honnappa.nagarahalli@arm.com, Tyler Retzlaff , konstantin.ananyev@huawei.com References: <20230424090532.367194-1-zhoumin@loongson.cn> <3202143.AJdgDx1Vlc@thomas> <38333053.10thIPus4b@thomas> From: zhoumin Message-ID: <63d8f649-b718-a2f8-52b5-270747157413@loongson.cn> Date: Tue, 13 Jun 2023 09:42:55 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <38333053.10thIPus4b@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-CM-TRANSID: AQAAf8AxPMqfyYdk6BcYAA--.60090S3 X-CM-SenderInfo: 52kr3ztlq6z05rqj20fqof0/ X-Coremail-Antispam: 1Uk129KBj93XoW7tw48WF13Jw43WrW5tF45XFc_yoW8GF18pF 1xGF4UAw4DXFy5Cw17tw4xCr1jkan5Kr48X3s5KrykZF90qa4YyF4aqw18uw18Cr18G3W2 vF47W34xW3W5ZFgCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUvYb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv6xkF7I0E14v2 6r4j6r4UJwAS0I0E0xvYzxvE52x082IY62kv0487Mc804VCY07AIYIkI8VC2zVCFFI0UMc 02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUGVWUXwAv7VC2z280aVAF wI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JMxk0xIA0c2IEe2xFo4 CEbIxvr21l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG 67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r4a6rW5MI IYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E 14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJV W8JwCI42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07jUsqXU UUUU= X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi Thomas, On Mon, June 12, 2023 at 8:44PM, Thomas Monjalon wrote: > 12/06/2023 13:58, zhoumin: >> On Mon, June 12, 2023 at 6:26PM, Thomas Monjalon wrote: >>> 15/05/2023 04:10, Zhang, Qi Z: >>>> From: Ruifeng Wang >>>>> From: Min Zhou >>>>>> --- >>>>>> v3: >>>>>> - Use rte_smp_rmb() as the proper memory barrier instead of rte_rmb() >>>>>> --- >>>>>> v2: >>>>>> - Make the calling of rte_rmb() for all platforms >>>>>> --- >>> [...] >>>>> Reviewed-by: Ruifeng Wang >>>> Applied to dpdk-next-net-intel. >>>> >>>> Thanks >>>> Qi >>>> >>> Why ignoring checkpatch? >>> It is saying: >>> " >>> Warning in drivers/net/ixgbe/ixgbe_rxtx.c: >>> Using rte_smp_[r/w]mb >>> " >> >> I'm sorry. Should we never use rte_smp_[r/w]mb in the driver's code? > No we should avoid. > It has been decided to slowly replace such barriers. > By the way, I think it is not enough documented. > You can find an explanation in doc/guides/rel_notes/deprecation.rst Thank your for providing the reference documents. I have read this file. The explanation is clear and I get it. > I think we should also add some notes to > lib/eal/include/generic/rte_atomic.h Yes, I do think so. The notes added at the definitions of rte_smp_[r/w]mb are better. > Tyler, Honnappa, Ruifeng, Konstantin, what do you think? >