From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Shahaf Shuler <shahafs@mellanox.com>
Cc: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v2] net/mlx5: fix link status query
Date: Wed, 1 Feb 2017 11:13:59 +0000 [thread overview]
Message-ID: <64089318-6d12-28b4-61e8-6e52785ce692@intel.com> (raw)
In-Reply-To: <20170201090711.GP10133@6wind.com>
On 2/1/2017 9:07 AM, Adrien Mazarguil wrote:
> On Wed, Feb 01, 2017 at 06:53:55AM +0000, Shahaf Shuler wrote:
>> : Tuesday, January 31, 2017 6:17 PM, Ferruh Yigit:
>>> On 1/31/2017 11:45 AM, Shahaf Shuler wrote:
>>>> Trying to query the link status through new kernel ioctl API
>>>> ETHTOOL_GLINKSETTINGS was always failing due to kernel bug.
>>>> The bug was fixed on version 4.9
>>>> this patch uses the legacy ioctl API for lower kernels.
>>>>
>>>> Fixes: 188408719888 ("net/mlx5: fix support for newer link speeds")
>>>> CC: stable@dpdk.org
>>>>
>>>> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
>>>> ---
>>>
>>> <...>
>>>
>>>> @@ -707,7 +708,7 @@ struct priv *
>>>> static int
>>>> mlx5_link_update_unlocked_gs(struct rte_eth_dev *dev, int
>>>> wait_to_complete) { -#ifdef ETHTOOL_GLINKSETTINGS
>>>> +#if KERNEL_VERSION(4, 9, 0) <= LINUX_VERSION_CODE
>>>
>>> Mostly it is not good idea to do kernel version check in the .c file.
>>>
>>> It is possible to move this comparison to the .h file, and set a feature
>>> macro based on comparison result, like HAVE_ETHTOOL_GLINKSETTINGS,
>>> and
>>> use this macro in the .c file.
>>>
>>> This makes .c code easier to understand. And the abstraction in the
>>> header file lets you update the comparison in the future without
>>> changing the code itself.
>>>
>>> But it is your call, do you prefer to continue with this one?
>>
>> This is a good suggestion.
>> Adrien, Nélio what do you think?
>
> Let's include this patch as-is. Doing so in a header file such as mlx5.h
> would require including linux/version.h from that file and cause the entire
> PMD to be even more OS-dependent.
>
> We'll move this check elsewhere in the future if we need several such
> workarounds, thanks.
OK.
One more thing, comment log says:
"The bug was fixed on version 4.9"
And code does:
"+#if KERNEL_VERSION(4, 9, 0) <= LINUX_VERSION_CODE"
If the bug is fixed in 4.9, should check be "<" instead of "<="
>
>>>> struct priv *priv = mlx5_get_priv(dev);
>>>> struct ethtool_link_settings edata = {
>>>> .cmd = ETHTOOL_GLINKSETTINGS,
>>> <...>
>
next prev parent reply other threads:[~2017-02-01 11:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 12:42 [dpdk-stable] [PATCH 1/2] " Shahaf Shuler
2017-01-30 15:25 ` Nélio Laranjeiro
2017-01-31 11:44 ` [dpdk-stable] [PATCH v2] " Shahaf Shuler
2017-01-31 11:45 ` Shahaf Shuler
2017-01-31 15:42 ` Nélio Laranjeiro
2017-02-01 18:31 ` Ferruh Yigit
2017-02-02 8:20 ` Nélio Laranjeiro
2017-02-02 10:18 ` Ferruh Yigit
2017-01-31 16:17 ` Ferruh Yigit
2017-02-01 6:53 ` Shahaf Shuler
2017-02-01 9:07 ` Adrien Mazarguil
2017-02-01 11:13 ` Ferruh Yigit [this message]
2017-02-01 12:57 ` Adrien Mazarguil
2017-02-01 18:11 ` Ferruh Yigit
2017-02-02 8:45 ` Adrien Mazarguil
2017-02-02 10:15 ` Ferruh Yigit
2017-02-02 10:37 ` Adrien Mazarguil
2017-02-02 10:43 ` Ferruh Yigit
2017-02-09 12:29 ` [dpdk-stable] [PATCH v3] " Shahaf Shuler
2017-02-09 14:45 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64089318-6d12-28b4-61e8-6e52785ce692@intel.com \
--to=ferruh.yigit@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).