From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BCE941BE6 for ; Mon, 6 Feb 2023 03:31:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0BC4442686; Mon, 6 Feb 2023 03:31:47 +0100 (CET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id AA202406A2; Mon, 6 Feb 2023 03:31:43 +0100 (CET) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4P99G159rqzJsH4; Mon, 6 Feb 2023 10:30:01 +0800 (CST) Received: from [10.67.100.224] (10.67.100.224) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 6 Feb 2023 10:31:41 +0800 Subject: Re: [PATCH v11 1/3] cmdline: make rdline status not private To: Stephen Hemminger , CC: , References: <20230130200914.22049-1-stephen@networkplumber.org> <20230203191409.97567-1-stephen@networkplumber.org> <20230203191409.97567-2-stephen@networkplumber.org> From: fengchengwen Message-ID: <64363c05-de1d-9e05-ac84-4ccc0f98b166@huawei.com> Date: Mon, 6 Feb 2023 10:31:40 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20230203191409.97567-2-stephen@networkplumber.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.100.224] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Acked-by: Chengwen Feng On 2023/2/4 3:14, Stephen Hemminger wrote: > The function cmdline_poll() returns values from rdline_status enum > but that was moved to being defined only in cmdline_private.h. > > For proper use of the API the return value needs to be visible > to callers. This was not a problem before because cmdline_poll() > was not used anywhere. > > Fixes: f8f8dc289095 ("cmdline: make struct rdline opaque") > Cc: dmitry.kozliuk@gmail.com > Signed-off-by: Stephen Hemminger > --- ...