From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55E7AA00BE for ; Tue, 14 Jun 2022 11:45:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 444114282D; Tue, 14 Jun 2022 11:45:28 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 54D8640C35 for ; Tue, 14 Jun 2022 11:45:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655199925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WDecUSTkceh4BlfduHyfKdVFS2UZR/IH2/17loWK8t8=; b=W24k8l+9OMsU6Zb3gnz195aVxN6ZUzkWk4yTkrNeIi6RCAIQj/EMpebZE5oDdX52l5KR3m JNy8cxbPOvQAZSbngKOPyYQopJIvfcEhICBqAMtLWScoDrYLw1a8UdlGSGaeDd93KlzGaz Wy6RY3gpsgatY0dQWL4xCRNGSPUp0Hc= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-376-OBMnLj3UP96NPdLE4QH6ow-1; Tue, 14 Jun 2022 05:45:20 -0400 X-MC-Unique: OBMnLj3UP96NPdLE4QH6ow-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D5D87293248E; Tue, 14 Jun 2022 09:45:19 +0000 (UTC) Received: from [10.39.208.29] (unknown [10.39.208.29]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E30002026D64; Tue, 14 Jun 2022 09:45:17 +0000 (UTC) Message-ID: <6440af35-1820-ce95-cf8a-8c5fa34d1b8c@redhat.com> Date: Tue, 14 Jun 2022 11:45:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2] vdpa/mlx5: workaround var offset within page From: Maxime Coquelin To: Yajun Wu , orika@nvidia.com, viacheslavo@nvidia.com, matan@nvidia.com, shahafs@nvidia.com Cc: dev@dpdk.org, thomas@monjalon.net, rasland@nvidia.com, roniba@nvidia.com, stable@dpdk.org References: <20220314014414.251869-1-yajunw@nvidia.com> <20220315024733.507162-1-yajunw@nvidia.com> <85d52a01-116f-832e-7e5a-2f5d03cabe51@redhat.com> In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi Yajun, On 6/1/22 11:46, Maxime Coquelin wrote: > > > On 6/1/22 09:55, Maxime Coquelin wrote: >> Hi Yajun, >> >> On 3/15/22 03:47, Yajun Wu wrote: >>> vDPA driver first uses kernel driver to allocate doorbell(VAR) area for >>> each device. Then uses var->mmap_off and var->length to mmap uverbs >>> device >>> file as doorbell userspace virtual address. >>> >>> Current kernel driver provides var->mmap_off equal to page start of VAR. >>> It's fine with x86 4K page server, because VAR physical address is >>> only 4K >>> aligned thus locate in 4K page start. >>> >>> But with aarch64 64K page server, the actual VAR physical address has >>> offset within page(not locate in 64K page start). So vDPA driver need >>> add >>> this within page offset(caps.doorbell_bar_offset) to get right VAR >>> virtual >>> address. >>> >>> Fixes: 62c813706e4 ("vdpa/mlx5: map doorbell") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Yajun Wu >>> Acked-by: Matan Azrad >>> --- >>>   drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 9 ++++++++- >>>   1 file changed, 8 insertions(+), 1 deletion(-) >>> >> >> Reviewed-by: Maxime Coquelin >> >> Thanks, >> Maxime >> > > > The patch does not apply, could you please rebase it on top of next- > virtio? Gentle reminder if you want your patch to be part of the next pull request. > Thanks in advance, > Maxime