From: Thomas Monjalon <thomas@monjalon.net>
To: Vivek Kumar Sharma <viveksharma@marvell.com>
Cc: stable@dpdk.org, "dev@dpdk.org" <dev@dpdk.org>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
"arybchenko@solarflare.com" <arybchenko@solarflare.com>,
"intoviveksharma@gmail.com" <intoviveksharma@gmail.com>,
Stephen Hemminger <stephen@networkplumber.org>,
"ramirose@gmail.com" <ramirose@gmail.com>
Subject: Re: [dpdk-stable] [EXT] Re: [PATCH v2] ethdev: fix QinQ strip offload support
Date: Thu, 18 Apr 2019 10:07:52 +0200 [thread overview]
Message-ID: <64842434.YePMVcpFdi@xps> (raw)
In-Reply-To: <DM6PR18MB290778A35D51B6BFF3C75D48BB260@DM6PR18MB2907.namprd18.prod.outlook.com>
18/04/2019 09:38, Vivek Kumar Sharma:
> >> From: Vivek Sharma <viveksharma@marvell.com>
> >>
> >> Enable missing support for QinQ strip rx offload
> >> in vlan offload set/get methods.
> >>
> >> Fixes: cc9d0456b870 ("i40e: support double vlan stripping and insertion")
> >> Cc: stable@dpdk.org
>
> >Not sure it is a fix.
> >The commit mentioned above allows some kind of offload config.
> >You are extending the offload config with support in
> >rte_eth_dev_set_vlan_offload().
>
> DEV_RX_OFFLOAD_QINQ_STRIP was introduced in cc9d0456b870 ("i40e: support double vlan stripping and insertion"). But, the means to utilize this capability by enabling this rx offload for an ethdev was missing from the patch. The current patch fixes that missing functionality so that user can enable QinQ strip rx offload for capable devices.
It was possible to utilize the offload by setting the flag in mbuf.
You are adding a way to configure it at port level. So it is not a fix.
prev parent reply other threads:[~2019-04-18 8:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-14 11:11 [dpdk-stable] [PATCH] " viveksharma
2019-04-15 15:54 ` [dpdk-stable] [dpdk-dev] " Stephen Hemminger
2019-04-15 21:33 ` Rami Rosen
2019-04-17 7:40 ` [dpdk-stable] [PATCH v2] " viveksharma
2019-04-17 8:34 ` Thomas Monjalon
2019-04-18 7:38 ` [dpdk-stable] [EXT] " Vivek Kumar Sharma
2019-04-18 8:07 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64842434.YePMVcpFdi@xps \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=intoviveksharma@gmail.com \
--cc=ramirose@gmail.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=viveksharma@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).