[PATCH] net/nfp: update incorrect MAC stats offset

[PATCH] net/nfp: update incorrect MAC stats offset

[Chaoyong He]

From: James Hershaw <james.hershaw@corigine.com>

The pointer to the beginning of the MAC stats counters for port 1 are
incorrectly set as the pointer to the beginning of the port 0 MAC stats
counters, plus the size of the MAC stats counters multiplied by the port
number.

This patch corrects this by setting the multiplier as the eth_table
index of the port.

Fixes: f26e82397f6d ("net/nfp: implement xstats")
Cc: stable@dpdk.org

Signed-off-by: James Hershaw <james.hershaw@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
---
 drivers/net/nfp/nfp_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c
index ebc5538291..0645123c99 100644
--- a/drivers/net/nfp/nfp_ethdev.c
+++ b/drivers/net/nfp/nfp_ethdev.c
@@ -547,7 +547,8 @@ nfp_net_init(struct rte_eth_dev *eth_dev)
 			return -ENODEV;
 		/* Use port offset in pf ctrl_bar for this ports control bar */
 		hw->ctrl_bar = pf_dev->ctrl_bar + (port * NFP_PF_CSR_SLICE_SIZE);
-		hw->mac_stats = app_fw_nic->ports[0]->mac_stats_bar + (port * NFP_MAC_STATS_SIZE);
+		hw->mac_stats = app_fw_nic->ports[0]->mac_stats_bar +
+				(hw->nfp_idx * NFP_MAC_STATS_SIZE);
 	}
 
 	PMD_INIT_LOG(DEBUG, "ctrl bar: %p", hw->ctrl_bar);
-- 
2.39.1

Re: [PATCH] net/nfp: update incorrect MAC stats offset

[Ferruh Yigit]

On 10/10/2023 7:09 AM, Chaoyong He wrote:
> From: James Hershaw <james.hershaw@corigine.com>
> 
> The pointer to the beginning of the MAC stats counters for port 1 are
> incorrectly set as the pointer to the beginning of the port 0 MAC stats
> counters, plus the size of the MAC stats counters multiplied by the port
> number.
> 
> This patch corrects this by setting the multiplier as the eth_table
> index of the port.
> 
> Fixes: f26e82397f6d ("net/nfp: implement xstats")
> Cc: stable@dpdk.org
> 
> Signed-off-by: James Hershaw <james.hershaw@corigine.com>
> Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> 
Applied to dpdk-next-net/main, thanks.